Do not leak HandlerThread in SystemEventsReceiver

Author: romtsn

sentry-android-core/src/main/java/io/sentry/android/core/SystemEventsBreadcrumbsIntegration.java

@@ -66,6 +66,7 @@ public final class SystemEventsBreadcrumbsIntegration
   private volatile boolean isClosed = false;
   private volatile boolean isStopped = false;
   private volatile IntentFilter filter = null;
+  private volatile HandlerThread handlerThread = null;
   private final @NotNull AtomicBoolean isReceiverRegistered = new AtomicBoolean(false);
   private final @NotNull AutoClosableReentrantLock receiverLock = new AutoClosableReentrantLock();
   // Track previous battery state to avoid duplicate breadcrumbs when values haven't changed
@@ -141,13 +142,16 @@ private void registerReceiver(
                       filter.addAction(item);
                     }
                   }
-                  try {
-                    // registerReceiver can throw SecurityException but it's not documented in the
-                    // official docs
-                    final @NotNull HandlerThread handlerThread =
+                  if (handlerThread == null) {
+                    handlerThread =
                         new HandlerThread(
                             "SystemEventsReceiver", Process.THREAD_PRIORITY_BACKGROUND);
                     handlerThread.start();
+                  }
+                  try {
+                    // registerReceiver can throw SecurityException but it's not documented in the
+                    // official docs
+
                     // onReceive will be called on this handler thread
                     final @NotNull Handler handler = new Handler(handlerThread.getLooper());
                     ContextUtils.registerReceiver(context, options, receiver, filter, handler);
@@ -204,6 +208,8 @@ public void close() throws IOException {
     try (final @NotNull ISentryLifecycleToken ignored = receiverLock.acquire()) {
       isClosed = true;
       filter = null;
+      handlerThread.quit();
+      handlerThread = null;
     }
 
     AppState.getInstance().removeAppStateListener(this);

sentry/src/main/java/io/sentry/ISentryExecutorService.java

@@ -46,7 +46,8 @@ Future<?> schedule(final @NotNull Runnable runnable, final long delayMillis)
    */
   boolean isClosed();
 
-  /** Pre-warms the executor service by increasing the initial queue capacity. SHOULD be called
+  /**
+   * Pre-warms the executor service by increasing the initial queue capacity. SHOULD be called
    * directly after instantiating this executor service.
    */
   void prewarm();