Skip to content

Commit 2ea0893

Browse files
committed
Fix tests and remove slop
1 parent b37b2eb commit 2ea0893

File tree

1 file changed

+4
-18
lines changed

1 file changed

+4
-18
lines changed

sentry-android-core/src/test/java/io/sentry/android/core/SentryScreenshotOptionsTest.kt

Lines changed: 4 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,9 @@ class SentryScreenshotOptionsTest {
4343
assertTrue(
4444
options.maskViewClasses.contains(SentryMaskingOptions.ANDROIDX_MEDIA_VIEW_CLASS_NAME)
4545
)
46+
assertTrue(
47+
options.maskViewClasses.contains(SentryMaskingOptions.ANDROIDX_MEDIA_VIEW_CLASS_NAME)
48+
)
4649
assertTrue(options.maskViewClasses.contains(SentryMaskingOptions.EXOPLAYER_CLASS_NAME))
4750
assertTrue(options.maskViewClasses.contains(SentryMaskingOptions.EXOPLAYER_STYLED_CLASS_NAME))
4851
}
@@ -57,23 +60,6 @@ class SentryScreenshotOptionsTest {
5760
assertTrue(options.unmaskViewClasses.contains(SentryMaskingOptions.IMAGE_VIEW_CLASS_NAME))
5861
}
5962

60-
@Test
61-
fun `enabling both maskAllText and maskAllImages adds all expected classes`() {
62-
val options = SentryScreenshotOptions()
63-
options.setMaskAllText(true)
64-
options.setMaskAllImages(true)
65-
66-
assertTrue(options.maskViewClasses.contains(SentryMaskingOptions.TEXT_VIEW_CLASS_NAME))
67-
assertTrue(options.maskViewClasses.contains(SentryMaskingOptions.IMAGE_VIEW_CLASS_NAME))
68-
assertTrue(options.maskViewClasses.contains(SentryMaskingOptions.WEB_VIEW_CLASS_NAME))
69-
assertTrue(options.maskViewClasses.contains(SentryMaskingOptions.VIDEO_VIEW_CLASS_NAME))
70-
assertTrue(
71-
options.maskViewClasses.contains(SentryMaskingOptions.ANDROIDX_MEDIA_VIEW_CLASS_NAME)
72-
)
73-
assertTrue(options.maskViewClasses.contains(SentryMaskingOptions.EXOPLAYER_CLASS_NAME))
74-
assertTrue(options.maskViewClasses.contains(SentryMaskingOptions.EXOPLAYER_STYLED_CLASS_NAME))
75-
}
76-
7763
@Test
7864
fun `calling setMaskAllImages true multiple times does not duplicate classes`() {
7965
val options = SentryScreenshotOptions()
@@ -82,7 +68,7 @@ class SentryScreenshotOptionsTest {
8268
options.setMaskAllImages(true)
8369

8470
// CopyOnWriteArraySet should prevent duplicates
85-
assertEquals(6, options.maskViewClasses.size)
71+
assertEquals(7, options.maskViewClasses.size)
8672
}
8773

8874
@Test

0 commit comments

Comments
 (0)