Skip to content

Commit 1d140a0

Browse files
committed
read 'dist'
1 parent 22f4345 commit 1d140a0

File tree

2 files changed

+28
-0
lines changed

2 files changed

+28
-0
lines changed

sentry-android-core/src/main/java/io/sentry/android/core/ManifestMetadataReader.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ final class ManifestMetadataReader {
4141
static final String NDK_SCOPE_SYNC_ENABLE = "io.sentry.ndk.scope-sync.enable";
4242
static final String NDK_SDK_NAME = "io.sentry.ndk.sdk-name";
4343
static final String RELEASE = "io.sentry.release";
44+
static final String DIST = "io.sentry.dist";
4445
static final String ENVIRONMENT = "io.sentry.environment";
4546
static final String SDK_NAME = "io.sentry.sdk.name";
4647
static final String SDK_VERSION = "io.sentry.sdk.version";
@@ -269,6 +270,8 @@ static void applyMetadata(
269270

270271
options.setRelease(readString(metadata, logger, RELEASE, options.getRelease()));
271272

273+
options.setDist(readString(metadata, logger, DIST, options.getDist()));
274+
272275
options.setEnvironment(readString(metadata, logger, ENVIRONMENT, options.getEnvironment()));
273276

274277
options.setSessionTrackingIntervalMillis(

sentry-android-core/src/test/java/io/sentry/android/core/ManifestMetadataReaderTest.kt

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -187,6 +187,31 @@ class ManifestMetadataReaderTest {
187187
assertNull(fixture.options.release)
188188
}
189189

190+
@Test
191+
fun `applyMetadata reads dist to options`() {
192+
// Arrange
193+
val bundle = bundleOf(ManifestMetadataReader.DIST to "test-dist")
194+
val context = fixture.getContext(metaData = bundle)
195+
196+
// Act
197+
ManifestMetadataReader.applyMetadata(context, fixture.options, fixture.buildInfoProvider)
198+
199+
// Assert
200+
assertEquals("test-dist", fixture.options.dist)
201+
}
202+
203+
@Test
204+
fun `applyMetadata reads dist and keep default value if not found`() {
205+
// Arrange
206+
val context = fixture.getContext()
207+
208+
// Act
209+
ManifestMetadataReader.applyMetadata(context, fixture.options, fixture.buildInfoProvider)
210+
211+
// Assert
212+
assertNull(fixture.options.dist)
213+
}
214+
190215
@Test
191216
fun `applyMetadata reads session tracking interval to options`() {
192217
// Arrange

0 commit comments

Comments
 (0)