Revert

Author: romtsn

sentry-android-replay/src/main/java/io/sentry/android/replay/capture/CaptureStrategy.kt

@@ -58,10 +58,6 @@ internal interface CaptureStrategy {
     companion object {
         private const val BREADCRUMB_START_OFFSET = 100L
 
-        // 5 minutes, otherwise relay will just drop it. Can prevent the case where the device
-        // time is wrong and the segment is too long.
-        private const val MAX_SEGMENT_DURATION = 1000L * 60 * 5
-
         fun createSegment(
             hub: IHub?,
             options: SentryOptions,
@@ -80,7 +76,7 @@ internal interface CaptureStrategy {
             events: Deque<RRWebEvent>
         ): ReplaySegment {
             val generatedVideo = cache?.createVideoOf(
-                minOf(duration, MAX_SEGMENT_DURATION),
+                duration,
                 currentSegmentTimestamp.time,
                 segmentId,
                 height,
@@ -183,9 +179,7 @@ internal interface CaptureStrategy {
                         recordingPayload += rrwebEvent
 
                         // fill in the urls array from navigation breadcrumbs
-                        if ((rrwebEvent as? RRWebBreadcrumbEvent)?.category == "navigation" &&
-                            rrwebEvent.data?.getOrElse("to", { null }) is String
-                        ) {
+                        if ((rrwebEvent as? RRWebBreadcrumbEvent)?.category == "navigation") {
                             urls.add(rrwebEvent.data!!["to"] as String)
                         }
                     }

sentry-android-replay/src/test/java/io/sentry/android/replay/capture/SessionCaptureStrategyTest.kt

@@ -336,30 +336,6 @@ class SessionCaptureStrategyTest {
         )
     }
 
-    @Test
-    fun `does not throw when navigation destination is not a String`() {
-        val now =
-            System.currentTimeMillis() + (fixture.options.sessionReplay.sessionSegmentDuration * 5)
-        val strategy = fixture.getSut(dateProvider = { now })
-        strategy.start(fixture.recorderConfig)
-
-        fixture.scope.addBreadcrumb(Breadcrumb().apply { category = "navigation" })
-
-        strategy.onScreenshotRecorded(mock<Bitmap>()) {}
-
-        verify(fixture.scopes).captureReplay(
-            check {
-                assertNull(it.urls?.firstOrNull())
-            },
-            check {
-                val breadcrumbEvents =
-                    it.replayRecording?.payload?.filterIsInstance<RRWebBreadcrumbEvent>()
-                assertEquals("navigation", breadcrumbEvents?.first()?.category)
-                assertNull(breadcrumbEvents?.first()?.data?.get("to"))
-            }
-        )
-    }
-
     @Test
     fun `sets screen from scope as replay url`() {
         fixture.scope.screen = "MainActivity"