Skip to content

Commit 10b1e94

Browse files
committed
use non-plural option + mark integration also as internal + update API
1 parent 9933e47 commit 10b1e94

File tree

3 files changed

+24
-8
lines changed

3 files changed

+24
-8
lines changed

sentry-android-core/api/sentry-android-core.api

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -339,6 +339,7 @@ public final class io/sentry/android/core/SentryAndroidOptions : io/sentry/Sentr
339339
public fun isEnableSystemEventBreadcrumbs ()Z
340340
public fun isEnableSystemEventBreadcrumbsExtras ()Z
341341
public fun isReportHistoricalAnrs ()Z
342+
public fun isTombstoneEnabled ()Z
342343
public fun setAnrEnabled (Z)V
343344
public fun setAnrReportInDebug (Z)V
344345
public fun setAnrTimeoutIntervalMillis (J)V
@@ -367,6 +368,7 @@ public final class io/sentry/android/core/SentryAndroidOptions : io/sentry/Sentr
367368
public fun setNativeHandlerStrategy (Lio/sentry/android/core/NdkHandlerStrategy;)V
368369
public fun setNativeSdkName (Ljava/lang/String;)V
369370
public fun setReportHistoricalAnrs (Z)V
371+
public fun setTombstoneEnabled (Z)V
370372
}
371373

372374
public abstract interface class io/sentry/android/core/SentryAndroidOptions$BeforeCaptureCallback {
@@ -455,6 +457,17 @@ public final class io/sentry/android/core/SystemEventsBreadcrumbsIntegration : i
455457
public fun register (Lio/sentry/IScopes;Lio/sentry/SentryOptions;)V
456458
}
457459

460+
public class io/sentry/android/core/TombstoneIntegration : io/sentry/Integration, java/io/Closeable {
461+
public fun <init> (Landroid/content/Context;)V
462+
public fun close ()V
463+
public fun register (Lio/sentry/IScopes;Lio/sentry/SentryOptions;)V
464+
}
465+
466+
public class io/sentry/android/core/TombstoneIntegration$TombstoneProcessor : java/lang/Runnable {
467+
public fun <init> (Landroid/content/Context;Lio/sentry/IScopes;Lio/sentry/android/core/SentryAndroidOptions;Lio/sentry/transport/ICurrentDateProvider;)V
468+
public fun run ()V
469+
}
470+
458471
public final class io/sentry/android/core/UserInteractionIntegration : android/app/Application$ActivityLifecycleCallbacks, io/sentry/Integration, java/io/Closeable {
459472
public fun <init> (Landroid/app/Application;Lio/sentry/util/LoadClass;)V
460473
public fun close ()V

sentry-android-core/src/main/java/io/sentry/android/core/SentryAndroidOptions.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,7 @@ public interface BeforeCaptureCallback {
227227

228228
private @Nullable SentryFrameMetricsCollector frameMetricsCollector;
229229

230-
private boolean tombstonesEnabled = false;
230+
private boolean enableTombstone = false;
231231

232232
public SentryAndroidOptions() {
233233
setSentryClientName(BuildConfig.SENTRY_ANDROID_SDK_NAME + "/" + BuildConfig.VERSION_NAME);
@@ -305,11 +305,11 @@ public void setAnrReportInDebug(boolean anrReportInDebug) {
305305
/**
306306
* Sets Tombstone reporting (ApplicationExitInfo.REASON_CRASH_NATIVE) to enabled or disabled.
307307
*
308-
* @param tombstonesEnabled true for enabled and false for disabled
308+
* @param enableTombstone true for enabled and false for disabled
309309
*/
310310
@ApiStatus.Internal
311-
public void setTombstonesEnabled(boolean tombstonesEnabled) {
312-
this.tombstonesEnabled = tombstonesEnabled;
311+
public void setTombstoneEnabled(boolean enableTombstone) {
312+
this.enableTombstone = enableTombstone;
313313
}
314314

315315
/**
@@ -319,8 +319,8 @@ public void setTombstonesEnabled(boolean tombstonesEnabled) {
319319
* @return true if enabled or false otherwise
320320
*/
321321
@ApiStatus.Internal
322-
public boolean isTombstonesEnabled() {
323-
return tombstonesEnabled;
322+
public boolean isTombstoneEnabled() {
323+
return enableTombstone;
324324
}
325325

326326
public boolean isEnableActivityLifecycleBreadcrumbs() {

sentry-android-core/src/main/java/io/sentry/android/core/TombstoneIntegration.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,11 @@
2424
import java.util.ArrayList;
2525
import java.util.List;
2626
import java.util.concurrent.TimeUnit;
27+
import org.jetbrains.annotations.ApiStatus;
2728
import org.jetbrains.annotations.NotNull;
2829
import org.jetbrains.annotations.Nullable;
2930

31+
@ApiStatus.Internal
3032
public class TombstoneIntegration implements Integration, Closeable {
3133
static final long NINETY_DAYS_THRESHOLD = TimeUnit.DAYS.toMillis(91);
3234

@@ -58,9 +60,9 @@ public void register(@NotNull IScopes scopes, @NotNull SentryOptions options) {
5860
.log(
5961
SentryLevel.DEBUG,
6062
"TombstoneIntegration enabled: %s",
61-
this.options.isTombstonesEnabled());
63+
this.options.isTombstoneEnabled());
6264

63-
if (this.options.isTombstonesEnabled()) {
65+
if (this.options.isTombstoneEnabled()) {
6466
if (this.options.getCacheDirPath() == null) {
6567
this.options
6668
.getLogger()
@@ -87,6 +89,7 @@ public void close() throws IOException {
8789
}
8890
}
8991

92+
@ApiStatus.Internal
9093
public static class TombstoneProcessor implements Runnable {
9194

9295
@NotNull private final Context context;

0 commit comments

Comments
 (0)