chore(deps): update Cocoa SDK to v9.8.0 (#5044)

* chore: update modules/sentry-cocoa.properties to 9.8.0

* Update API definitions

* Fixed nullability

* Fixed script to avoid dirty check failure

---------

Co-authored-by: GitHub <noreply@github.com>
Co-authored-by: James Crosswell <jamescrosswell@users.noreply.github.com>

Author: 3 people

AGENTS.md

@@ -87,6 +87,7 @@ scripts/              # Build and maintenance scripts
 - **macOS only**. Requires Xcode.
 - `Sentry.Bindings.Cocoa` wraps the native Cocoa SDK.
 - Device tests run in CI only.
+- `src/Sentry.Bindings.Cocoa/ApiDefinitions.cs` and `StructsAndEnums.cs` are **auto-generated** — do not edit them directly. All changes must go in `scripts/patch-cocoa-bindings.cs` and be applied by running `scripts/generate-cocoa-bindings.ps1`.
 
 ### MAUI
 - Requires MAUI workloads: `sudo dotnet workload restore` (macOS/Linux) or `dotnet workload restore` (Windows).

modules/sentry-cocoa.properties

@@ -1,2 +1,2 @@
-version = 9.7.0
+version = 9.8.0
 repo = https://github.com/getsentry/sentry-cocoa

scripts/patch-cocoa-bindings.cs

@@ -77,6 +77,10 @@
     .RemoveAttribute("PrivateSentrySDKOnly", "CaptureViewHierarchy", "NullAllowed")
     .WithAttribute("PrivateSentrySDKOnly", "CaptureScreenshots", "return: NullAllowed")
     .WithAttribute("PrivateSentrySDKOnly", "CaptureViewHierarchy", "return: NullAllowed")
+    // Fix nullable property attributes
+    .WithPropertyAttribute("SentryOptions", "OnCrashedLastRun", "NullAllowed")
+    // Fix nullable generic type arguments
+    .ChangePropertyType("SentryOptions", "OnLastRunStatusDetermined", "Action<SentryLastRunStatus, SentryEvent?>")
     // For PrivateApiDefinitions.cs
     .WithModifier("SentryScope", "partial")
     // error CS0246: The type or namespace name 'iOS' could not be found
@@ -309,6 +313,30 @@ public static CompilationUnitSyntax WithAttribute(
         return root.ReplaceNodes(nodes, (node, _) => node.WithAttribute(attribute));
     }
 
+    public static CompilationUnitSyntax WithPropertyAttribute(
+        this CompilationUnitSyntax root,
+        string type,
+        string name,
+        string attribute)
+    {
+        var nodes = root.DescendantNodes()
+            .OfType<PropertyDeclarationSyntax>()
+            .Where(node => node.Identifier.Matches(name) && node.HasParent(type) && !node.HasAttribute(attribute));
+        return root.ReplaceNodes(nodes, (node, _) =>
+        {
+            var newAttr = SyntaxFactory.Attribute(SyntaxFactory.IdentifierName(attribute));
+            if (node.AttributeLists.Count > 0)
+            {
+                // Prepend into the first existing attribute list (e.g. [NullAllowed, Export(...)])
+                var first = node.AttributeLists[0];
+                var prepended = first.WithAttributes(
+                    SyntaxFactory.SeparatedList(new[] { newAttr }.Concat(first.Attributes)));
+                return node.WithAttributeLists(node.AttributeLists.Replace(first, prepended));
+            }
+            return (PropertyDeclarationSyntax)node.WithAttribute(attribute);
+        });
+    }
+
     public static CompilationUnitSyntax AsInternal(
         this CompilationUnitSyntax root,
         string name,

src/Sentry.Bindings.Cocoa/ApiDefinitions.cs

@@ -213,8 +213,8 @@ interface SentryBreadcrumb : SentrySerializable
     [NullAllowed, Export("origin")]
     string Origin { get; set; }
 
-    // @property (nonatomic, strong) NSDictionary<NSString *,id> * _Nullable data;
-    [NullAllowed, Export("data", ArgumentSemantic.Strong)]
+    // @property (copy, nonatomic) NSDictionary<NSString *,id> * _Nullable data;
+    [NullAllowed, Export("data", ArgumentSemantic.Copy)]
     NSDictionary<NSString, NSObject> Data { get; set; }
 
     // -(instancetype _Nonnull)initWithLevel:(SentryLevel)level category:(NSString * _Nonnull)category;
@@ -1746,10 +1746,14 @@ interface SentryOptions
     [NullAllowed, Export("beforeCaptureViewHierarchy", ArgumentSemantic.Copy)]
     SentryBeforeCaptureScreenshotCallback BeforeCaptureViewHierarchy { get; set; }
 
-    // @property (copy, nonatomic) SentryOnCrashedLastRunCallback _Nullable onCrashedLastRun;
+    // @property (copy, nonatomic) SWIFT_DEPRECATED_MSG("Use onLastRunStatusDetermined instead, which is called regardless of whether the app crashed.") SentryOnCrashedLastRunCallback onCrashedLastRun __attribute__((deprecated("Use onLastRunStatusDetermined instead, which is called regardless of whether the app crashed.")));
     [NullAllowed, Export("onCrashedLastRun", ArgumentSemantic.Copy)]
     SentryOnCrashedLastRunCallback OnCrashedLastRun { get; set; }
 
+    // @property (copy, nonatomic) void (^ _Nullable)(enum SentryLastRunStatus, SentryEvent * _Nullable) onLastRunStatusDetermined;
+    [NullAllowed, Export("onLastRunStatusDetermined", ArgumentSemantic.Copy)]
+    Action<SentryLastRunStatus, SentryEvent?> OnLastRunStatusDetermined { get; set; }
+
     // @property (nonatomic, strong) NSNumber * _Nullable sampleRate;
     [NullAllowed, Export("sampleRate", ArgumentSemantic.Strong)]
     NSNumber SampleRate { get; set; }
@@ -2736,11 +2740,16 @@ interface SentrySDK
     [Export("configureScope:")]
     void ConfigureScope(Action<SentryScope> callback);
 
-    // @property (readonly, nonatomic, class) BOOL crashedLastRun;
+    // @property (readonly, nonatomic, class) BOOL crashedLastRun __attribute__((deprecated("Use lastRunStatus instead, which distinguishes between 'did not crash' and 'unknown'.")));
     [Static]
     [Export("crashedLastRun")]
     bool CrashedLastRun { get; }
 
+    // @property (readonly, nonatomic, class) enum SentryLastRunStatus lastRunStatus;
+    [Static]
+    [Export("lastRunStatus")]
+    SentryLastRunStatus LastRunStatus { get; }
+
     // @property (readonly, nonatomic, class) BOOL detectedStartUpCrash;
     [Static]
     [Export("detectedStartUpCrash")]

src/Sentry.Bindings.Cocoa/StructsAndEnums.cs

@@ -122,6 +122,14 @@ internal enum SentryHttpStatusCode : long
     InternalServerError = 500
 }
 
+[Native]
+internal enum SentryLastRunStatus : long
+{
+    Unknown = 0,
+    DidNotCrash = 1,
+    DidCrash = 2
+}
+
 [Native]
 internal enum SentryLogLevel : long
 {