ref: Forbid unwrap except in tests and benches (#58)

Author: loewenheim

Cargo.lock

@@ -13,6 +13,9 @@ edition = "2021"
 [features]
 uuid = ["dep:uuid"]
 
+[lints.clippy]
+unwrap-used = "warn"
+
 [dependencies]
 serde = { version = "1.0.219", features = ["derive"] }
 serde_json = "1.0.140"

Cargo.toml

@@ -1,3 +1,4 @@
+#![allow(clippy::unwrap_used)]
 use criterion::{black_box, criterion_group, criterion_main, Criterion};
 use proguard::{ProguardCache, ProguardMapper, ProguardMapping};
 

benches/proguard_mapping.rs

@@ -1,3 +1,4 @@
+#![allow(clippy::unwrap_used)]
 use criterion::{black_box, criterion_group, criterion_main, Criterion};
 use proguard::{ProguardCache, ProguardMapper, ProguardMapping};
 

benches/proguard_parsing.rs

@@ -0,0 +1 @@
+allow-unwrap-in-tests = true

clippy.toml

@@ -15,13 +15,13 @@ impl ClassDebug<'_, '_> {
     fn obfuscated_name(&self) -> &str {
         self.cache
             .read_string(self.raw.obfuscated_name_offset)
-            .unwrap()
+            .unwrap_or("<unknown>")
     }
 
     fn original_name(&self) -> &str {
         self.cache
             .read_string(self.raw.original_name_offset)
-            .unwrap()
+            .unwrap_or("<unknown>")
     }
 
     fn file_name(&self) -> Option<&str> {
@@ -76,13 +76,13 @@ impl MemberDebug<'_, '_> {
     fn obfuscated_name(&self) -> &str {
         self.cache
             .read_string(self.raw.obfuscated_name_offset)
-            .unwrap()
+            .unwrap_or("<unknown>")
     }
 
     fn original_name(&self) -> &str {
         self.cache
             .read_string(self.raw.original_name_offset)
-            .unwrap()
+            .unwrap_or("<unknown>")
     }
 
     fn original_endline(&self) -> Option<u32> {

src/cache/debug.rs

@@ -129,13 +129,11 @@ fn parse_stacktrace(content: &str) -> Option<StackTrace<'_>> {
         if let Some(frame) = parse_frame(line) {
             current.frames.push(frame);
         } else if let Some(line) = line.strip_prefix("Caused by: ") {
-            current.cause = Some(Box::new(StackTrace {
+            current = current.cause.insert(Box::new(StackTrace {
                 exception: parse_throwable(line),
                 frames: vec![],
                 cause: None,
             }));
-            // We just set the `cause` so it's safe to unwrap here
-            current = current.cause.as_deref_mut().unwrap();
         }
     }