-
Notifications
You must be signed in to change notification settings - Fork 108
ci(release): Switch from action-prepare-release to Craft #5527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
BYK
wants to merge
22
commits into
master
Choose a base branch
from
ci/migrate-to-craft-action
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+48
−50
Open
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
1736a75
ci(release): Switch from action-prepare-release to Craft
BYK 2af3714
ci(release): Restore GitHub App token authentication
BYK c6c86bb
ci(release): Restore GitHub App token authentication
BYK e876603
fix: Pin actions to SHA and add permissions blocks
BYK 3720f92
fix: Add calver: true configuration for CalVer releases
BYK 38dd030
fix: Use correct action version SHAs (restore original versions)
BYK 4dc3375
fix: Use correct action version SHAs (restore original versions)
BYK bc1ec1a
fix: Clean up action version comments
BYK 32733fe
Update Craft SHA to 1c58bfd57bfd6a967b6f3fc92bead2c42ee698ce
BYK 630e289
Update Craft SHA to 1c58bfd57bfd6a967b6f3fc92bead2c42ee698ce
BYK 60fdab7
Remove changelog-preview workflow per review feedback
BYK d13a73d
Add explicit permissions block to build_binary.yml
BYK 904e96d
Add explicit permissions block to build_library.yml
BYK f1b80cd
Add explicit permissions block to ci.yml
BYK adbad65
Add explicit permissions block to enforce-license-compliance.yml
BYK 90df28a
Revert permissions changes to build_binary.yml
BYK 522251b
Revert permissions changes to build_library.yml
BYK 364cb0b
Revert permissions changes to ci.yml
BYK ae8fa20
Revert permissions changes to enforce-license-compliance.yml
BYK f866211
fix: revert extraneous changes to non-release workflow files
BYK c47299a
build(craft): Fix release workflows and config
BYK 1b3f60d
build(craft): Update Craft action to c6e2f04
BYK File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,55 +1,54 @@ | ||
| minVersion: "2.15.0" | ||
| minVersion: 2.18.0 | ||
| changelog: | ||
| policy: auto | ||
|
|
||
| statusProvider: | ||
| name: github | ||
| config: | ||
| contexts: | ||
| - "Build Docker Image (relay)" | ||
|
|
||
| - Build Docker Image (relay) | ||
| targets: | ||
| - name: github | ||
| - name: registry | ||
| apps: | ||
| app:relay: | ||
| urlTemplate: https://downloads.sentry-cdn.com/relay/{{version}}/{{file}} | ||
| includeNames: /^relay-(Darwin|Linux|Windows).*$/i | ||
| - name: gcs | ||
| bucket: sentry-sdk-assets | ||
| includeNames: /^relay-(Darwin|Windows|Linux).*$/ | ||
| paths: | ||
| - path: /relay/{{version}}/ | ||
| metadata: | ||
| cacheControl: public, max-age=2592000 | ||
| - path: /relay/latest/ | ||
| metadata: | ||
| cacheControl: public, max-age=600 | ||
| - id: release | ||
| name: docker | ||
| source: ghcr.io/getsentry/relay | ||
| target: ghcr.io/getsentry/relay | ||
| - id: release-dockerhub | ||
| name: docker | ||
| source: ghcr.io/getsentry/relay | ||
| target: getsentry/relay | ||
| - id: latest | ||
| name: docker | ||
| source: ghcr.io/getsentry/relay | ||
| target: ghcr.io/getsentry/relay | ||
| targetFormat: "{{{target}}}:latest" | ||
| - id: latest | ||
| name: docker | ||
| source: ghcr.io/getsentry/relay | ||
| target: getsentry/relay | ||
| targetFormat: "{{{target}}}:latest" | ||
|
|
||
| - name: github | ||
| - name: registry | ||
| apps: | ||
| app:relay: | ||
| urlTemplate: https://downloads.sentry-cdn.com/relay/{{version}}/{{file}} | ||
| includeNames: /^relay-(Darwin|Linux|Windows).*$/i | ||
| - name: gcs | ||
| bucket: sentry-sdk-assets | ||
| includeNames: /^relay-(Darwin|Windows|Linux).*$/ | ||
| paths: | ||
| - path: /relay/{{version}}/ | ||
| metadata: | ||
| cacheControl: public, max-age=2592000 | ||
| - path: /relay/latest/ | ||
| metadata: | ||
| cacheControl: public, max-age=600 | ||
| - id: release | ||
| name: docker | ||
| source: ghcr.io/getsentry/relay | ||
| target: ghcr.io/getsentry/relay | ||
| - id: release-dockerhub | ||
| name: docker | ||
| source: ghcr.io/getsentry/relay | ||
| target: getsentry/relay | ||
| - id: latest | ||
| name: docker | ||
| source: ghcr.io/getsentry/relay | ||
| target: ghcr.io/getsentry/relay | ||
| targetFormat: '{{{target}}}:latest' | ||
| - id: latest | ||
| name: docker | ||
| source: ghcr.io/getsentry/relay | ||
| target: getsentry/relay | ||
| targetFormat: '{{{target}}}:latest' | ||
| requireNames: | ||
| - /^relay-Darwin-x86_64$/ | ||
| - /^relay-Darwin-x86_64-dsym.zip$/ | ||
| - /^relay-Linux-x86_64$/ | ||
| - /^relay-Linux-x86_64-debug.zip$/ | ||
| - /^relay-Linux-aarch64$/ | ||
| - /^relay-Linux-aarch64-debug.zip$/ | ||
| - /^relay-Windows-x86_64-pdb.zip$/ | ||
| - /^relay-Windows-x86_64\.exe$/ | ||
| - /^relay-Darwin-x86_64$/ | ||
| - /^relay-Darwin-x86_64-dsym.zip$/ | ||
| - /^relay-Linux-x86_64$/ | ||
| - /^relay-Linux-x86_64-debug.zip$/ | ||
| - /^relay-Linux-aarch64$/ | ||
| - /^relay-Linux-aarch64-debug.zip$/ | ||
| - /^relay-Windows-x86_64-pdb.zip$/ | ||
| - /^relay-Windows-x86_64\.exe$/ | ||
| versioning: | ||
| policy: calver | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Global calver policy incorrectly applies to semver library releases
Medium Severity
The global
versioning.policy: calversetting in.craft.ymlapplies to all releases, but the Python library releases (viarelease_library.ymlwithpath: py) require semver versioning according to the PR discussion. The library release workflow has no mechanism to override this global calver policy, potentially causing version validation issues or incorrect version handling for Python library releases.Additional Locations (1)
.github/workflows/release_library.yml#L31-L38