Skip to content

Commit 56cc4d9

Browse files
mchen-sentrymchen-sentry
authored
fix: disable unnecessary fetch_materials option for pipeline-complete branches (#89)
1 parent 3b7e3b1 commit 56cc4d9

File tree

32 files changed

+231
-2
lines changed

32 files changed

+231
-2
lines changed

‎libs/gocd-stages.libsonnet‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,12 @@ This library is a set of helpers for building GoCD pipelines.
1818
else
1919
null;
2020

21+
local fetch_materials = if std.objectHas(opts, 'fetch_materials') then opts.fetch_materials else null;
22+
2123
{
2224
[name]: {
2325
[if approval != null then 'approval' else null]: approval,
26+
[if fetch_materials != null then 'fetch_materials' else null]: fetch_materials,
2427
jobs: {
2528
[name]: {
2629
tasks: tasks,

‎libs/pipedream.libsonnet‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ local pipedream_trigger_pipeline(pipedream_config) =
4545
materials: materials,
4646
lock_behavior: 'unlockWhenFinished',
4747
stages: [
48-
gocd_stages.basic('pipeline-complete', [gocd_tasks.noop], { approval: 'manual' }),
48+
gocd_stages.basic('pipeline-complete', [gocd_tasks.noop], { approval: 'manual', fetch_materials: false }),
4949
],
5050
},
5151
};
@@ -210,7 +210,7 @@ local generate_region_pipeline(pipedream_config, pipeline_fn, region, display_or
210210
// The s4s final stage completes and causes the US pipeline to
211211
// re-run. With `pipeline-complete` as the final stage, it isn't
212212
// re-run by a rollback, preventing this domino effect.
213-
gocd_stages.basic('pipeline-complete', [gocd_tasks.noop]),
213+
gocd_stages.basic('pipeline-complete', [gocd_tasks.noop], { fetch_materials: false }),
214214
],
215215
};
216216

‎test/testdata/goldens/pipedream/autodeploy-parallel.jsonnet_output-files.golden‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
},
2121
{
2222
"pipeline-complete": {
23+
"fetch_materials": false,
2324
"jobs": {
2425
"pipeline-complete": {
2526
"tasks": [
@@ -58,6 +59,7 @@
5859
},
5960
{
6061
"pipeline-complete": {
62+
"fetch_materials": false,
6163
"jobs": {
6264
"pipeline-complete": {
6365
"tasks": [
@@ -96,6 +98,7 @@
9698
},
9799
{
98100
"pipeline-complete": {
101+
"fetch_materials": false,
99102
"jobs": {
100103
"pipeline-complete": {
101104
"tasks": [
@@ -134,6 +137,7 @@
134137
},
135138
{
136139
"pipeline-complete": {
140+
"fetch_materials": false,
137141
"jobs": {
138142
"pipeline-complete": {
139143
"tasks": [
@@ -172,6 +176,7 @@
172176
},
173177
{
174178
"pipeline-complete": {
179+
"fetch_materials": false,
175180
"jobs": {
176181
"pipeline-complete": {
177182
"tasks": [
@@ -210,6 +215,7 @@
210215
},
211216
{
212217
"pipeline-complete": {
218+
"fetch_materials": false,
213219
"jobs": {
214220
"pipeline-complete": {
215221
"tasks": [
@@ -248,6 +254,7 @@
248254
},
249255
{
250256
"pipeline-complete": {
257+
"fetch_materials": false,
251258
"jobs": {
252259
"pipeline-complete": {
253260
"tasks": [
@@ -286,6 +293,7 @@
286293
},
287294
{
288295
"pipeline-complete": {
296+
"fetch_materials": false,
289297
"jobs": {
290298
"pipeline-complete": {
291299
"tasks": [

‎test/testdata/goldens/pipedream/autodeploy-parallel.jsonnet_single-file.golden‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
},
2020
{
2121
"pipeline-complete": {
22+
"fetch_materials": false,
2223
"jobs": {
2324
"pipeline-complete": {
2425
"tasks": [
@@ -52,6 +53,7 @@
5253
},
5354
{
5455
"pipeline-complete": {
56+
"fetch_materials": false,
5557
"jobs": {
5658
"pipeline-complete": {
5759
"tasks": [
@@ -85,6 +87,7 @@
8587
},
8688
{
8789
"pipeline-complete": {
90+
"fetch_materials": false,
8891
"jobs": {
8992
"pipeline-complete": {
9093
"tasks": [
@@ -118,6 +121,7 @@
118121
},
119122
{
120123
"pipeline-complete": {
124+
"fetch_materials": false,
121125
"jobs": {
122126
"pipeline-complete": {
123127
"tasks": [
@@ -151,6 +155,7 @@
151155
},
152156
{
153157
"pipeline-complete": {
158+
"fetch_materials": false,
154159
"jobs": {
155160
"pipeline-complete": {
156161
"tasks": [
@@ -184,6 +189,7 @@
184189
},
185190
{
186191
"pipeline-complete": {
192+
"fetch_materials": false,
187193
"jobs": {
188194
"pipeline-complete": {
189195
"tasks": [
@@ -217,6 +223,7 @@
217223
},
218224
{
219225
"pipeline-complete": {
226+
"fetch_materials": false,
220227
"jobs": {
221228
"pipeline-complete": {
222229
"tasks": [
@@ -250,6 +257,7 @@
250257
},
251258
{
252259
"pipeline-complete": {
260+
"fetch_materials": false,
253261
"jobs": {
254262
"pipeline-complete": {
255263
"tasks": [

‎test/testdata/goldens/pipedream/autodeploy-serial.jsonnet_output-files.golden‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
},
2525
{
2626
"pipeline-complete": {
27+
"fetch_materials": false,
2728
"jobs": {
2829
"pipeline-complete": {
2930
"tasks": [
@@ -66,6 +67,7 @@
6667
},
6768
{
6869
"pipeline-complete": {
70+
"fetch_materials": false,
6971
"jobs": {
7072
"pipeline-complete": {
7173
"tasks": [
@@ -108,6 +110,7 @@
108110
},
109111
{
110112
"pipeline-complete": {
113+
"fetch_materials": false,
111114
"jobs": {
112115
"pipeline-complete": {
113116
"tasks": [
@@ -150,6 +153,7 @@
150153
},
151154
{
152155
"pipeline-complete": {
156+
"fetch_materials": false,
153157
"jobs": {
154158
"pipeline-complete": {
155159
"tasks": [
@@ -192,6 +196,7 @@
192196
},
193197
{
194198
"pipeline-complete": {
199+
"fetch_materials": false,
195200
"jobs": {
196201
"pipeline-complete": {
197202
"tasks": [
@@ -230,6 +235,7 @@
230235
},
231236
{
232237
"pipeline-complete": {
238+
"fetch_materials": false,
233239
"jobs": {
234240
"pipeline-complete": {
235241
"tasks": [
@@ -268,6 +274,7 @@
268274
},
269275
{
270276
"pipeline-complete": {
277+
"fetch_materials": false,
271278
"jobs": {
272279
"pipeline-complete": {
273280
"tasks": [
@@ -310,6 +317,7 @@
310317
},
311318
{
312319
"pipeline-complete": {
320+
"fetch_materials": false,
313321
"jobs": {
314322
"pipeline-complete": {
315323
"tasks": [

‎test/testdata/goldens/pipedream/autodeploy-serial.jsonnet_single-file.golden‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
},
2424
{
2525
"pipeline-complete": {
26+
"fetch_materials": false,
2627
"jobs": {
2728
"pipeline-complete": {
2829
"tasks": [
@@ -60,6 +61,7 @@
6061
},
6162
{
6263
"pipeline-complete": {
64+
"fetch_materials": false,
6365
"jobs": {
6466
"pipeline-complete": {
6567
"tasks": [
@@ -97,6 +99,7 @@
9799
},
98100
{
99101
"pipeline-complete": {
102+
"fetch_materials": false,
100103
"jobs": {
101104
"pipeline-complete": {
102105
"tasks": [
@@ -134,6 +137,7 @@
134137
},
135138
{
136139
"pipeline-complete": {
140+
"fetch_materials": false,
137141
"jobs": {
138142
"pipeline-complete": {
139143
"tasks": [
@@ -171,6 +175,7 @@
171175
},
172176
{
173177
"pipeline-complete": {
178+
"fetch_materials": false,
174179
"jobs": {
175180
"pipeline-complete": {
176181
"tasks": [
@@ -204,6 +209,7 @@
204209
},
205210
{
206211
"pipeline-complete": {
212+
"fetch_materials": false,
207213
"jobs": {
208214
"pipeline-complete": {
209215
"tasks": [
@@ -237,6 +243,7 @@
237243
},
238244
{
239245
"pipeline-complete": {
246+
"fetch_materials": false,
240247
"jobs": {
241248
"pipeline-complete": {
242249
"tasks": [
@@ -274,6 +281,7 @@
274281
},
275282
{
276283
"pipeline-complete": {
284+
"fetch_materials": false,
277285
"jobs": {
278286
"pipeline-complete": {
279287
"tasks": [

‎test/testdata/goldens/pipedream/exclude-regions-autodeploy-parallel.jsonnet_output-files.golden‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
},
2121
{
2222
"pipeline-complete": {
23+
"fetch_materials": false,
2324
"jobs": {
2425
"pipeline-complete": {
2526
"tasks": [
@@ -58,6 +59,7 @@
5859
},
5960
{
6061
"pipeline-complete": {
62+
"fetch_materials": false,
6163
"jobs": {
6264
"pipeline-complete": {
6365
"tasks": [
@@ -96,6 +98,7 @@
9698
},
9799
{
98100
"pipeline-complete": {
101+
"fetch_materials": false,
99102
"jobs": {
100103
"pipeline-complete": {
101104
"tasks": [
@@ -134,6 +137,7 @@
134137
},
135138
{
136139
"pipeline-complete": {
140+
"fetch_materials": false,
137141
"jobs": {
138142
"pipeline-complete": {
139143
"tasks": [
@@ -172,6 +176,7 @@
172176
},
173177
{
174178
"pipeline-complete": {
179+
"fetch_materials": false,
175180
"jobs": {
176181
"pipeline-complete": {
177182
"tasks": [
@@ -210,6 +215,7 @@
210215
},
211216
{
212217
"pipeline-complete": {
218+
"fetch_materials": false,
213219
"jobs": {
214220
"pipeline-complete": {
215221
"tasks": [

‎test/testdata/goldens/pipedream/exclude-regions-autodeploy-parallel.jsonnet_single-file.golden‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
},
2020
{
2121
"pipeline-complete": {
22+
"fetch_materials": false,
2223
"jobs": {
2324
"pipeline-complete": {
2425
"tasks": [
@@ -52,6 +53,7 @@
5253
},
5354
{
5455
"pipeline-complete": {
56+
"fetch_materials": false,
5557
"jobs": {
5658
"pipeline-complete": {
5759
"tasks": [
@@ -85,6 +87,7 @@
8587
},
8688
{
8789
"pipeline-complete": {
90+
"fetch_materials": false,
8891
"jobs": {
8992
"pipeline-complete": {
9093
"tasks": [
@@ -118,6 +121,7 @@
118121
},
119122
{
120123
"pipeline-complete": {
124+
"fetch_materials": false,
121125
"jobs": {
122126
"pipeline-complete": {
123127
"tasks": [
@@ -151,6 +155,7 @@
151155
},
152156
{
153157
"pipeline-complete": {
158+
"fetch_materials": false,
154159
"jobs": {
155160
"pipeline-complete": {
156161
"tasks": [
@@ -184,6 +189,7 @@
184189
},
185190
{
186191
"pipeline-complete": {
192+
"fetch_materials": false,
187193
"jobs": {
188194
"pipeline-complete": {
189195
"tasks": [

0 commit comments

Comments
 (0)