fix: address review feedback — remove dead swap detection, fix AGENTS.md

- Remove unreachable detectSwappedViewArgs call from log/view.ts:
  validateHexId runs before swap detection, and valid hex IDs never
  contain '/', so the swap check could never trigger. Keep the
  looksLikeIssueShortId suggestion which still works (first arg is
  the target, not validated as hex).
- Remove stray '=======' merge conflict marker from AGENTS.md line 693
- Remove duplicate Zod lore entry (019cc303) in AGENTS.md

Addresses Seer and Cursor BugBot review comments.

Author: BYK

AGENTS.md

@@ -680,17 +680,14 @@ mock.module("./some-module", () => ({
 <!-- lore:019cc303-e397-75b9-9762-6f6ad108f50a -->
 * **Zod z.coerce.number() converts null to 0 silently**: Zod gotchas in this codebase: (1) \`z.coerce.number()\` passes input through \`Number()\`, so \`null\` silently becomes \`0\`. Be aware if \`null\` vs \`0\` distinction matters. (2) Zod v4 \`.default({})\` short-circuits — it returns the default value without parsing through inner schema defaults. So \`.object({ enabled: z.boolean().default(true) }).default({})\` returns \`{}\`, not \`{ enabled: true }\`. Fix: provide fully-populated default objects. This affected nested config sections in src/config.ts during the v3→v4 upgrade.
 
-<!-- lore:019cc303-e397-75b9-9762-6f6ad108f50a -->
-* **Zod z.coerce.number() converts null to 0 silently**: Zod gotchas in this codebase: (1) \`z.coerce.number()\` passes input through \`Number()\`, so \`null\` silently becomes \`0\`. Be aware if \`null\` vs \`0\` distinction matters. (2) Zod v4 \`.default({})\` short-circuits — it returns the default value without parsing through inner schema defaults. So \`.object({ enabled: z.boolean().default(true) }).default({})\` returns \`{}\`, not \`{ enabled: true }\`. Fix: provide fully-populated default objects. This affected nested config sections in src/config.ts during the v3→v4 upgrade.
-
 ### Pattern
 
 <!-- lore:dbd63348-2049-42b3-bb99-d6a3d64369c7 -->
 * **Branch naming and commit message conventions for Sentry CLI**: Branch naming: \`feat/\<short-description>\` or \`fix/\<issue-number>-\<short-description>\` (e.g., \`feat/ghcr-nightly-distribution\`, \`fix/268-limit-auto-pagination\`). Commit message format: \`type(scope): description (#issue)\` (e.g., \`fix(issue-list): auto-paginate --limit beyond 100 (#268)\`, \`feat(nightly): distribute via GHCR instead of GitHub Releases\`). Types seen: fix, refactor, meta, release, feat. PRs are created as drafts via \`gh pr create --draft\`. Implementation plans are attached to commits via \`git notes add\` rather than in PR body or commit message.
 
 <!-- lore:5ac4e219-ea1f-41cb-8e97-7e946f5848c0 -->
 * **PR workflow: wait for Seer and Cursor BugBot before resolving**: After pushing a PR in the getsentry/cli repo, the CI pipeline includes Seer Code Review and Cursor Bugbot as advisory checks. Both typically take 2-3 minutes but may not trigger on draft PRs — only ready-for-review PRs reliably get bot reviews. The workflow is: push → wait for all CI (including npm build jobs which test the actual bundle) → check for inline review comments from Seer/BugBot → fix if needed → repeat. Use \`gh pr checks \<PR> --watch\` to monitor. Review comments are fetched via \`gh api repos/OWNER/REPO/pulls/NUM/comments\` and \`gh api repos/OWNER/REPO/pulls/NUM/reviews\`.
-=======
+
 <!-- lore:019cc3e6-0cf5-720d-beb7-97c9c9901295 -->
 * **Codecov patch coverage only counts test:unit and test:isolated, not E2E**: CI coverage merges \`test:unit\` (\`test/lib test/commands test/types --coverage\`) and \`test:isolated\` (\`test/isolated --coverage\`) into \`coverage/merged.lcov\`. E2E tests (\`test/e2e\`) are NOT included in coverage reports. So func tests that spy on exports (e.g., \`spyOn(apiClient, 'getLogs')\`) give zero coverage to the mocked function's body. To cover \`api-client.ts\` function bodies in unit tests, mock \`globalThis.fetch\` + \`setOrgRegion()\` + \`setAuthToken()\` and call the real function.
 

src/commands/log/view.ts

@@ -9,7 +9,6 @@ import { isatty } from "node:tty";
 import type { SentryContext } from "../../context.js";
 import { getLogs } from "../../lib/api-client.js";
 import {
-  detectSwappedViewArgs,
   looksLikeIssueShortId,
   parseOrgProjectArg,
   parseSlashSeparatedArg,
@@ -75,8 +74,6 @@ function splitLogIds(arg: string): string[] {
 export function parsePositionalArgs(args: string[]): {
   logIds: string[];
   targetArg: string | undefined;
-  /** Warning message if arguments appear to be in the wrong order */
-  warning?: string;
   /** Suggestion when first arg looks like an issue short ID */
   suggestion?: string;
 } {
@@ -111,17 +108,15 @@ export function parsePositionalArgs(args: string[]): {
   if (logIds.length === 0) {
     throw new ContextError("Log ID", USAGE_HINT);
   }
-  // With exactly 2 args, detect swapped args or issue short IDs.
-  const warning =
-    args.length === 2 && args[1]
-      ? (detectSwappedViewArgs(first, args[1]) ?? undefined)
-      : undefined;
-  const suggestion =
-    !warning && looksLikeIssueShortId(first)
-      ? `Did you mean: sentry issue view ${first}`
-      : undefined;
-
-  return { logIds, targetArg: first, warning, suggestion };
+  // Swap detection is not useful here: validateHexId above rejects non-hex
+  // log IDs (which include any containing "/"), so detectSwappedViewArgs
+  // (which checks for "/" in the second arg) can never trigger.
+  // We still check for issue short IDs in the first (target) position.
+  const suggestion = looksLikeIssueShortId(first)
+    ? `Did you mean: sentry issue view ${first}`
+    : undefined;
+
+  return { logIds, targetArg: first, suggestion };
 }
 
 /**
@@ -350,11 +345,7 @@ export const viewCommand = buildCommand({
     const cmdLog = logger.withTag("log.view");
 
     // Parse positional args
-    const { logIds, targetArg, warning, suggestion } =
-      parsePositionalArgs(args);
-    if (warning) {
-      cmdLog.warn(warning);
-    }
+    const { logIds, targetArg, suggestion } = parsePositionalArgs(args);
     if (suggestion) {
       cmdLog.warn(suggestion);
     }

test/commands/log/view.test.ts

@@ -193,10 +193,9 @@ describe("parsePositionalArgs", () => {
     });
   });
 
-  describe("swap detection and suggestions", () => {
+  describe("suggestions and error handling", () => {
     test("swapped args (hex ID first, org/project second) throws ValidationError", () => {
-      // With hex validation, the second arg ("my-org/my-project") fails
-      // validateHexId before swap detection can trigger.
+      // Non-hex second arg fails validateHexId — user gets a clear error.
       expect(() =>
         parsePositionalArgs([
           "968c763c740cfda8b6728f27fb9e9b01",