fix(test): restore SENTRY_CONFIG_DIR in afterEach instead of deleting

Three test files deleted process.env.SENTRY_CONFIG_DIR in afterEach
without restoring the value set by preload.ts. Since Bun runs test
files in parallel, this caused a race condition: other test files
that capture the env var at module scope would get undefined if
their module loaded after one of these deletes ran.

Save the original value in beforeEach and restore it in afterEach,
matching the pattern already used by schema.test.ts and fix.test.ts.

Author: betegon

test/lib/db/install-info.test.ts

@@ -12,15 +12,21 @@ import {
 import { cleanupTestDir, createTestConfigDir } from "../../helpers.js";
 
 let testConfigDir: string;
+let savedConfigDir: string | undefined;
 
 beforeEach(async () => {
+  savedConfigDir = process.env.SENTRY_CONFIG_DIR;
   testConfigDir = await createTestConfigDir("test-install-info-");
   process.env.SENTRY_CONFIG_DIR = testConfigDir;
 });
 
 afterEach(async () => {
   closeDatabase();
-  delete process.env.SENTRY_CONFIG_DIR;
+  if (savedConfigDir !== undefined) {
+    process.env.SENTRY_CONFIG_DIR = savedConfigDir;
+  } else {
+    delete process.env.SENTRY_CONFIG_DIR;
+  }
   await cleanupTestDir(testConfigDir);
 });
 

test/lib/db/project-cache.test.ts

@@ -16,16 +16,22 @@ import {
 import { cleanupTestDir, createTestConfigDir } from "../../helpers.js";
 
 let testConfigDir: string;
+let savedConfigDir: string | undefined;
 
 beforeEach(async () => {
+  savedConfigDir = process.env.SENTRY_CONFIG_DIR;
   testConfigDir = await createTestConfigDir("test-project-cache-");
   process.env.SENTRY_CONFIG_DIR = testConfigDir;
 });
 
 afterEach(async () => {
   // Close database to release file handles before cleanup
   closeDatabase();
-  delete process.env.SENTRY_CONFIG_DIR;
+  if (savedConfigDir !== undefined) {
+    process.env.SENTRY_CONFIG_DIR = savedConfigDir;
+  } else {
+    delete process.env.SENTRY_CONFIG_DIR;
+  }
   await cleanupTestDir(testConfigDir);
 });
 

test/lib/version-check.test.ts

@@ -48,8 +48,10 @@ describe("shouldSuppressNotification", () => {
 describe("getUpdateNotification", () => {
   let testConfigDir: string;
   let savedNoUpdateCheck: string | undefined;
+  let savedConfigDir: string | undefined;
 
   beforeEach(async () => {
+    savedConfigDir = process.env.SENTRY_CONFIG_DIR;
     testConfigDir = await createTestConfigDir("test-version-notif-");
     process.env.SENTRY_CONFIG_DIR = testConfigDir;
     // Save and clear the env var to test real implementation
@@ -58,7 +60,11 @@ describe("getUpdateNotification", () => {
   });
 
   afterEach(async () => {
-    delete process.env.SENTRY_CONFIG_DIR;
+    if (savedConfigDir !== undefined) {
+      process.env.SENTRY_CONFIG_DIR = savedConfigDir;
+    } else {
+      delete process.env.SENTRY_CONFIG_DIR;
+    }
     // Restore the env var
     if (savedNoUpdateCheck !== undefined) {
       process.env.SENTRY_CLI_NO_UPDATE_CHECK = savedNoUpdateCheck;
@@ -117,8 +123,10 @@ describe("abortPendingVersionCheck", () => {
 describe("maybeCheckForUpdateInBackground", () => {
   let testConfigDir: string;
   let savedNoUpdateCheck: string | undefined;
+  let savedConfigDir: string | undefined;
 
   beforeEach(async () => {
+    savedConfigDir = process.env.SENTRY_CONFIG_DIR;
     testConfigDir = await createTestConfigDir("test-version-bg-");
     process.env.SENTRY_CONFIG_DIR = testConfigDir;
     // Save and clear the env var to test real implementation
@@ -129,7 +137,11 @@ describe("maybeCheckForUpdateInBackground", () => {
   afterEach(async () => {
     // Abort any pending check to clean up
     abortPendingVersionCheck();
-    delete process.env.SENTRY_CONFIG_DIR;
+    if (savedConfigDir !== undefined) {
+      process.env.SENTRY_CONFIG_DIR = savedConfigDir;
+    } else {
+      delete process.env.SENTRY_CONFIG_DIR;
+    }
     // Restore the env var
     if (savedNoUpdateCheck !== undefined) {
       process.env.SENTRY_CLI_NO_UPDATE_CHECK = savedNoUpdateCheck;