fix: address PR review — narrow catch scope, document cache assumption

1. Narrow try/catch in resolveProjectSearch to only wrap resolveFromDsn().
   Previously getIssueByShortId errors (e.g. 404) were silently caught,
   causing a fallback to findProjectsBySlug which would duplicate the
   expensive short ID resolution call before failing with the same error.

2. Add comment explaining why the org_regions cache is expected to be
   complete when findProjectsBySlug runs: the project-search format's
   short suffix only comes from `sentry issue list` output, which
   already called listOrganizations() and populated all orgs.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: betegon

src/commands/issue/utils.ts

@@ -156,19 +156,22 @@ async function resolveProjectSearch(
   //    resolveFromDsn() reads from the DSN cache (populated by detectAllDsns
   //    in tryResolveFromAlias above) + project cache. This avoids the expensive
   //    listOrganizations() fan-out when the DSN matches the target project.
+  //    Only catch resolveFromDsn errors — getIssueByShortId errors (e.g. 404)
+  //    must propagate so we don't duplicate the expensive call via fallback.
+  let dsnTarget: Awaited<ReturnType<typeof resolveFromDsn>> | undefined;
   try {
-    const dsnTarget = await resolveFromDsn(cwd);
-    if (
-      dsnTarget &&
-      dsnTarget.project.toLowerCase() === projectSlug.toLowerCase()
-    ) {
-      const fullShortId = expandToFullShortId(suffix, dsnTarget.project);
-      const issue = await getIssueByShortId(dsnTarget.org, fullShortId);
-      return { org: dsnTarget.org, issue };
-    }
+    dsnTarget = await resolveFromDsn(cwd);
   } catch {
     // DSN resolution failed — fall through to full search
   }
+  if (
+    dsnTarget &&
+    dsnTarget.project.toLowerCase() === projectSlug.toLowerCase()
+  ) {
+    const fullShortId = expandToFullShortId(suffix, dsnTarget.project);
+    const issue = await getIssueByShortId(dsnTarget.org, fullShortId);
+    return { org: dsnTarget.org, issue };
+  }
 
   // 3. Search for project across all accessible orgs
   const { projects } = await findProjectsBySlug(projectSlug.toLowerCase());

src/lib/api/projects.ts

@@ -210,6 +210,10 @@ export async function findProjectsBySlug(
 
   // Fast path: use cached org slugs to skip the expensive listOrganizations()
   // round-trip (getUserRegions + listOrganizationsInRegion).
+  // The cache is expected to be complete: callers reach this function via the
+  // project-search format (e.g. "buybridge-5BS") whose short suffix only comes
+  // from `sentry issue list` output — which already called listOrganizations()
+  // and populated org_regions with all accessible orgs.
   const cachedOrgRegions = await getAllOrgRegions();
   if (cachedOrgRegions.size > 0) {
     const cachedSlugs = [...cachedOrgRegions.keys()];