fix: address review — canTrial undefined check and deduplicate days calc

- Use `info.canTrial === false` instead of `!info.canTrial` so undefined
  (API omitted the field) does not incorrectly block plan trial activation
- Extract daysRemainingFromDate() shared helper in trials.ts, reuse in
  both getDaysRemaining() and buildPlanTrialEntry() to eliminate duplicate
  end-of-day UTC date math

Author: BYK

src/commands/trial/list.ts

@@ -14,6 +14,7 @@ import { colorTag } from "../../lib/formatters/markdown.js";
 import { type Column, writeTable } from "../../lib/formatters/table.js";
 import { resolveOrg } from "../../lib/resolve-target.js";
 import {
+  daysRemainingFromDate,
   getDaysRemaining,
   getTrialDisplayName,
   getTrialFriendlyName,
@@ -117,13 +118,7 @@ function buildPlanTrialEntry(info: CustomerTrialInfo): TrialListEntry | null {
     // Currently on a plan trial
     const planName = info.planDetails?.name ?? "Business";
     const endDate = info.trialEnd ?? null;
-    let daysRemaining: number | null = null;
-    if (endDate) {
-      const end = new Date(endDate);
-      end.setUTCHours(23, 59, 59, 999);
-      const diffMs = end.getTime() - Date.now();
-      daysRemaining = Math.max(0, Math.ceil(diffMs / (1000 * 60 * 60 * 24)));
-    }
+    const daysRemaining = endDate ? daysRemainingFromDate(endDate) : null;
     return {
       name: "plan",
       displayName: `${planName} Plan`,

src/commands/trial/start.ts

@@ -250,7 +250,8 @@ async function handlePlanTrial(
     );
   }
 
-  if (!info.canTrial) {
+  // canTrial is optional in the schema — only reject when explicitly false
+  if (info.canTrial === false) {
     throw new ValidationError(
       `No plan trial available for organization '${orgSlug}'.`,
       "name"

src/lib/trials.ts

@@ -193,6 +193,22 @@ export function getTrialStatus(trial: ProductTrial): TrialStatus {
   return "active";
 }
 
+/**
+ * Calculate days remaining from an end date string.
+ *
+ * Treats the end date as end-of-day UTC (23:59:59.999) and returns
+ * the number of calendar days until expiry, clamped to 0.
+ *
+ * @param endDate - ISO date string (e.g., "2026-04-15T00:00:00Z")
+ * @returns Number of days remaining (0+)
+ */
+export function daysRemainingFromDate(endDate: string): number {
+  const end = new Date(endDate);
+  end.setUTCHours(23, 59, 59, 999);
+  const diffMs = end.getTime() - Date.now();
+  return Math.max(0, Math.ceil(diffMs / (1000 * 60 * 60 * 24)));
+}
+
 /**
  * Calculate days remaining for an active trial.
  *
@@ -203,14 +219,7 @@ export function getDaysRemaining(trial: ProductTrial): number | null {
   if (!(trial.isStarted && trial.endDate)) {
     return null;
   }
-
-  const end = new Date(trial.endDate);
-  // Match getTrialStatus: treat endDate as end-of-day UTC
-  end.setUTCHours(23, 59, 59, 999);
-  const now = new Date();
-  const diffMs = end.getTime() - now.getTime();
-  const diffDays = Math.ceil(diffMs / (1000 * 60 * 60 * 24));
-  return Math.max(0, diffDays);
+  return daysRemainingFromDate(trial.endDate);
 }
 
 /**