fix(dashboard): remove unused prepareDashboardForUpdate and stripWidgetServerFields

These functions are only needed for widget update operations (add/edit/delete),
which are not part of the core dashboard commands (list, view, create).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: betegon

src/types/dashboard.ts

@@ -504,84 +504,3 @@ export function assignDefaultLayout(
   // No gap found — place below everything
   return { ...widget, layout: { x: 0, y: maxY, w, h, minH } };
 }
-
-// ---------------------------------------------------------------------------
-// Server field stripping utilities
-// ---------------------------------------------------------------------------
-
-/**
- * Server-generated fields on widget queries that must be stripped before PUT.
- * NEVER strip user-controlled fields like conditions, columns, aggregates.
- */
-const QUERY_SERVER_FIELDS = ["id", "widgetId", "dateCreated"] as const;
-
-/**
- * Server-generated fields on widgets that must be stripped before PUT.
- * CRITICAL: Never strip widgetType, displayType, or layout — these are
- * user-controlled and stripping them causes widgets to reset to defaults.
- */
-const WIDGET_SERVER_FIELDS = ["id", "dashboardId", "dateCreated"] as const;
-
-/**
- * Server-generated fields on widget layout that must be stripped before PUT.
- */
-const LAYOUT_SERVER_FIELDS = ["isResizable"] as const;
-
-/**
- * Strip server-generated fields from a single widget for PUT requests.
- *
- * @param widget - Widget object from GET response
- * @returns Widget safe for PUT (widgetType, displayType, layout preserved)
- */
-export function stripWidgetServerFields(
-  widget: DashboardWidget
-): DashboardWidget {
-  const cleaned = { ...widget };
-
-  // Strip widget-level server fields
-  for (const field of WIDGET_SERVER_FIELDS) {
-    delete (cleaned as Record<string, unknown>)[field];
-  }
-
-  // Strip query-level server fields
-  if (cleaned.queries) {
-    cleaned.queries = cleaned.queries.map((q) => {
-      const cleanedQuery = { ...q };
-      for (const field of QUERY_SERVER_FIELDS) {
-        delete (cleanedQuery as Record<string, unknown>)[field];
-      }
-      return cleanedQuery;
-    });
-  }
-
-  // Strip layout server fields
-  if (cleaned.layout) {
-    const cleanedLayout = { ...cleaned.layout };
-    for (const field of LAYOUT_SERVER_FIELDS) {
-      delete (cleanedLayout as Record<string, unknown>)[field];
-    }
-    cleaned.layout = cleanedLayout;
-  }
-
-  return cleaned;
-}
-
-/**
- * Prepare a full dashboard for PUT update.
- * Strips server-generated fields from all widgets while preserving
- * widgetType, displayType, and layout.
- *
- * @param dashboard - Dashboard detail from GET response
- * @returns Object with title and cleaned widgets, ready for PUT body
- */
-export function prepareDashboardForUpdate(dashboard: DashboardDetail): {
-  title: string;
-  widgets: DashboardWidget[];
-  projects?: number[];
-} {
-  return {
-    title: dashboard.title,
-    widgets: (dashboard.widgets ?? []).map(stripWidgetServerFields),
-    projects: dashboard.projects,
-  };
-}

test/types/dashboard.test.ts

@@ -23,7 +23,6 @@ import {
   prepareWidgetQueries,
   SPAN_AGGREGATE_FUNCTIONS,
   SpanAggregateFunctionSchema,
-  stripWidgetServerFields,
   WIDGET_TYPES,
   type WidgetType,
 } from "../../src/types/dashboard.js";
@@ -600,74 +599,3 @@ describe("assignDefaultLayout", () => {
     expect(result.layout!.y).toBe(0);
   });
 });
-
-// ---------------------------------------------------------------------------
-// stripWidgetServerFields
-// ---------------------------------------------------------------------------
-
-describe("stripWidgetServerFields", () => {
-  test("strips id, dashboardId, dateCreated from widget", () => {
-    const widget: DashboardWidget = {
-      id: "100",
-      dashboardId: "42",
-      dateCreated: "2026-01-01T00:00:00Z",
-      title: "Test",
-      displayType: "line",
-      widgetType: "spans",
-    };
-    const result = stripWidgetServerFields(widget);
-    expect(result).not.toHaveProperty("id");
-    expect(result).not.toHaveProperty("dashboardId");
-    expect(result).not.toHaveProperty("dateCreated");
-    expect(result.title).toBe("Test");
-    expect(result.displayType).toBe("line");
-    expect(result.widgetType).toBe("spans");
-  });
-
-  test("strips server fields from queries", () => {
-    const widget: DashboardWidget = {
-      title: "Test",
-      displayType: "line",
-      queries: [
-        {
-          id: "q1",
-          widgetId: "w1",
-          dateCreated: "2026-01-01T00:00:00Z",
-          aggregates: ["count()"],
-          conditions: "",
-          name: "Query 1",
-        },
-      ],
-    };
-    const result = stripWidgetServerFields(widget);
-    const query = result.queries![0]!;
-    expect(query).not.toHaveProperty("id");
-    expect(query).not.toHaveProperty("widgetId");
-    expect(query).not.toHaveProperty("dateCreated");
-    expect(query.aggregates).toEqual(["count()"]);
-    expect(query.name).toBe("Query 1");
-  });
-
-  test("preserves user-facing fields", () => {
-    const widget: DashboardWidget = {
-      title: "My Widget",
-      displayType: "table",
-      widgetType: "spans",
-      layout: { x: 0, y: 0, w: 6, h: 2 },
-      queries: [
-        {
-          aggregates: ["count()"],
-          columns: ["browser.name"],
-          conditions: "is:unresolved",
-          name: "",
-        },
-      ],
-    };
-    const result = stripWidgetServerFields(widget);
-    expect(result.title).toBe("My Widget");
-    expect(result.displayType).toBe("table");
-    expect(result.widgetType).toBe("spans");
-    expect(result.layout).toBeDefined();
-    expect(result.queries![0]!.conditions).toBe("is:unresolved");
-  });
-});