refactor: move handleSeerCommandError to shared utils

Move the error handling helper from plan.ts to utils.ts so both
explain.ts and plan.ts use the same function. This ensures outcome
classification stays consistent if the logic is updated.

Author: BYK

src/commands/issue/explain.ts

@@ -6,21 +6,18 @@
 
 import type { SentryContext } from "../../context.js";
 import { buildCommand } from "../../lib/command.js";
-import { ApiError } from "../../lib/errors.js";
 import { CommandOutput } from "../../lib/formatters/output.js";
-import {
-  formatRootCauseList,
-  handleSeerApiError,
-} from "../../lib/formatters/seer.js";
+import { formatRootCauseList } from "../../lib/formatters/seer.js";
 import {
   applyFreshFlag,
   FRESH_ALIASES,
   FRESH_FLAG,
 } from "../../lib/list-command.js";
-import { classifySeerError, recordSeerOutcome } from "../../lib/telemetry.js";
+import { recordSeerOutcome } from "../../lib/telemetry.js";
 import { extractRootCauses } from "../../types/seer.js";
 import {
   ensureRootCauseAnalysis,
+  handleSeerCommandError,
   issueIdPositional,
   resolveOrgAndIssueId,
 } from "./utils.js";
@@ -113,22 +110,7 @@ export const explainCommand = buildCommand({
       recordSeerOutcome("success");
       return { hint: `To create a plan, run: sentry issue plan ${issueArg}` };
     } catch (error) {
-      if (!recorded) {
-        // Handle API errors with friendly messages
-        if (error instanceof ApiError) {
-          const mapped = handleSeerApiError(
-            error.status,
-            error.detail,
-            resolvedOrg
-          );
-          recordSeerOutcome(classifySeerError(mapped));
-          throw mapped;
-        }
-        recordSeerOutcome(classifySeerError(error));
-      } else if (error instanceof ApiError) {
-        throw handleSeerApiError(error.status, error.detail, resolvedOrg);
-      }
-      throw error;
+      handleSeerCommandError(error, recorded, resolvedOrg);
     }
   },
 });

src/commands/issue/plan.ts

@@ -8,19 +8,16 @@
 import type { SentryContext } from "../../context.js";
 import { triggerSolutionPlanning } from "../../lib/api-client.js";
 import { buildCommand, numberParser } from "../../lib/command.js";
-import { ApiError, ValidationError } from "../../lib/errors.js";
+import { ValidationError } from "../../lib/errors.js";
 import { CommandOutput } from "../../lib/formatters/output.js";
-import {
-  formatSolution,
-  handleSeerApiError,
-} from "../../lib/formatters/seer.js";
+import { formatSolution } from "../../lib/formatters/seer.js";
 import {
   applyFreshFlag,
   FRESH_ALIASES,
   FRESH_FLAG,
 } from "../../lib/list-command.js";
 import { logger } from "../../lib/logger.js";
-import { classifySeerError, recordSeerOutcome } from "../../lib/telemetry.js";
+import { recordSeerOutcome } from "../../lib/telemetry.js";
 import {
   type AutofixState,
   extractRootCauses,
@@ -30,6 +27,7 @@ import {
 } from "../../types/seer.js";
 import {
   ensureRootCauseAnalysis,
+  handleSeerCommandError,
   issueIdPositional,
   pollAutofixState,
   resolveOrgAndIssueId,
@@ -126,40 +124,6 @@ function buildPlanData(state: AutofixState): PlanData {
   };
 }
 
-/**
- * Handle errors in Seer commands with outcome recording.
- *
- * Records the Seer outcome if not already recorded, maps API errors to
- * Seer-specific errors, and re-throws. Extracted from the catch block to
- * keep command function complexity under the Biome limit.
- *
- * @param error - The caught error
- * @param recorded - Whether outcome was already recorded before the error
- * @param resolvedOrg - Org slug for Seer error messages
- * @returns never — always throws
- */
-function handleSeerCommandError(
-  error: unknown,
-  recorded: boolean,
-  resolvedOrg: string | undefined
-): never {
-  if (!recorded) {
-    if (error instanceof ApiError) {
-      const mapped = handleSeerApiError(
-        error.status,
-        error.detail,
-        resolvedOrg
-      );
-      recordSeerOutcome(classifySeerError(mapped));
-      throw mapped;
-    }
-    recordSeerOutcome(classifySeerError(error));
-  } else if (error instanceof ApiError) {
-    throw handleSeerApiError(error.status, error.detail, resolvedOrg);
-  }
-  throw error;
-}
-
 export const planCommand = buildCommand({
   docs: {
     brief: "Generate a solution plan using Seer AI",

src/commands/issue/utils.ts

@@ -29,7 +29,10 @@ import {
   ResolutionError,
   withAuthGuard,
 } from "../../lib/errors.js";
-import { getProgressMessage } from "../../lib/formatters/seer.js";
+import {
+  getProgressMessage,
+  handleSeerApiError,
+} from "../../lib/formatters/seer.js";
 import { expandToFullShortId, isShortSuffix } from "../../lib/issue-id.js";
 import { logger } from "../../lib/logger.js";
 import { poll } from "../../lib/polling.js";
@@ -41,7 +44,11 @@ import {
 } from "../../lib/resolve-target.js";
 import { parseSentryUrl } from "../../lib/sentry-url-parser.js";
 import { buildIssueUrl } from "../../lib/sentry-urls.js";
-import { setOrgProjectContext } from "../../lib/telemetry.js";
+import {
+  classifySeerError,
+  recordSeerOutcome,
+  setOrgProjectContext,
+} from "../../lib/telemetry.js";
 import { isAllDigits } from "../../lib/utils.js";
 import type { SentryIssue } from "../../types/index.js";
 import { type AutofixState, isTerminalStatus } from "../../types/seer.js";
@@ -807,3 +814,37 @@ export async function pollAutofixState(
     initialMessage: "Waiting for analysis to start...",
   });
 }
+
+/**
+ * Handle errors in Seer commands with outcome recording.
+ *
+ * Records the Seer outcome if not already recorded, maps API errors to
+ * Seer-specific errors, and re-throws. Shared between explain and plan
+ * commands to keep outcome classification consistent.
+ *
+ * @param error - The caught error
+ * @param recorded - Whether outcome was already recorded before the error
+ * @param resolvedOrg - Org slug for Seer error messages
+ * @returns never — always throws
+ */
+export function handleSeerCommandError(
+  error: unknown,
+  recorded: boolean,
+  resolvedOrg: string | undefined
+): never {
+  if (!recorded) {
+    if (error instanceof ApiError) {
+      const mapped = handleSeerApiError(
+        error.status,
+        error.detail,
+        resolvedOrg
+      );
+      recordSeerOutcome(classifySeerError(mapped));
+      throw mapped;
+    }
+    recordSeerOutcome(classifySeerError(error));
+  } else if (error instanceof ApiError) {
+    throw handleSeerApiError(error.status, error.detail, resolvedOrg);
+  }
+  throw error;
+}