refactor(log-list): address review feedback (#329)

- Add comment explaining ms → ns conversion (timestamp_precise)
- Replace .then()/.catch() with async/await IIFE in executeFollowMode
- DRY fetchInitial/fetchPoll into single fetch(statsPeriod, afterTimestamp?) callback

Author: BYK

AGENTS.md

@@ -659,9 +659,6 @@ mock.module("./some-module", () => ({
 <!-- lore:019c9a88-bf99-7322-b192-aafe4636c600 -->
 * **getsentry/codecov-action enables JUnit XML test reporting by default**: The \`getsentry/codecov-action@main\` has \`enable-tests: true\` by default, which searches for JUnit XML files matching \`\*\*/\*.junit.xml\`. If the test framework doesn't produce JUnit XML, the action emits 3 warnings on every CI run: "No files found matching pattern", "No JUnit XML files found", and "Please ensure your test framework is generating JUnit XML output". Fix: either set \`enable-tests: false\` in the action inputs, or configure the test runner to output JUnit XML. For Bun, add \`\[test.reporter] junit = "test-results.junit.xml"\` to \`bunfig.toml\` and add \`\*.junit.xml\` to \`.gitignore\`.
 
-<!-- lore:019cb3e6-da66-7534-a573-30d2ecadfd53 -->
-* **Returning bare promises loses async function from error stack traces**: When an \`async\` function returns another promise without \`await\`, the calling function disappears from error stack traces if the inner promise rejects. A function that drops \`async\` and does \`return someAsyncCall()\` loses its frame entirely. Fix: keep the function \`async\` and use \`return await someAsyncCall()\`. This matters for debugging — the intermediate function name in the stack trace helps locate which code path triggered the failure. ESLint rule \`no-return-await\` is outdated; modern engines optimize \`return await\` in async functions.
-
 ### Pattern
 
 <!-- lore:dbd63348-2049-42b3-bb99-d6a3d64369c7 -->
@@ -680,7 +677,7 @@ mock.module("./some-module", () => ({
 * **PR review workflow: reply, resolve, amend, force-push**: PR review workflow: (1) Read unresolved threads via GraphQL, (2) make code changes, (3) run lint+typecheck+tests, (4) create a SEPARATE commit per review round (not amend) for incremental review, (5) push normally, (6) reply to comments via REST API, (7) resolve threads via GraphQL \`resolveReviewThread\`. Only amend+force-push when user explicitly asks or pre-commit hook modified files.
 
 <!-- lore:019cb858-e780-7945-a0ee-a01f85be5585 -->
-* **Testing infinite loops (while-true) in streaming functions via AuthError escape hatch**: Follow-mode streaming in \`sentry log list\` uses \`setTimeout\`-based recursive scheduling. \`scheduleNextPoll()\` sets a timer; SIGINT handler calls \`clearTimeout()\` + \`resolve()\`. No \`process.exit(0)\` needed — clearing the timer drains the event loop naturally. \`Bun.sleep()\` cannot be cancelled (no AbortSignal support), so \`setTimeout\`/\`clearTimeout\` is required for cancellable delays. Tests use \`interceptSigint()\` helper that captures \`process.once('SIGINT', handler)\` via spy, then \`trigger()\` invokes it directly. Poll tests use \`Bun.sleep(1200)\` to wait for the real 1-second timer. \`executeFollowMode\<T>(config: FollowConfig\<T>)\` is generic — parameterized by \`fetchInitial\`, \`fetchPoll\`, \`extractNew\` callbacks for both project-scoped and trace-scoped streaming.
+* **Testing infinite loops (while-true) in streaming functions via AuthError escape hatch**: Follow-mode streaming in \`sentry log list\` uses \`setTimeout\`-based recursive scheduling. \`scheduleNextPoll()\` sets a timer; SIGINT handler calls \`clearTimeout()\` + \`resolve()\`. No \`process.exit(0)\` needed — clearing the timer drains the event loop naturally. A \`stopped\` boolean guard prevents orphaned poll loops when SIGINT fires during an in-flight fetch (e.g., \`fetchInitial\`). Both \`scheduleNextPoll()\` and \`poll()\` check \`stopped\` before doing work. \`Bun.sleep()\` cannot be cancelled (no AbortSignal support), so \`setTimeout\`/\`clearTimeout\` is required. Tests use \`interceptSigint()\` helper that captures \`process.once('SIGINT', handler)\` via spy, then \`trigger()\` invokes it directly. Poll tests use \`Bun.sleep(1200)\` to wait for the real 1-second timer. \`executeFollowMode\<T>(config: FollowConfig\<T>)\` is generic — parameterized by \`fetchInitial\`, \`fetchPoll\`, \`extractNew\` callbacks.
 
 ### Preference
 

src/commands/log/list.ts

@@ -184,10 +184,13 @@ type FollowConfig<T extends LogLike> = {
   bannerText: string;
   /** Whether to show the trace-ID column in table output */
   includeTrace: boolean;
-  /** Fetch the initial batch of logs */
-  fetchInitial: () => Promise<T[]>;
-  /** Fetch new logs after the given nanosecond timestamp */
-  fetchPoll: (lastTimestamp: number) => Promise<T[]>;
+  /**
+   * Fetch logs with the given time window.
+   * @param statsPeriod - Time window (e.g., "1m" for initial, "10m" for polls)
+   * @param afterTimestamp - Only return logs newer than this (nanoseconds).
+   *   Standard mode passes this for server-side dedup; trace mode ignores it.
+   */
+  fetch: (statsPeriod: string, afterTimestamp?: number) => Promise<T[]>;
   /** Extract only the genuinely new entries from a poll response */
   extractNew: (logs: T[], lastTimestamp: number) => T[];
 };
@@ -221,6 +224,7 @@ function executeFollowMode<T extends LogLike>(
   const table = plain ? undefined : createLogStreamingTable();
 
   let headerPrinted = false;
+  // timestamp_precise is nanoseconds; Date.now() is milliseconds → convert
   let lastTimestamp = Date.now() * 1_000_000;
   let pendingTimer: ReturnType<typeof setTimeout> | null = null;
   let stopped = false;
@@ -272,7 +276,7 @@ function executeFollowMode<T extends LogLike>(
         return;
       }
       try {
-        const rawLogs = await config.fetchPoll(lastTimestamp);
+        const rawLogs = await config.fetch("10m", lastTimestamp);
         const newLogs = config.extractNew(rawLogs, lastTimestamp);
         writeNewLogs(newLogs);
         scheduleNextPoll();
@@ -289,9 +293,9 @@ function executeFollowMode<T extends LogLike>(
       }
     }
 
-    config
-      .fetchInitial()
-      .then((initialLogs) => {
+    (async () => {
+      try {
+        const initialLogs = await config.fetch("1m");
         if (!flags.json && initialLogs.length > 0) {
           stdout.write(table ? table.header() : formatLogsHeader());
           headerPrinted = true;
@@ -308,11 +312,11 @@ function executeFollowMode<T extends LogLike>(
           lastTimestamp = initialLogs[0].timestamp_precise;
         }
         scheduleNextPoll();
-      })
-      .catch((error: unknown) => {
+      } catch (error) {
         process.removeListener("SIGINT", stop);
         reject(error);
-      });
+      }
+    })();
   });
 }
 
@@ -460,17 +464,11 @@ export const listCommand = buildListCommand("log", {
           flags,
           bannerText: `Streaming logs for trace ${traceId}...`,
           includeTrace: false,
-          fetchInitial: () =>
-            listTraceLogs(org, traceId, {
-              query: flags.query,
-              limit: flags.limit,
-              statsPeriod: "1m",
-            }),
-          fetchPoll: () =>
+          fetch: (statsPeriod) =>
             listTraceLogs(org, traceId, {
               query: flags.query,
               limit: flags.limit,
-              statsPeriod: "10m",
+              statsPeriod,
             }),
           extractNew: (logs, lastTs) =>
             logs.filter((l) => l.timestamp_precise > lastTs),
@@ -494,18 +492,12 @@ export const listCommand = buildListCommand("log", {
           flags,
           bannerText: "Streaming logs...",
           includeTrace: true,
-          fetchInitial: () =>
-            listLogs(org, project, {
-              query: flags.query,
-              limit: flags.limit,
-              statsPeriod: "1m",
-            }),
-          fetchPoll: (lastTs) =>
+          fetch: (statsPeriod, afterTimestamp) =>
             listLogs(org, project, {
               query: flags.query,
               limit: flags.limit,
-              statsPeriod: "10m",
-              afterTimestamp: lastTs,
+              statsPeriod,
+              afterTimestamp,
             }),
           extractNew: (logs) => logs,
         });