fix(test): save/restore SENTRY_CONFIG_DIR to prevent cross-file test pollution

Three test files (version-check, install-info, project-cache) were
deleting process.env.SENTRY_CONFIG_DIR in afterEach without saving
the original value set by preload.ts. When Bun's test runner shares
a process across files, this poisons the env for subsequent tests
that capture the var at module load time.

Author: BYK

test/lib/db/install-info.test.ts

@@ -12,15 +12,21 @@ import {
 import { cleanupTestDir, createTestConfigDir } from "../../helpers.js";
 
 let testConfigDir: string;
+let savedConfigDir: string | undefined;
 
 beforeEach(async () => {
+  savedConfigDir = process.env.SENTRY_CONFIG_DIR;
   testConfigDir = await createTestConfigDir("test-install-info-");
   process.env.SENTRY_CONFIG_DIR = testConfigDir;
 });
 
 afterEach(async () => {
   closeDatabase();
-  delete process.env.SENTRY_CONFIG_DIR;
+  if (savedConfigDir !== undefined) {
+    process.env.SENTRY_CONFIG_DIR = savedConfigDir;
+  } else {
+    delete process.env.SENTRY_CONFIG_DIR;
+  }
   await cleanupTestDir(testConfigDir);
 });
 

test/lib/db/project-cache.test.ts

@@ -16,16 +16,22 @@ import {
 import { cleanupTestDir, createTestConfigDir } from "../../helpers.js";
 
 let testConfigDir: string;
+let savedConfigDir: string | undefined;
 
 beforeEach(async () => {
+  savedConfigDir = process.env.SENTRY_CONFIG_DIR;
   testConfigDir = await createTestConfigDir("test-project-cache-");
   process.env.SENTRY_CONFIG_DIR = testConfigDir;
 });
 
 afterEach(async () => {
   // Close database to release file handles before cleanup
   closeDatabase();
-  delete process.env.SENTRY_CONFIG_DIR;
+  if (savedConfigDir !== undefined) {
+    process.env.SENTRY_CONFIG_DIR = savedConfigDir;
+  } else {
+    delete process.env.SENTRY_CONFIG_DIR;
+  }
   await cleanupTestDir(testConfigDir);
 });
 

test/lib/version-check.test.ts

@@ -47,9 +47,11 @@ describe("shouldSuppressNotification", () => {
 
 describe("getUpdateNotification", () => {
   let testConfigDir: string;
+  let savedConfigDir: string | undefined;
   let savedNoUpdateCheck: string | undefined;
 
   beforeEach(async () => {
+    savedConfigDir = process.env.SENTRY_CONFIG_DIR;
     testConfigDir = await createTestConfigDir("test-version-notif-");
     process.env.SENTRY_CONFIG_DIR = testConfigDir;
     // Save and clear the env var to test real implementation
@@ -58,7 +60,11 @@ describe("getUpdateNotification", () => {
   });
 
   afterEach(async () => {
-    delete process.env.SENTRY_CONFIG_DIR;
+    if (savedConfigDir !== undefined) {
+      process.env.SENTRY_CONFIG_DIR = savedConfigDir;
+    } else {
+      delete process.env.SENTRY_CONFIG_DIR;
+    }
     // Restore the env var
     if (savedNoUpdateCheck !== undefined) {
       process.env.SENTRY_CLI_NO_UPDATE_CHECK = savedNoUpdateCheck;
@@ -116,9 +122,11 @@ describe("abortPendingVersionCheck", () => {
 
 describe("maybeCheckForUpdateInBackground", () => {
   let testConfigDir: string;
+  let savedConfigDir: string | undefined;
   let savedNoUpdateCheck: string | undefined;
 
   beforeEach(async () => {
+    savedConfigDir = process.env.SENTRY_CONFIG_DIR;
     testConfigDir = await createTestConfigDir("test-version-bg-");
     process.env.SENTRY_CONFIG_DIR = testConfigDir;
     // Save and clear the env var to test real implementation
@@ -129,7 +137,11 @@ describe("maybeCheckForUpdateInBackground", () => {
   afterEach(async () => {
     // Abort any pending check to clean up
     abortPendingVersionCheck();
-    delete process.env.SENTRY_CONFIG_DIR;
+    if (savedConfigDir !== undefined) {
+      process.env.SENTRY_CONFIG_DIR = savedConfigDir;
+    } else {
+      delete process.env.SENTRY_CONFIG_DIR;
+    }
     // Restore the env var
     if (savedNoUpdateCheck !== undefined) {
       process.env.SENTRY_CLI_NO_UPDATE_CHECK = savedNoUpdateCheck;