Skip to content

Commit b590472

Browse files
authored
ci(coverage): use informational-patch input instead of sed hack (#544)
Follow-up to #541. Replaces the `sed`-based `codecov.yml` patching with the new `informational-patch` action input from getsentry/codecov-action (merged in getsentry/codecov-action#54). ### Changes - **`ci.yml`**: Remove the `sed` step, add `informational-patch: ${{ github.event_name == 'push' }}` to the codecov action - **`codecov.yml`**: Remove the `patch.default.informational` section (no longer needed) ### Behavior (unchanged) | Context | `codecov/project` | `codecov/patch` | |---------|-------------------|-----------------| | PR | informational | **blocking** | | `main` / `release/**` push | informational | informational |
1 parent 838ccaa commit b590472

File tree

2 files changed

+1
-7
lines changed

2 files changed

+1
-7
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -179,15 +179,12 @@ jobs:
179179
run: bun run test:isolated --coverage --coverage-reporter=lcov --coverage-dir=coverage-isolated
180180
- name: Merge Coverage Reports
181181
run: bun run script/merge-lcov.ts coverage/lcov.info coverage-isolated/lcov.info > coverage/merged.lcov
182-
- name: Make coverage checks informational on release branches
183-
if: github.event_name == 'push'
184-
run: |
185-
sed -i 's/informational: false/informational: true/' codecov.yml
186182
- name: Coverage Report
187183
uses: getsentry/codecov-action@main
188184
with:
189185
token: ${{ secrets.GITHUB_TOKEN }}
190186
files: ./coverage/merged.lcov
187+
informational-patch: ${{ github.event_name == 'push' }}
191188

192189
build-binary:
193190
name: Build Binary (${{ matrix.target }})

codecov.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,3 @@ coverage:
66
project:
77
default:
88
informational: true
9-
patch:
10-
default:
11-
informational: false

0 commit comments

Comments
 (0)