refactor(dashboard): cleanup widget commands to match codebase patterns

- Extract shared buildWidgetFromFlags() into resolve.ts (DRY create + add)
- Add return { hint } with dashboard URL to all dashboard commands
- Move enum validation before API calls in widget add (fail fast)
- Use proper DashboardDetail/DashboardWidget types in widget formatters
- Wrap getDashboard in withProgress for loading spinner in view command

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: betegon

src/commands/dashboard/create.ts

@@ -27,11 +27,8 @@ import {
   type DashboardDetail,
   type DashboardWidget,
   DISPLAY_TYPES,
-  parseAggregate,
-  parseSortExpression,
-  parseWidgetInput,
-  prepareWidgetQueries,
 } from "../../types/dashboard.js";
+import { buildWidgetFromFlags } from "./resolve.js";
 
 type CreateFlags = {
   readonly "widget-title"?: string;
@@ -158,30 +155,16 @@ function buildInlineWidget(flags: CreateFlags): DashboardWidget {
     );
   }
 
-  const aggregates = (flags["widget-query"] ?? ["count"]).map(parseAggregate);
-  const columns = flags["widget-group-by"] ?? [];
-  const orderby = flags["widget-sort"]
-    ? parseSortExpression(flags["widget-sort"])
-    : undefined;
-
-  const rawWidget = {
+  return buildWidgetFromFlags({
     title: flags["widget-title"],
-    displayType: flags["widget-display"] as string,
-    ...(flags["widget-dataset"] && { widgetType: flags["widget-dataset"] }),
-    queries: [
-      {
-        aggregates,
-        columns,
-        conditions: flags["widget-where"] ?? "",
-        ...(orderby && { orderby }),
-        name: "",
-      },
-    ],
-    ...(flags["widget-limit"] !== undefined && {
-      limit: flags["widget-limit"],
-    }),
-  };
-  return prepareWidgetQueries(parseWidgetInput(rawWidget));
+    display: flags["widget-display"] as string,
+    dataset: flags["widget-dataset"],
+    query: flags["widget-query"],
+    where: flags["widget-where"],
+    groupBy: flags["widget-group-by"],
+    sort: flags["widget-sort"],
+    limit: flags["widget-limit"],
+  });
 }
 
 export const createCommand = buildCommand({
@@ -290,5 +273,6 @@ export const createCommand = buildCommand({
     const url = buildDashboardUrl(orgSlug, dashboard.id);
 
     yield new CommandOutput({ ...dashboard, url } as CreateResult);
+    return { hint: `Dashboard: ${url}` };
   },
 });

src/commands/dashboard/resolve.ts

@@ -13,6 +13,10 @@ import { isAllDigits } from "../../lib/utils.js";
 import {
   type DashboardWidget,
   DISPLAY_TYPES,
+  parseAggregate,
+  parseSortExpression,
+  parseWidgetInput,
+  prepareWidgetQueries,
   WIDGET_TYPES,
 } from "../../types/dashboard.js";
 
@@ -157,6 +161,47 @@ export function resolveWidgetIndex(
   return matchIndex;
 }
 
+/**
+ * Build a widget from user-provided flag values.
+ *
+ * Shared between `dashboard create --widget-*` and `dashboard widget add`.
+ * Parses aggregate shorthand, sort expressions, and validates via Zod schema.
+ *
+ * @param opts - Widget configuration from parsed flags
+ * @returns Validated widget with computed query fields
+ */
+export function buildWidgetFromFlags(opts: {
+  title: string;
+  display: string;
+  dataset?: string;
+  query?: string[];
+  where?: string;
+  groupBy?: string[];
+  sort?: string;
+  limit?: number;
+}): DashboardWidget {
+  const aggregates = (opts.query ?? ["count"]).map(parseAggregate);
+  const columns = opts.groupBy ?? [];
+  const orderby = opts.sort ? parseSortExpression(opts.sort) : undefined;
+
+  const raw = {
+    title: opts.title,
+    displayType: opts.display,
+    ...(opts.dataset && { widgetType: opts.dataset }),
+    queries: [
+      {
+        aggregates,
+        columns,
+        conditions: opts.where ?? "",
+        ...(orderby && { orderby }),
+        name: "",
+      },
+    ],
+    ...(opts.limit !== undefined && { limit: opts.limit }),
+  };
+  return prepareWidgetQueries(parseWidgetInput(raw));
+}
+
 /**
  * Validate --display and --dataset flag values against known enums.
  *

src/commands/dashboard/view.ts

@@ -16,6 +16,7 @@ import {
   FRESH_ALIASES,
   FRESH_FLAG,
 } from "../../lib/list-command.js";
+import { withProgress } from "../../lib/polling.js";
 import { buildDashboardUrl } from "../../lib/sentry-urls.js";
 import type { DashboardDetail } from "../../types/dashboard.js";
 import {
@@ -87,8 +88,12 @@ export const viewCommand = buildCommand({
       return;
     }
 
-    const dashboard = await getDashboard(orgSlug, dashboardId);
+    const dashboard = await withProgress(
+      { message: "Fetching dashboard..." },
+      () => getDashboard(orgSlug, dashboardId)
+    );
 
     yield new CommandOutput({ ...dashboard, url } as ViewResult);
+    return { hint: `Dashboard: ${url}` };
   },
 });

src/commands/dashboard/widget/add.ts

@@ -16,13 +16,10 @@ import {
   assignDefaultLayout,
   type DashboardDetail,
   type DashboardWidget,
-  parseAggregate,
-  parseSortExpression,
-  parseWidgetInput,
   prepareDashboardForUpdate,
-  prepareWidgetQueries,
 } from "../../../types/dashboard.js";
 import {
+  buildWidgetFromFlags,
   parseDashboardPositionalArgs,
   resolveDashboardId,
   resolveOrgFromTarget,
@@ -160,6 +157,10 @@ export const addCommand = buildCommand({
     const { cwd } = this;
 
     const { dashboardArgs, title } = parseAddPositionalArgs(args);
+
+    // Validate enums before any network calls (fail fast)
+    validateWidgetEnums(flags.display, flags.dataset);
+
     const { dashboardRef, targetArg } =
       parseDashboardPositionalArgs(dashboardArgs);
     const parsed = parseOrgProjectArg(targetArg);
@@ -170,28 +171,16 @@ export const addCommand = buildCommand({
     );
     const dashboardId = await resolveDashboardId(orgSlug, dashboardRef);
 
-    validateWidgetEnums(flags.display, flags.dataset);
-
-    const aggregates = (flags.query ?? ["count"]).map(parseAggregate);
-    const columns = flags["group-by"] ?? [];
-    const orderby = flags.sort ? parseSortExpression(flags.sort) : undefined;
-
-    const raw = {
+    let newWidget = buildWidgetFromFlags({
       title,
-      displayType: flags.display,
-      ...(flags.dataset && { widgetType: flags.dataset }),
-      queries: [
-        {
-          aggregates,
-          columns,
-          conditions: flags.where ?? "",
-          ...(orderby && { orderby }),
-          name: "",
-        },
-      ],
-      ...(flags.limit !== undefined && { limit: flags.limit }),
-    };
-    let newWidget = prepareWidgetQueries(parseWidgetInput(raw));
+      display: flags.display,
+      dataset: flags.dataset,
+      query: flags.query,
+      where: flags.where,
+      groupBy: flags["group-by"],
+      sort: flags.sort,
+      limit: flags.limit,
+    });
 
     // GET current dashboard → append widget with auto-layout → PUT
     const current = await getDashboard(orgSlug, dashboardId);
@@ -207,5 +196,6 @@ export const addCommand = buildCommand({
       widget: newWidget,
       url,
     } as AddResult);
+    return { hint: `Dashboard: ${url}` };
   },
 });

src/commands/dashboard/widget/delete.ts

@@ -111,5 +111,6 @@ export const deleteCommand = buildCommand({
       widgetTitle,
       url,
     } as DeleteResult);
+    return { hint: `Dashboard: ${url}` };
   },
 });

src/commands/dashboard/widget/edit.ts

@@ -240,5 +240,6 @@ export const editCommand = buildCommand({
       widget: replacement,
       url,
     } as EditResult);
+    return { hint: `Dashboard: ${url}` };
   },
 });

src/lib/formatters/human.ts

@@ -10,6 +10,10 @@
 // biome-ignore lint/performance/noNamespaceImport: Sentry SDK recommends namespace import
 import * as Sentry from "@sentry/bun";
 import prettyMs from "pretty-ms";
+import type {
+  DashboardDetail,
+  DashboardWidget,
+} from "../../types/dashboard.js";
 import type {
   BreadcrumbsEntry,
   ExceptionEntry,
@@ -2168,8 +2172,8 @@ export function formatDashboardView(result: {
  * Format a widget add result for human-readable output.
  */
 export function formatWidgetAdded(result: {
-  dashboard: { id: string; widgets?: unknown[] };
-  widget: { title: string };
+  dashboard: DashboardDetail;
+  widget: DashboardWidget;
   url: string;
 }): string {
   const widgetCount = result.dashboard.widgets?.length ?? 0;
@@ -2185,7 +2189,7 @@ export function formatWidgetAdded(result: {
  * Format a widget deletion result for human-readable output.
  */
 export function formatWidgetDeleted(result: {
-  dashboard: { id: string; widgets?: unknown[] };
+  dashboard: DashboardDetail;
   widgetTitle: string;
   url: string;
 }): string {
@@ -2202,8 +2206,8 @@ export function formatWidgetDeleted(result: {
  * Format a widget edit result for human-readable output.
  */
 export function formatWidgetEdited(result: {
-  dashboard: { id: string };
-  widget: { title: string };
+  dashboard: DashboardDetail;
+  widget: DashboardWidget;
   url: string;
 }): string {
   const lines: string[] = [