fix(telemetry): derive environment from CLI_VERSION instead of NODE_ENV

The getEnv() migration in v0.21.0 broke esbuild define replacement for
process.env.NODE_ENV — all production builds since then report
environment: "development" instead of "production", making telemetry
invisible on production-filtered dashboards.

Derive the environment from CLI_VERSION (correctly injected at build
time) instead: "0.0.0-dev" → development, "-dev.<ts>" → nightly,
"X.Y.Z" → production.

Author: BYK

src/lib/constants.ts

@@ -60,6 +60,28 @@ export function getConfiguredSentryUrl(): string | undefined {
 export const CLI_VERSION =
   typeof SENTRY_CLI_VERSION !== "undefined" ? SENTRY_CLI_VERSION : "0.0.0-dev";
 
+/**
+ * Derive the telemetry environment from the build-injected version string.
+ *
+ * - `"0.0.0-dev"` (no build injection) → `"development"`
+ * - `"X.Y.Z-dev.<timestamp>"` (nightly CI build) → `"nightly"`
+ * - `"X.Y.Z"` (stable release) → `"production"`
+ *
+ * This replaces the previous `process.env.NODE_ENV` approach which broke
+ * when the `getEnv()` indirection was introduced — esbuild's `define` can
+ * only replace literal `process.env.NODE_ENV`, not dynamic property accesses
+ * like `getEnv().NODE_ENV`.
+ */
+export function getCliEnvironment(): string {
+  if (CLI_VERSION === "0.0.0-dev") {
+    return "development";
+  }
+  if (CLI_VERSION.includes("-dev.")) {
+    return "nightly";
+  }
+  return "production";
+}
+
 /**
  * Generate the User-Agent string for API requests.
  * Format: sentry-cli/<version> (<os>-<arch>) <runtime>/<version>

src/lib/telemetry.ts

@@ -14,6 +14,7 @@ import { chmodSync, statSync } from "node:fs";
 import * as Sentry from "@sentry/node-core/light";
 import {
   CLI_VERSION,
+  getCliEnvironment,
   getConfiguredSentryUrl,
   SENTRY_CLI_DSN,
 } from "./constants.js";
@@ -354,7 +355,7 @@ export function initSentry(
   options?: { libraryMode?: boolean }
 ): Sentry.LightNodeClient | undefined {
   const libraryMode = options?.libraryMode ?? false;
-  const environment = getEnv().NODE_ENV ?? "development";
+  const environment = getCliEnvironment();
 
   // Close the previous client to clean up its internal timers and beforeExit
   // handlers (client report flusher interval, log flush listener). Without

test/lib/constants.test.ts

@@ -9,6 +9,7 @@
 
 import { afterEach, beforeEach, describe, expect, test } from "bun:test";
 import {
+  getCliEnvironment,
   getConfiguredSentryUrl,
   normalizeUrl,
 } from "../../src/lib/constants.js";
@@ -82,6 +83,40 @@ describe("normalizeUrl", () => {
   });
 });
 
+describe("getCliEnvironment", () => {
+  test("returns 'development' in dev mode (SENTRY_CLI_VERSION not injected)", () => {
+    // In test/dev mode, CLI_VERSION is "0.0.0-dev" because the build-time
+    // constant SENTRY_CLI_VERSION is never defined.
+    expect(getCliEnvironment()).toBe("development");
+  });
+
+  test("derivation logic: stable versions → 'production'", () => {
+    // Verify the logic that would run in production builds by checking
+    // the conditions directly against known version formats.
+    const stableVersions = ["0.20.0", "1.0.0", "0.23.0", "2.5.1"];
+    for (const v of stableVersions) {
+      expect(v === "0.0.0-dev").toBe(false);
+      expect(v.includes("-dev.")).toBe(false);
+      // Both conditions false → would return "production"
+    }
+  });
+
+  test("derivation logic: nightly versions contain '-dev.'", () => {
+    const nightlyVersions = ["0.24.0-dev.1740000000", "1.0.0-dev.1700000000"];
+    for (const v of nightlyVersions) {
+      expect(v === "0.0.0-dev").toBe(false);
+      expect(v.includes("-dev.")).toBe(true);
+      // First condition false, second true → would return "nightly"
+    }
+  });
+
+  test("derivation logic: dev fallback is exactly '0.0.0-dev'", () => {
+    const v = "0.0.0-dev";
+    expect(v === "0.0.0-dev").toBe(true);
+    // First condition true → would return "development"
+  });
+});
+
 describe("getConfiguredSentryUrl", () => {
   let originalHost: string | undefined;
   let originalUrl: string | undefined;