chore(tests): remove redundant and low-value tests

Remove ~500 lines of test bloat:

Deleted files (fully redundant or zero-value):
- test/lib/utils.test.ts: tested trivial one-liner regex wrapper
- test/lib/seer-trial.property.test.ts: fake property tests using
  constantFrom over 3 fixed values; always returns false in test env
- test/lib/errors.property.test.ts: fully redundant with existing
  withAuthGuard tests in errors.test.ts
- test/lib/logger.property.test.ts: fully redundant with existing
  parseLogLevel/setLogLevel tests in logger.test.ts
- test/lib/db/schema-migration-v8.test.ts: snapshot-in-time migration
  test that will break on schema v9; already covered by schema.test.ts

Trimmed files:
- test/lib/list-command.test.ts: removed 5 describe blocks testing
  Stricli constant shapes (kind, default, optional) that TypeScript
  already validates at compile time
- test/lib/hex-id.test.ts: removed HEX_ID_RE and UUID_DASH_RE unit
  tests that are subsumed by property tests in the same file
- test/lib/platforms.test.ts: removed fragile VALID_PLATFORMS.length
  count assertion that breaks on every platform addition

Author: BYK

AGENTS.md

@@ -3,16 +3,17 @@
  *
  * Property-based and unit tests for the shared hex ID validation
  * in src/lib/hex-id.ts.
+ *
+ * Regex patterns (HEX_ID_RE, UUID_DASH_RE) are covered by the property tests
+ * at the bottom of this file which generate random valid/invalid hex strings.
+ * The unit tests here focus on `validateHexId` behavior: error messages,
+ * whitespace handling, UUID normalization, and edge cases.
  */
 
 import { describe, expect, test } from "bun:test";
 import { array, constantFrom, assert as fcAssert, property } from "fast-check";
 import { ValidationError } from "../../src/lib/errors.js";
-import {
-  HEX_ID_RE,
-  UUID_DASH_RE,
-  validateHexId,
-} from "../../src/lib/hex-id.js";
+import { validateHexId } from "../../src/lib/hex-id.js";
 import { DEFAULT_NUM_RUNS } from "../model-based/helpers.js";
 
 const HEX_CHARS = "0123456789abcdefABCDEF".split("");
@@ -24,97 +25,6 @@ const validIdArb = array(constantFrom(...HEX_CHARS), {
   maxLength: 32,
 }).map((chars) => chars.join(""));
 
-describe("HEX_ID_RE", () => {
-  test("matches a valid 32-char lowercase hex string", () => {
-    expect(HEX_ID_RE.test("aaaa1111bbbb2222cccc3333dddd4444")).toBe(true);
-  });
-
-  test("matches a valid 32-char uppercase hex string", () => {
-    expect(HEX_ID_RE.test("AAAA1111BBBB2222CCCC3333DDDD4444")).toBe(true);
-  });
-
-  test("matches mixed-case hex", () => {
-    expect(HEX_ID_RE.test("AaAa1111BbBb2222CcCc3333DdDd4444")).toBe(true);
-  });
-
-  test("rejects shorter strings", () => {
-    expect(HEX_ID_RE.test("abc123")).toBe(false);
-  });
-
-  test("rejects longer strings", () => {
-    expect(HEX_ID_RE.test(`${VALID_ID}extra`)).toBe(false);
-  });
-
-  test("rejects non-hex characters", () => {
-    expect(HEX_ID_RE.test("gggg1111bbbb2222cccc3333dddd4444")).toBe(false);
-  });
-
-  test("rejects empty string", () => {
-    expect(HEX_ID_RE.test("")).toBe(false);
-  });
-
-  test("rejects strings with whitespace", () => {
-    expect(HEX_ID_RE.test(" aaaa1111bbbb2222cccc3333dddd4444")).toBe(false);
-    expect(HEX_ID_RE.test("aaaa1111bbbb2222cccc3333dddd4444 ")).toBe(false);
-  });
-
-  test("rejects strings with newlines", () => {
-    expect(HEX_ID_RE.test("aaaa1111bbbb2222cccc3333dddd4444\n")).toBe(false);
-  });
-});
-
-describe("UUID_DASH_RE", () => {
-  test("matches a valid UUID with dashes (lowercase)", () => {
-    expect(UUID_DASH_RE.test("aaaa1111-bbbb-2222-cccc-3333dddd4444")).toBe(
-      true
-    );
-  });
-
-  test("matches a valid UUID with dashes (uppercase)", () => {
-    expect(UUID_DASH_RE.test("AAAA1111-BBBB-2222-CCCC-3333DDDD4444")).toBe(
-      true
-    );
-  });
-
-  test("matches mixed-case UUID", () => {
-    expect(UUID_DASH_RE.test("AaAa1111-BbBb-2222-CcCc-3333DdDd4444")).toBe(
-      true
-    );
-  });
-
-  test("rejects plain 32-char hex (no dashes)", () => {
-    expect(UUID_DASH_RE.test("aaaa1111bbbb2222cccc3333dddd4444")).toBe(false);
-  });
-
-  test("rejects dashes in wrong positions", () => {
-    expect(UUID_DASH_RE.test("aaaa-1111bbbb-2222cccc-3333dddd-444444444")).toBe(
-      false
-    );
-  });
-
-  test("rejects too few hex chars between dashes", () => {
-    expect(UUID_DASH_RE.test("aaa-1111-bbbb-2222-cccc3333dddd4444")).toBe(
-      false
-    );
-  });
-
-  test("rejects empty string", () => {
-    expect(UUID_DASH_RE.test("")).toBe(false);
-  });
-
-  test("rejects non-hex chars in UUID format", () => {
-    expect(UUID_DASH_RE.test("gggg1111-bbbb-2222-cccc-3333dddd4444")).toBe(
-      false
-    );
-  });
-
-  test("matches real user input from CLI-7Z", () => {
-    expect(UUID_DASH_RE.test("ed29abc8-71c4-475b-9675-4655ef1a02d0")).toBe(
-      true
-    );
-  });
-});
-
 describe("validateHexId", () => {
   test("returns the ID for valid input", () => {
     expect(validateHexId(VALID_ID, "test ID")).toBe(VALID_ID);

test/lib/db/schema-migration-v8.test.ts

@@ -1,95 +1,20 @@
 /**
  * Tests for the shared list-command building blocks.
  *
- * Verifies that the shared flag/parameter constants have the correct shape
- * and that `buildOrgListCommand` produces a working command that delegates
+ * Tests `parseCursorFlag` validation and `buildOrgListCommand` delegation
  * to `dispatchOrgScopedList`.
  */
 
 import { afterEach, describe, expect, mock, spyOn, test } from "bun:test";
 import {
-  buildListLimitFlag,
   buildOrgListCommand,
-  LIST_BASE_ALIASES,
-  LIST_CURSOR_FLAG,
-  LIST_JSON_FLAG,
-  LIST_TARGET_POSITIONAL,
   type OrgListCommandDocs,
   parseCursorFlag,
 } from "../../src/lib/list-command.js";
 import type { OrgListConfig } from "../../src/lib/org-list.js";
 // biome-ignore lint/performance/noNamespaceImport: needed for spyOn mocking
 import * as orgListModule from "../../src/lib/org-list.js";
 
-// ---------------------------------------------------------------------------
-// Shared constants: shape / value assertions
-// ---------------------------------------------------------------------------
-
-describe("LIST_TARGET_POSITIONAL", () => {
-  test("is a tuple with one optional string parameter", () => {
-    expect(LIST_TARGET_POSITIONAL.kind).toBe("tuple");
-    expect(LIST_TARGET_POSITIONAL.parameters).toHaveLength(1);
-    const param = LIST_TARGET_POSITIONAL.parameters[0];
-    expect(param.placeholder).toBe("org/project");
-    expect(param.optional).toBe(true);
-    expect(param.parse).toBe(String);
-  });
-});
-
-describe("LIST_JSON_FLAG", () => {
-  test("is a boolean flag defaulting to false", () => {
-    expect(LIST_JSON_FLAG.kind).toBe("boolean");
-    expect(LIST_JSON_FLAG.default).toBe(false);
-  });
-});
-
-describe("LIST_CURSOR_FLAG", () => {
-  test("is an optional parsed flag with cursor validation", () => {
-    expect(LIST_CURSOR_FLAG.kind).toBe("parsed");
-    expect(LIST_CURSOR_FLAG.optional).toBe(true);
-    expect(LIST_CURSOR_FLAG.parse("last")).toBe("last");
-    expect(LIST_CURSOR_FLAG.parse("1735689600:0:0")).toBe("1735689600:0:0");
-    expect(() => LIST_CURSOR_FLAG.parse("12345")).toThrow("not a valid cursor");
-    expect(LIST_CURSOR_FLAG.brief).toContain('"last"');
-  });
-});
-
-describe("buildListLimitFlag", () => {
-  test("uses provided entity plural in brief", () => {
-    const flag = buildListLimitFlag("widgets");
-    expect(flag.brief).toContain("widgets");
-    expect(flag.kind).toBe("parsed");
-  });
-
-  test("defaults to '30' when no default provided", () => {
-    const flag = buildListLimitFlag("teams");
-    expect(flag.default).toBe("30");
-  });
-
-  test("uses provided default value", () => {
-    const flag = buildListLimitFlag("issues", "10");
-    expect(flag.default).toBe("10");
-  });
-});
-
-describe("LIST_BASE_ALIASES", () => {
-  test("maps n to limit and c to cursor", () => {
-    expect(LIST_BASE_ALIASES.n).toBe("limit");
-    expect(LIST_BASE_ALIASES.c).toBe("cursor");
-  });
-
-  test("can be spread with additional aliases", () => {
-    const extended = { ...LIST_BASE_ALIASES, p: "platform" };
-    expect(extended.n).toBe("limit");
-    expect(extended.c).toBe("cursor");
-    expect(extended.p).toBe("platform");
-  });
-});
-
-// ---------------------------------------------------------------------------
-// parseCursorFlag: shared cursor validation
-// ---------------------------------------------------------------------------
-
 describe("parseCursorFlag", () => {
   test("passes through 'last' keyword", () => {
     expect(parseCursorFlag("last")).toBe("last");