refactor(trace-id): extract shared validation, add unit tests (#329)

- Create src/lib/trace-id.ts with shared TRACE_ID_RE and validateTraceId()
- Update trace/logs.ts and log/list.ts to use shared module
- Remove duplicated regex, validation function, and ValidationError import
- Add test/lib/trace-id.test.ts with property-based and unit tests (20 tests)
- Add test/commands/log/list.test.ts covering standard and trace modes (20 tests)
- Generic error message (no command-specific example) in shared validator

Author: BYK

AGENTS.md

@@ -11,12 +11,7 @@ import * as Sentry from "@sentry/bun";
 import type { SentryContext } from "../../context.js";
 import { listLogs, listTraceLogs } from "../../lib/api-client.js";
 import { validateLimit } from "../../lib/arg-parsing.js";
-import {
-  AuthError,
-  ContextError,
-  stringifyUnknown,
-  ValidationError,
-} from "../../lib/errors.js";
+import { AuthError, ContextError, stringifyUnknown } from "../../lib/errors.js";
 import {
   buildLogRowCells,
   createLogStreamingTable,
@@ -36,6 +31,7 @@ import {
   resolveOrg,
   resolveOrgProjectFromArg,
 } from "../../lib/resolve-target.js";
+import { validateTraceId } from "../../lib/trace-id.js";
 import { getUpdateNotification } from "../../lib/version-check.js";
 import type { Writer } from "../../types/index.js";
 
@@ -62,24 +58,6 @@ const DEFAULT_POLL_INTERVAL = 2;
 /** Command name used in resolver error messages */
 const COMMAND_NAME = "log list";
 
-/** Regex for a valid 32-character hexadecimal trace ID */
-const TRACE_ID_RE = /^[0-9a-f]{32}$/i;
-
-/**
- * Validate that a string looks like a 32-character hex trace ID.
- *
- * @throws {ValidationError} If the trace ID format is invalid
- */
-function validateTraceId(traceId: string): string {
-  if (!TRACE_ID_RE.test(traceId)) {
-    throw new ValidationError(
-      `Invalid trace ID "${traceId}". Expected a 32-character hexadecimal string.\n\n` +
-        "Example: sentry log list --trace abc123def456abc123def456abc123de"
-    );
-  }
-  return traceId;
-}
-
 /**
  * Parse --limit flag, delegating range validation to shared utility.
  */

src/commands/log/list.ts

@@ -9,14 +9,15 @@ import { listTraceLogs } from "../../lib/api-client.js";
 import { validateLimit } from "../../lib/arg-parsing.js";
 import { openInBrowser } from "../../lib/browser.js";
 import { buildCommand } from "../../lib/command.js";
-import { ContextError, ValidationError } from "../../lib/errors.js";
+import { ContextError } from "../../lib/errors.js";
 import {
   formatLogTable,
   writeFooter,
   writeJson,
 } from "../../lib/formatters/index.js";
 import { resolveOrg } from "../../lib/resolve-target.js";
 import { buildTraceUrl } from "../../lib/sentry-urls.js";
+import { validateTraceId } from "../../lib/trace-id.js";
 
 type LogsFlags = {
   readonly json: boolean;
@@ -45,30 +46,13 @@ const DEFAULT_PERIOD = "14d";
 /** Usage hint shown in error messages */
 const USAGE_HINT = "sentry trace logs [<org>] <trace-id>";
 
-/** Regex for a valid 32-character hexadecimal trace ID */
-const TRACE_ID_RE = /^[0-9a-f]{32}$/i;
-
 /**
  * Parse --limit flag, delegating range validation to shared utility.
  */
 function parseLimit(value: string): number {
   return validateLimit(value, MIN_LIMIT, MAX_LIMIT);
 }
 
-/**
- * Validate that a string looks like a 32-character hex trace ID.
- *
- * @throws {ValidationError} If the trace ID format is invalid
- */
-function validateTraceId(traceId: string): void {
-  if (!TRACE_ID_RE.test(traceId)) {
-    throw new ValidationError(
-      `Invalid trace ID "${traceId}". Expected a 32-character hexadecimal string.\n\n` +
-        "Example: sentry trace logs abc123def456abc123def456abc123de"
-    );
-  }
-}
-
 /**
  * Parse positional arguments for trace logs.
  *

src/commands/trace/logs.ts

@@ -0,0 +1,31 @@
+/**
+ * Shared Trace ID Validation
+ *
+ * Provides trace ID regex and validation used by both `trace logs` and
+ * `log list --trace` commands.
+ */
+
+import { ValidationError } from "./errors.js";
+
+/** Regex for a valid 32-character hexadecimal trace ID */
+export const TRACE_ID_RE = /^[0-9a-f]{32}$/i;
+
+/**
+ * Validate that a string looks like a 32-character hex trace ID.
+ *
+ * Returns the validated trace ID so it can be used as a Stricli `parse`
+ * function directly.
+ *
+ * @param traceId - The trace ID string to validate
+ * @returns The validated trace ID (unchanged)
+ * @throws {ValidationError} If the trace ID format is invalid
+ */
+export function validateTraceId(traceId: string): string {
+  if (!TRACE_ID_RE.test(traceId)) {
+    throw new ValidationError(
+      `Invalid trace ID "${traceId}". Expected a 32-character hexadecimal string.\n\n` +
+        "Example: abc123def456abc123def456abc123de"
+    );
+  }
+  return traceId;
+}