fix(args): address BugBot review issues in URL parsing

- Event URLs no longer trigger OrgAll → ContextError; instead they
  auto-detect org/project after SENTRY_URL is set (HIGH)
- SaaS URLs now clear stale SENTRY_URL so API calls use default
  routing instead of a leftover self-hosted value (MEDIUM)
- Non-issue URLs (traces, project settings) in parseIssueArg now
  throw ValidationError instead of falling through to garbage
  slash-based parsing (LOW)

Author: BYK

src/commands/event/view.ts

@@ -99,8 +99,10 @@ export function parsePositionalArgs(args: string[]): {
   if (urlParsed) {
     applySentryUrlContext(urlParsed.baseUrl);
     if (urlParsed.eventId) {
-      // Event URL: use org as target, eventId from the URL
-      return { eventId: urlParsed.eventId, targetArg: `${urlParsed.org}/` };
+      // Event URL: eventId from the URL, auto-detect org/project.
+      // SENTRY_URL is already set for self-hosted; org/project will be
+      // resolved via DSN detection or cached defaults.
+      return { eventId: urlParsed.eventId, targetArg: undefined };
     }
     // URL recognized but no eventId — not valid for event view
     throw new ContextError(

src/lib/arg-parsing.ts

@@ -6,6 +6,7 @@
  * project list) and single-item commands (issue view, explain, plan).
  */
 
+import { ValidationError } from "./errors.js";
 import type { ParsedSentryUrl } from "./sentry-url-parser.js";
 import { applySentryUrlContext, parseSentryUrl } from "./sentry-url-parser.js";
 import { isAllDigits } from "./utils.js";
@@ -353,8 +354,11 @@ export function parseIssueArg(arg: string): ParsedIssueArg {
     if (result) {
       return result;
     }
-    // URL recognized but no issue ID — fall through to normal parsing
-    // (shouldn't happen for issue commands, but defensive)
+    // URL recognized but no issue ID (e.g., trace or project settings URL)
+    throw new ValidationError(
+      "This Sentry URL does not contain an issue ID. Use an issue URL like:\n" +
+        "  https://sentry.io/organizations/{org}/issues/{id}/"
+    );
   }
 
   // 1. Pure numeric → direct fetch by ID

src/lib/sentry-url-parser.ts

@@ -131,6 +131,9 @@ export function parseSentryUrl(input: string): ParsedSentryUrl | null {
  */
 export function applySentryUrlContext(baseUrl: string): void {
   if (isSentrySaasUrl(baseUrl)) {
+    // Clear any self-hosted URL so API calls fall back to default SaaS routing.
+    // Without this, a stale SENTRY_URL would route SaaS requests to the wrong host.
+    process.env.SENTRY_URL = undefined;
     return;
   }
   process.env.SENTRY_URL = baseUrl;

test/commands/event/view.test.ts

@@ -107,20 +107,21 @@ describe("parsePositionalArgs", () => {
       }
     });
 
-    test("event URL extracts eventId and org as target", () => {
+    test("event URL extracts eventId, auto-detects org/project", () => {
       const result = parsePositionalArgs([
         "https://sentry.io/organizations/my-org/issues/32886/events/abc123def456/",
       ]);
       expect(result.eventId).toBe("abc123def456");
-      expect(result.targetArg).toBe("my-org/");
+      expect(result.targetArg).toBeUndefined();
     });
 
-    test("self-hosted event URL extracts eventId and org", () => {
+    test("self-hosted event URL extracts eventId, sets SENTRY_URL", () => {
       const result = parsePositionalArgs([
         "https://sentry.example.com/organizations/acme/issues/999/events/deadbeef/",
       ]);
       expect(result.eventId).toBe("deadbeef");
-      expect(result.targetArg).toBe("acme/");
+      expect(result.targetArg).toBeUndefined();
+      expect(process.env.SENTRY_URL).toBe("https://sentry.example.com");
     });
 
     test("issue URL without event ID throws ContextError", () => {

test/lib/arg-parsing.test.ts

@@ -11,6 +11,7 @@ import {
   parseIssueArg,
   parseOrgProjectArg,
 } from "../../src/lib/arg-parsing.js";
+import { ValidationError } from "../../src/lib/errors.js";
 
 describe("parseOrgProjectArg", () => {
   // Representative examples for documentation (invariants covered by property tests)
@@ -229,6 +230,38 @@ describe("parseIssueArg", () => {
         numericId: "32886",
       });
     });
+
+    test("trace URL throws ValidationError (no issue ID in URL)", () => {
+      expect(() =>
+        parseIssueArg(
+          "https://sentry.io/organizations/my-org/traces/a4d1aae7216b47ff/"
+        )
+      ).toThrow(ValidationError);
+    });
+
+    test("org-only URL throws ValidationError (no issue ID in URL)", () => {
+      expect(() =>
+        parseIssueArg("https://sentry.io/organizations/my-org/")
+      ).toThrow(ValidationError);
+    });
+
+    test("project settings URL throws ValidationError (no issue ID in URL)", () => {
+      expect(() =>
+        parseIssueArg("https://sentry.io/settings/my-org/projects/backend/")
+      ).toThrow(ValidationError);
+    });
+
+    test("non-issue URL error mentions issue URL format", () => {
+      try {
+        parseIssueArg("https://sentry.io/organizations/my-org/traces/abc/");
+        expect.unreachable("Should have thrown");
+      } catch (error) {
+        expect(error).toBeInstanceOf(ValidationError);
+        expect((error as ValidationError).message).toContain(
+          "does not contain an issue ID"
+        );
+      }
+    });
   });
 
   // Edge cases - document tricky behaviors

test/lib/sentry-url-parser.test.ts

@@ -271,4 +271,16 @@ describe("applySentryUrlContext", () => {
     applySentryUrlContext("https://sentry.acme.internal:9000");
     expect(process.env.SENTRY_URL).toBe("https://sentry.acme.internal:9000");
   });
+
+  test("clears existing SENTRY_URL when SaaS URL is detected", () => {
+    process.env.SENTRY_URL = "https://sentry.example.com";
+    applySentryUrlContext("https://sentry.io");
+    expect(process.env.SENTRY_URL).toBeUndefined();
+  });
+
+  test("clears existing SENTRY_URL when SaaS subdomain is detected", () => {
+    process.env.SENTRY_URL = "https://sentry.example.com";
+    applySentryUrlContext("https://us.sentry.io");
+    expect(process.env.SENTRY_URL).toBeUndefined();
+  });
 });