fix: address review comments — case normalization, nightly versionExists, install script, cleanup

- resolveChannelAndVersion: normalize positional to lowercase so 'Nightly'
  and 'STABLE' are treated as channel selectors (Seer MEDIUM)
- resolveTargetVersion: use GitHub (curl) for versionExists lookup when
  channel is nightly, since nightly builds are not published to npm (Seer HIGH)
- migrateToStandaloneForNightly: remove redundant setInstallInfo call — the
  child 'setup --install' process already records install info (BugBot LOW)
- install script: print 'Downloading sentry nightly...' instead of
  'Downloading sentry vnightly...' when version is 'nightly' (BugBot LOW)
- install script: update stale comment about nightly version string

Author: BYK

install

@@ -84,9 +84,8 @@ fi
 # Resolve version and download tag.
 #
 # "nightly" is a special value that installs from the rolling nightly prerelease
-# built from the main branch. In this case:
-#   - `version`      holds the human-readable version string (e.g. "0.12.0-dev.1740393600")
-#   - `download_tag` holds the GitHub release tag to download from ("nightly")
+# built from the main branch. In this case both `version` and `download_tag`
+# are set to the literal string "nightly".
 #
 # For stable releases both are the same version string (e.g. "0.5.0").
 channel="stable"
@@ -122,7 +121,13 @@ tmp_binary="${tmpdir}/sentry-install-$$${suffix}"
 # Clean up temp binary on failure (setup handles cleanup on success)
 trap 'rm -f "$tmp_binary"' EXIT
 
-echo -e "${MUTED}Downloading sentry v${version}...${NC}"
+# For nightly the version string is literally "nightly", not a semver, so
+# skip the "v" prefix that's only meaningful for numbered releases.
+if [[ "$version" == "nightly" ]]; then
+  echo -e "${MUTED}Downloading sentry nightly...${NC}"
+else
+  echo -e "${MUTED}Downloading sentry v${version}...${NC}"
+fi
 
 # Try gzip-compressed download first (~60% smaller, ~37 MB vs ~99 MB).
 # gunzip is POSIX and available on all Unix systems.

src/commands/cli/upgrade.ts

@@ -20,7 +20,6 @@ import type { SentryContext } from "../../context.js";
 import { determineInstallDir, releaseLock } from "../../lib/binary.js";
 import { buildCommand } from "../../lib/command.js";
 import { CLI_VERSION } from "../../lib/constants.js";
-import { setInstallInfo } from "../../lib/db/install-info.js";
 import {
   getReleaseChannel,
   type ReleaseChannel,
@@ -61,10 +60,11 @@ function resolveChannelAndVersion(positional: string | undefined): {
   versionArg: string | undefined;
 } {
   // "nightly" and "stable" as positional args select the channel rather than
-  // installing a specific version.
-  if (positional === "nightly" || positional === "stable") {
+  // installing a specific version. Match case-insensitively for convenience.
+  const lower = positional?.toLowerCase();
+  if (lower === "nightly" || lower === "stable") {
     return {
-      channel: positional,
+      channel: lower,
       versionArg: undefined,
     };
   }
@@ -113,9 +113,12 @@ async function resolveTargetVersion(
     return null;
   }
 
-  // Validate that a specific pinned version actually exists on GitHub/npm
+  // Validate that a specific pinned version actually exists.
+  // Nightly builds are GitHub-only, so always use curl (GitHub) lookup for
+  // nightly channel regardless of the current install method.
   if (versionArg && !CHANNEL_VERSIONS.has(versionArg)) {
-    const exists = await versionExists(method, target);
+    const lookupMethod = channel === "nightly" ? "curl" : method;
+    const exists = await versionExists(lookupMethod, target);
     if (!exists) {
       throw new UpgradeError(
         "version_not_found",
@@ -255,15 +258,9 @@ async function migrateToStandaloneForNightly(
     releaseLock(downloadResult.lockPath);
   }
 
-  // Update install info to reflect the new standalone method
-  const binaryFilename = process.platform === "win32" ? "sentry.exe" : "sentry";
-  setInstallInfo({
-    method: "curl",
-    path: `${installDir}/${binaryFilename}`,
-    version: target,
-  });
-
   // Warn about the potentially shadowing old installation
+  // Note: install info is already recorded by the child `setup --install`
+  // process, so no redundant setInstallInfo call is needed here.
   const uninstallHints: Record<string, string> = {
     npm: "npm uninstall -g sentry",
     pnpm: "pnpm remove -g sentry",