chore(tests): consolidate unit tests subsumed by property tests

Remove ~620 lines of unit tests that duplicate invariants already
covered by companion property-based tests. Each unit test file now
has a header comment documenting which invariants are in the property
file and what remains in the unit file.

Files trimmed:
- test/lib/dsn.test.ts: Remove extractOrgIdFromHost, parseDsn (basic),
  isValidDsn, createDsnFingerprint (ordering/dedup), createDetectedDsn
  (basic) — all covered by dsn.property.test.ts. Keep: self-hosted DSN
  fingerprints, trailing slash edge case, path segments, packagePath.
- test/lib/promises.test.ts: Remove basic true/false/error tests —
  covered by promises.property.test.ts. Keep: concurrency timing tests,
  single-resolution guarantee.
- test/lib/bspatch.test.ts: Remove offtin unit tests and parsePatchHeader
  rejection tests — covered by bspatch.property.test.ts. Keep: fixture-
  based patch application, SHA-256 verification, truncated patch.
- test/lib/db/auth.test.ts: Remove priority, source tracking, refresh
  skip, isEnvTokenActive basics — covered by auth.property.test.ts.
  Keep: whitespace edge cases, isAuthenticated, getActiveEnvVarName,
  shape assertions.
- test/lib/formatters/json.test.ts: Remove filterFields basics and
  parseFieldsList dedup/whitespace — covered by json.property.test.ts.
  Keep: dot-notation edge cases, null/undefined in objects, writeJson,
  writeJsonList, formatJson APIs.
- test/lib/formatters/trace.test.ts: Remove redundant newline/contains
  checks — covered by trace.property.test.ts. Keep: specific format
  values, rendered vs plain mode, computeTraceSummary edge cases.

Author: BYK

test/lib/bspatch.test.ts

@@ -1,6 +1,10 @@
 /**
  * Unit Tests for TRDIFF10 Binary Patch Application
  *
+ * Note: Core invariants (offtin sign/magnitude, parsePatchHeader rejection rules)
+ * are tested via property-based tests in bspatch.property.test.ts. These tests
+ * focus on real fixture-based patch application and error messages.
+ *
  * Tests the bspatch implementation against real TRDIFF10 patches
  * generated by zig-bsdiff v0.1.19 (stored as test fixtures).
  */
@@ -9,87 +13,11 @@ import { describe, expect, test } from "bun:test";
 import { unlinkSync } from "node:fs";
 import { tmpdir } from "node:os";
 import { join } from "node:path";
-import { applyPatch, offtin, parsePatchHeader } from "../../src/lib/bspatch.js";
+import { applyPatch, parsePatchHeader } from "../../src/lib/bspatch.js";
 
 const FIXTURES_DIR = join(import.meta.dir, "../fixtures/patches");
 
-describe("offtin", () => {
-  test("reads zero", () => {
-    const buf = new Uint8Array(8);
-    expect(offtin(buf, 0)).toBe(0);
-  });
-
-  test("reads positive value 1", () => {
-    const buf = new Uint8Array(8);
-    buf[0] = 1; // LE: least significant byte
-    expect(offtin(buf, 0)).toBe(1);
-  });
-
-  test("reads positive value 256", () => {
-    const buf = new Uint8Array(8);
-    buf[1] = 1; // 256 in LE
-    expect(offtin(buf, 0)).toBe(256);
-  });
-
-  test("reads negative value -1", () => {
-    // zig-bsdiff sign-magnitude: magnitude=1, sign bit set in byte 7
-    const buf = new Uint8Array(8);
-    buf[0] = 1;
-    buf[7] = 0x80; // Sign bit
-    expect(offtin(buf, 0)).toBe(-1);
-  });
-
-  test("reads negative value -256", () => {
-    const buf = new Uint8Array(8);
-    buf[1] = 1; // magnitude = 256
-    buf[7] = 0x80;
-    expect(offtin(buf, 0)).toBe(-256);
-  });
-
-  test("reads from offset", () => {
-    const buf = new Uint8Array(16);
-    buf[8] = 42;
-    expect(offtin(buf, 8)).toBe(42);
-  });
-
-  test("reads large positive value", () => {
-    const buf = new Uint8Array(8);
-    // 0x01_00_00_00 = 16,777,216 in LE: byte 3 = 0x01
-    buf[3] = 1;
-    expect(offtin(buf, 0)).toBe(16_777_216);
-  });
-
-  test("reads value spanning both 32-bit halves", () => {
-    const buf = new Uint8Array(8);
-    // Low 32 bits: 0
-    // High 32 bits: 1 → value = 1 * 2^32 = 4,294,967,296
-    buf[4] = 1;
-    expect(offtin(buf, 0)).toBe(4_294_967_296);
-  });
-});
-
-describe("parsePatchHeader", () => {
-  test("rejects too-small buffer", () => {
-    expect(() => parsePatchHeader(new Uint8Array(31))).toThrow(
-      "Patch too small"
-    );
-  });
-
-  test("rejects invalid magic", () => {
-    const buf = new Uint8Array(32);
-    buf.set(new TextEncoder().encode("BSDIFF40"));
-    expect(() => parsePatchHeader(buf)).toThrow("Invalid patch format");
-  });
-
-  test("rejects negative header values", () => {
-    const buf = new Uint8Array(32);
-    buf.set(new TextEncoder().encode("TRDIFF10"));
-    // Set controlLen to -1 (sign bit in byte 15)
-    buf[8] = 1;
-    buf[15] = 0x80;
-    expect(() => parsePatchHeader(buf)).toThrow("negative length");
-  });
-
+describe("parsePatchHeader: fixtures", () => {
   test("parses valid small fixture header", async () => {
     const patchData = new Uint8Array(
       await Bun.file(join(FIXTURES_DIR, "small.trdiff10")).arrayBuffer()
@@ -109,6 +37,13 @@ describe("parsePatchHeader", () => {
     expect(header.diffLen).toBeGreaterThanOrEqual(0);
     expect(header.newSize).toBe(65_536);
   });
+
+  test("rejects truncated patch (header claims more data than exists)", () => {
+    const truncated = new Uint8Array(32);
+    truncated.set(new TextEncoder().encode("TRDIFF10"));
+    truncated[8] = 100; // controlLen = 100
+    expect(() => parsePatchHeader(truncated)).toThrow("exceed file size");
+  });
 });
 
 describe("applyPatch", () => {
@@ -126,14 +61,12 @@ describe("applyPatch", () => {
     try {
       const sha256 = await applyPatch(oldPath, patchData, destPath);
 
-      // Verify output matches expected new file
       const expected = await Bun.file(
         join(FIXTURES_DIR, "small-new.bin")
       ).arrayBuffer();
       const actual = await Bun.file(destPath).arrayBuffer();
       expect(new Uint8Array(actual)).toEqual(new Uint8Array(expected));
 
-      // Verify SHA-256 matches
       const expectedHash = new Bun.CryptoHasher("sha256")
         .update(new Uint8Array(expected))
         .digest("hex");
@@ -185,7 +118,6 @@ describe("applyPatch", () => {
 
     try {
       const sha256 = await applyPatch(oldPath, patchData, destPath);
-      // Known SHA-256 of "Hello, World! This is the new file content. Version 2."
       expect(sha256).toMatch(/^[0-9a-f]{64}$/);
       expect(sha256.length).toBe(64);
     } finally {
@@ -197,15 +129,6 @@ describe("applyPatch", () => {
     }
   });
 
-  test("rejects truncated patch (header claims more data than exists)", () => {
-    // Header says controlLen=100 but patch is only 32 bytes
-    const truncated = new Uint8Array(32);
-    truncated.set(new TextEncoder().encode("TRDIFF10"));
-    truncated[8] = 100; // controlLen = 100
-
-    expect(() => parsePatchHeader(truncated)).toThrow("exceed file size");
-  });
-
   test("rejects non-TRDIFF10 magic", async () => {
     const oldPath = join(FIXTURES_DIR, "small-old.bin");
     const buf = new Uint8Array(64);

test/lib/db/auth.test.ts

@@ -1,13 +1,14 @@
 /**
  * Auth Environment Variable Tests
  *
- * Tests for SENTRY_AUTH_TOKEN and SENTRY_TOKEN env var support.
- * Verifies priority, source tracking, and interaction with stored tokens.
+ * Note: Core invariants (priority, source tracking, refresh skip, isEnvTokenActive)
+ * are tested via property-based tests in auth.property.test.ts. These tests focus on
+ * edge cases (whitespace, empty strings), shape assertions, and functions not covered
+ * by property tests (isAuthenticated, getActiveEnvVarName).
  */
 
 import { afterEach, beforeEach, describe, expect, test } from "bun:test";
 import {
-  type AuthSource,
   getActiveEnvVarName,
   getAuthConfig,
   getAuthToken,
@@ -20,7 +21,6 @@ import { useTestConfigDir } from "../../helpers.js";
 
 useTestConfigDir("auth-env-");
 
-/** Save and restore env vars around each test */
 let savedAuthToken: string | undefined;
 let savedSentryToken: string | undefined;
 
@@ -32,7 +32,6 @@ beforeEach(() => {
 });
 
 afterEach(() => {
-  // Restore — never leave env vars dangling
   if (savedAuthToken !== undefined) {
     process.env.SENTRY_AUTH_TOKEN = savedAuthToken;
   } else {
@@ -45,34 +44,7 @@ afterEach(() => {
   }
 });
 
-describe("env var auth: getAuthToken", () => {
-  test("returns SENTRY_AUTH_TOKEN when set", () => {
-    process.env.SENTRY_AUTH_TOKEN = "sntrys_token_abc";
-    expect(getAuthToken()).toBe("sntrys_token_abc");
-  });
-
-  test("returns SENTRY_TOKEN when set", () => {
-    process.env.SENTRY_TOKEN = "sntrys_token_xyz";
-    expect(getAuthToken()).toBe("sntrys_token_xyz");
-  });
-
-  test("SENTRY_AUTH_TOKEN takes priority over SENTRY_TOKEN", () => {
-    process.env.SENTRY_AUTH_TOKEN = "auth_token";
-    process.env.SENTRY_TOKEN = "sentry_token";
-    expect(getAuthToken()).toBe("auth_token");
-  });
-
-  test("env var takes priority over stored token", () => {
-    setAuthToken("stored_token");
-    process.env.SENTRY_AUTH_TOKEN = "env_token";
-    expect(getAuthToken()).toBe("env_token");
-  });
-
-  test("falls back to stored token when no env var", () => {
-    setAuthToken("stored_token");
-    expect(getAuthToken()).toBe("stored_token");
-  });
-
+describe("env var auth: getAuthToken edge cases", () => {
   test("ignores empty SENTRY_AUTH_TOKEN", () => {
     process.env.SENTRY_AUTH_TOKEN = "";
     setAuthToken("stored_token");
@@ -91,30 +63,7 @@ describe("env var auth: getAuthToken", () => {
   });
 });
 
-describe("env var auth: getAuthConfig", () => {
-  test("returns env source for SENTRY_AUTH_TOKEN", () => {
-    process.env.SENTRY_AUTH_TOKEN = "test_token";
-    const config = getAuthConfig();
-    expect(config).toBeDefined();
-    expect(config?.token).toBe("test_token");
-    expect(config?.source).toBe("env:SENTRY_AUTH_TOKEN" satisfies AuthSource);
-  });
-
-  test("returns env source for SENTRY_TOKEN", () => {
-    process.env.SENTRY_TOKEN = "test_token";
-    const config = getAuthConfig();
-    expect(config).toBeDefined();
-    expect(config?.token).toBe("test_token");
-    expect(config?.source).toBe("env:SENTRY_TOKEN" satisfies AuthSource);
-  });
-
-  test("returns oauth source for stored token", () => {
-    setAuthToken("stored_token");
-    const config = getAuthConfig();
-    expect(config).toBeDefined();
-    expect(config?.source).toBe("oauth" satisfies AuthSource);
-  });
-
+describe("env var auth: getAuthConfig shape", () => {
   test("env config has no refreshToken or expiry", () => {
     process.env.SENTRY_AUTH_TOKEN = "test_token";
     const config = getAuthConfig();
@@ -135,21 +84,7 @@ describe("env var auth: isAuthenticated", () => {
   });
 });
 
-describe("env var auth: isEnvTokenActive", () => {
-  test("returns true for SENTRY_AUTH_TOKEN", () => {
-    process.env.SENTRY_AUTH_TOKEN = "test_token";
-    expect(isEnvTokenActive()).toBe(true);
-  });
-
-  test("returns true for SENTRY_TOKEN", () => {
-    process.env.SENTRY_TOKEN = "test_token";
-    expect(isEnvTokenActive()).toBe(true);
-  });
-
-  test("returns false when no env var set", () => {
-    expect(isEnvTokenActive()).toBe(false);
-  });
-
+describe("env var auth: isEnvTokenActive edge case", () => {
   test("returns false for empty env var", () => {
     process.env.SENTRY_AUTH_TOKEN = "";
     expect(isEnvTokenActive()).toBe(false);
@@ -178,23 +113,8 @@ describe("env var auth: getActiveEnvVarName", () => {
   });
 });
 
-describe("env var auth: refreshToken", () => {
-  test("returns env token without refreshing", async () => {
-    process.env.SENTRY_AUTH_TOKEN = "env_token";
-    const result = await refreshToken();
-    expect(result.token).toBe("env_token");
-    expect(result.refreshed).toBe(false);
-  });
-
-  test("returns env token even with force=true", async () => {
-    process.env.SENTRY_AUTH_TOKEN = "env_token";
-    const result = await refreshToken({ force: true });
-    expect(result.token).toBe("env_token");
-    expect(result.refreshed).toBe(false);
-  });
-
+describe("env var auth: refreshToken edge cases", () => {
   test("env token skips stored token entirely", async () => {
-    // Store a token that would require refresh (expired)
     setAuthToken("stored_token", -1, "refresh_token");
     process.env.SENTRY_AUTH_TOKEN = "env_token";
     const result = await refreshToken();