Skip to content

Commit 41bd46a

Browse files
authored
fix(craft): use regex pattern for binary artifact matching (#230)
## Summary Fixes the broken `curl` install (`curl https://cli.sentry.dev/install | bash`) which 404s because 0.9.0 shipped without platform binaries. ## Root Cause Craft's `patternToRegexp()` treats plain strings as **exact matches**, escaping `*` to `\*`. The pattern `'sentry-*'` in `.craft.yml` became `/^sentry\-\*$/` — matching only the literal string `"sentry-*"`, not actual artifact names like `sentry-linux-x64`. Only `gh-pages` and `npm-package` (exact name matches) were downloaded and uploaded to the GitHub release. All 5 platform binaries were silently skipped. ## Fix Use Craft's regex syntax (`'/^sentry-.*$/'` with enclosing slashes) so the pattern is parsed as an actual regex. This was introduced in #215 when migrating from `requireNames` (which used proper regex `/^sentry-.+$/`) to the new `artifactProvider` config.
1 parent 00e589e commit 41bd46a

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.craft.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ artifactProvider:
1010
config:
1111
artifacts:
1212
Build:
13-
- 'sentry-*'
13+
- '/^sentry-.*$/'
1414
- 'npm-package'
1515
- 'gh-pages'
1616
targets:

0 commit comments

Comments
 (0)