Skip to content

Commit 3d90fdf

Browse files
committed
fix(issue-list): escape sort value in buildMultiTargetContextKey for consistency
buildPaginationContextKey escapes all param values via escapeContextKeyValue, but buildMultiTargetContextKey only escaped period and query, leaving sort unescaped. Fix the inconsistency by escaping sort too. Current sort values (date/duration) don't contain pipes so there's no active bug, but consistent escaping prevents future issues if sort values change.
1 parent ed6ac85 commit 3d90fdf

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

src/commands/issue/list.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -670,9 +670,10 @@ function buildMultiTargetContextKey(
670670
? escapeContextKeyValue(flags.query)
671671
: undefined;
672672
const escapedPeriod = escapeContextKeyValue(flags.period ?? "90d");
673+
const escapedSort = escapeContextKeyValue(flags.sort);
673674
return (
674675
`host:${host}|type:multi:${targetFingerprint}` +
675-
`|sort:${flags.sort}|period:${escapedPeriod}` +
676+
`|sort:${escapedSort}|period:${escapedPeriod}` +
676677
(escapedQuery ? `|q:${escapedQuery}` : "")
677678
);
678679
}

0 commit comments

Comments
 (0)