refactor: consolidate limit constants into shared LIST_MAX_LIMIT/LIST_MIN_LIMIT/LIST_DEFAULT_LIMIT

BYK · BYK · commit 39faa8de9c21 · 2026-04-06T20:28:29.000Z
Every list command duplicated MAX_LIMIT (1000), MIN_LIMIT (1), and
DEFAULT_LIMIT (varying 20-100) locally. Move them to list-command.ts as
LIST_MAX_LIMIT, LIST_MIN_LIMIT, and LIST_DEFAULT_LIMIT (standardized to 25).

- trace list default: 20 → 25
- trace logs default: 100 → 25
- log list default: 100 → 25
- buildListLimitFlag default: 30 → 25
- issue list: remove redundant explicit "25" (now the default)
diff --git a/plugins/sentry-cli/skills/sentry-cli/references/dashboard.md b/plugins/sentry-cli/skills/sentry-cli/references/dashboard.md
@@ -17,7 +17,7 @@ List dashboards
 
 **Flags:**
 - `-w, --web - Open in browser`
-- `-n, --limit <value> - Maximum number of dashboards to list - (default: "30")`
+- `-n, --limit <value> - Maximum number of dashboards to list - (default: "25")`
 - `-f, --fresh - Bypass cache, re-detect projects, and fetch fresh data`
 - `-c, --cursor <value> - Navigate pages: "next", "prev", "first" (or raw cursor string)`
 
diff --git a/plugins/sentry-cli/skills/sentry-cli/references/log.md b/plugins/sentry-cli/skills/sentry-cli/references/log.md
@@ -16,7 +16,7 @@ View Sentry logs
 List logs from a project
 
 **Flags:**
-- `-n, --limit <value> - Number of log entries (1-1000) - (default: "100")`
+- `-n, --limit <value> - Number of log entries (1-1000) - (default: "25")`
 - `-q, --query <value> - Filter query (Sentry search syntax)`
 - `-f, --follow <value> - Stream logs (optionally specify poll interval in seconds)`
 - `-t, --period <value> - Time period (e.g., "30d", "14d", "24h"). Default: 30d (project mode), 14d (trace mode)`
diff --git a/plugins/sentry-cli/skills/sentry-cli/references/org.md b/plugins/sentry-cli/skills/sentry-cli/references/org.md
@@ -16,7 +16,7 @@ Work with Sentry organizations
 List organizations
 
 **Flags:**
-- `-n, --limit <value> - Maximum number of organizations to list - (default: "30")`
+- `-n, --limit <value> - Maximum number of organizations to list - (default: "25")`
 - `-f, --fresh - Bypass cache, re-detect projects, and fetch fresh data`
 
 ### `sentry org view <org>`
diff --git a/plugins/sentry-cli/skills/sentry-cli/references/project.md b/plugins/sentry-cli/skills/sentry-cli/references/project.md
@@ -56,7 +56,7 @@ sentry project delete my-org/old-project --yes
 List projects
 
 **Flags:**
-- `-n, --limit <value> - Maximum number of projects to list - (default: "30")`
+- `-n, --limit <value> - Maximum number of projects to list - (default: "25")`
 - `-p, --platform <value> - Filter by platform (e.g., javascript, python)`
 - `-f, --fresh - Bypass cache, re-detect projects, and fetch fresh data`
 - `-c, --cursor <value> - Navigate pages: "next", "prev", "first" (or raw cursor string)`
diff --git a/plugins/sentry-cli/skills/sentry-cli/references/release.md b/plugins/sentry-cli/skills/sentry-cli/references/release.md
@@ -16,7 +16,7 @@ Work with Sentry releases
 List releases
 
 **Flags:**
-- `-n, --limit <value> - Maximum number of releases to list - (default: "30")`
+- `-n, --limit <value> - Maximum number of releases to list - (default: "25")`
 - `-f, --fresh - Bypass cache, re-detect projects, and fetch fresh data`
 - `-c, --cursor <value> - Navigate pages: "next", "prev", "first" (or raw cursor string)`
 
diff --git a/plugins/sentry-cli/skills/sentry-cli/references/repo.md b/plugins/sentry-cli/skills/sentry-cli/references/repo.md
@@ -16,7 +16,7 @@ Work with Sentry repositories
 List repositories
 
 **Flags:**
-- `-n, --limit <value> - Maximum number of repositories to list - (default: "30")`
+- `-n, --limit <value> - Maximum number of repositories to list - (default: "25")`
 - `-f, --fresh - Bypass cache, re-detect projects, and fetch fresh data`
 - `-c, --cursor <value> - Navigate pages: "next", "prev", "first" (or raw cursor string)`
 
diff --git a/plugins/sentry-cli/skills/sentry-cli/references/team.md b/plugins/sentry-cli/skills/sentry-cli/references/team.md
@@ -16,7 +16,7 @@ Work with Sentry teams
 List teams
 
 **Flags:**
-- `-n, --limit <value> - Maximum number of teams to list - (default: "30")`
+- `-n, --limit <value> - Maximum number of teams to list - (default: "25")`
 - `-f, --fresh - Bypass cache, re-detect projects, and fetch fresh data`
 - `-c, --cursor <value> - Navigate pages: "next", "prev", "first" (or raw cursor string)`
 
diff --git a/plugins/sentry-cli/skills/sentry-cli/references/trace.md b/plugins/sentry-cli/skills/sentry-cli/references/trace.md
@@ -16,7 +16,7 @@ View distributed traces
 List recent traces in a project
 
 **Flags:**
-- `-n, --limit <value> - Number of traces (1-1000) - (default: "20")`
+- `-n, --limit <value> - Number of traces (1-1000) - (default: "25")`
 - `-q, --query <value> - Search query (Sentry search syntax)`
 - `-s, --sort <value> - Sort by: date, duration - (default: "date")`
 - `-t, --period <value> - Time period (e.g., "1h", "24h", "7d", "30d") - (default: "7d")`
@@ -79,7 +79,7 @@ View logs associated with a trace
 **Flags:**
 - `-w, --web - Open trace in browser`
 - `-t, --period <value> - Time period to search (e.g., "14d", "7d", "24h"). Default: 14d - (default: "14d")`
-- `-n, --limit <value> - Number of log entries (<=1000) - (default: "100")`
+- `-n, --limit <value> - Number of log entries (<=1000) - (default: "25")`
 - `-q, --query <value> - Additional filter query (Sentry search syntax)`
 - `-s, --sort <value> - Sort order: "newest" (default) or "oldest" - (default: "newest")`
 - `-f, --fresh - Bypass cache, re-detect projects, and fetch fresh data`
diff --git a/src/commands/event/shared-events.ts b/src/commands/event/shared-events.ts
@@ -11,7 +11,13 @@ import { filterFields } from "../../lib/formatters/json.js";
 import { colorTag, escapeMarkdownCell } from "../../lib/formatters/markdown.js";
 import { type Column, formatTable } from "../../lib/formatters/table.js";
 import { formatRelativeTime } from "../../lib/formatters/time-utils.js";
-import { LIST_PERIOD_FLAG, PERIOD_ALIASES } from "../../lib/list-command.js";
+import {
+  LIST_DEFAULT_LIMIT,
+  LIST_MAX_LIMIT,
+  LIST_MIN_LIMIT,
+  LIST_PERIOD_FLAG,
+  PERIOD_ALIASES,
+} from "../../lib/list-command.js";
 import type { IssueEvent } from "../../types/index.js";
 
 // ---------------------------------------------------------------------------
@@ -55,15 +61,6 @@ export type EventsResult = {
 // Constants
 // ---------------------------------------------------------------------------
 
-/** Maximum allowed value for --limit flag */
-export const MAX_LIMIT = 1000;
-
-/** Minimum allowed value for --limit flag */
-export const MIN_LIMIT = 1;
-
-/** Default number of events to show */
-export const DEFAULT_LIMIT = 25;
-
 /** Default time period for event queries */
 export const DEFAULT_PERIOD = "7d";
 
@@ -192,7 +189,7 @@ export function appendEventsFlags(
 
 /** Parse --limit flag, delegating range validation to shared utility. */
 export function parseLimit(value: string): number {
-  return validateLimit(value, MIN_LIMIT, MAX_LIMIT);
+  return validateLimit(value, LIST_MIN_LIMIT, LIST_MAX_LIMIT);
 }
 
 // ---------------------------------------------------------------------------
@@ -204,8 +201,8 @@ export const EVENTS_FLAGS = {
   limit: {
     kind: "parsed",
     parse: parseLimit,
-    brief: `Number of events (${MIN_LIMIT}-${MAX_LIMIT})`,
-    default: String(DEFAULT_LIMIT),
+    brief: `Number of events (${LIST_MIN_LIMIT}-${LIST_MAX_LIMIT})`,
+    default: String(LIST_DEFAULT_LIMIT),
   },
   query: {
     kind: "parsed",
diff --git a/src/commands/issue/list.ts b/src/commands/issue/list.ts
@@ -57,6 +57,7 @@ import {
   buildListCommand,
   buildListLimitFlag,
   LIST_BASE_ALIASES,
+  LIST_MAX_LIMIT,
   LIST_TARGET_POSITIONAL,
   paginationHint,
   parseCursorFlag,
@@ -132,12 +133,6 @@ const VALID_SORT_VALUES: SortValue[] = ["date", "new", "freq", "user"];
 /** Usage hint for ContextError messages */
 const USAGE_HINT = "sentry issue list <org>/<project>";
 
-/**
- * Maximum --limit value (user-facing ceiling for practical CLI response times).
- * Auto-pagination can theoretically fetch more, but 1000 keeps responses reasonable.
- */
-const MAX_LIMIT = 1000;
-
 /** Options returned by {@link buildListApiOptions}. */
 type ListApiOptions = {
   /** Fields to collapse (omit) from the API response for performance. */
@@ -1374,7 +1369,7 @@ async function handleResolvedTargets(
 
   let moreHint: string | undefined;
   if (hasMoreToShow) {
-    const higherLimit = Math.min(flags.limit * 2, MAX_LIMIT);
+    const higherLimit = Math.min(flags.limit * 2, LIST_MAX_LIMIT);
     const canIncreaseLimit = higherLimit > flags.limit;
     const actionParts: string[] = [];
     if (canIncreaseLimit) {
@@ -1429,7 +1424,7 @@ export const __testing = {
   compareDates,
   parseSort,
   CURSOR_SEP,
-  MAX_LIMIT,
+  MAX_LIMIT: LIST_MAX_LIMIT,
   VALID_SORT_VALUES,
 };
 
@@ -1542,7 +1537,7 @@ export const listCommand = buildListCommand("issue", {
         brief: "Search query (Sentry search syntax)",
         optional: true,
       },
-      limit: buildListLimitFlag("issues", "25"),
+      limit: buildListLimitFlag("issues"),
       sort: {
         kind: "parsed",
         parse: parseSort,
@@ -1586,9 +1581,9 @@ export const listCommand = buildListCommand("issue", {
     if (flags.limit < 1) {
       throw new ValidationError("--limit must be at least 1.", "limit");
     }
-    if (flags.limit > MAX_LIMIT) {
+    if (flags.limit > LIST_MAX_LIMIT) {
       throw new ValidationError(
-        `--limit cannot exceed ${MAX_LIMIT}. ` +
+        `--limit cannot exceed ${LIST_MAX_LIMIT}. ` +
           "Use --cursor to paginate through larger result sets.",
         "limit"
       );
diff --git a/src/commands/log/list.ts b/src/commands/log/list.ts
@@ -37,6 +37,9 @@ import {
 import type { StreamingTable } from "../../lib/formatters/text-table.js";
 import {
   buildListCommand,
+  LIST_DEFAULT_LIMIT,
+  LIST_MAX_LIMIT,
+  LIST_MIN_LIMIT,
   TARGET_PATTERN_NOTE,
 } from "../../lib/list-command.js";
 import { logger } from "../../lib/logger.js";
@@ -79,15 +82,6 @@ type LogListResult = {
 /** Output yielded by log list: either a batch (single-fetch) or an individual item (follow). */
 type LogOutput = LogLike | LogListResult;
 
-/** Maximum allowed value for --limit flag */
-const MAX_LIMIT = 1000;
-
-/** Minimum allowed value for --limit flag */
-const MIN_LIMIT = 1;
-
-/** Default number of log entries to show */
-const DEFAULT_LIMIT = 100;
-
 /** Default poll interval in seconds for --follow mode */
 const DEFAULT_POLL_INTERVAL = 2;
 
@@ -104,7 +98,7 @@ const DEFAULT_TRACE_PERIOD = "14d";
  * Parse --limit flag, delegating range validation to shared utility.
  */
 function parseLimit(value: string): number {
-  return validateLimit(value, MIN_LIMIT, MAX_LIMIT);
+  return validateLimit(value, LIST_MIN_LIMIT, LIST_MAX_LIMIT);
 }
 
 /**
@@ -633,8 +627,8 @@ export const listCommand = buildListCommand(
         limit: {
           kind: "parsed",
           parse: parseLimit,
-          brief: `Number of log entries (${MIN_LIMIT}-${MAX_LIMIT})`,
-          default: String(DEFAULT_LIMIT),
+          brief: `Number of log entries (${LIST_MIN_LIMIT}-${LIST_MAX_LIMIT})`,
+          default: String(LIST_DEFAULT_LIMIT),
         },
         query: {
           kind: "parsed",
diff --git a/src/commands/span/list.ts b/src/commands/span/list.ts
@@ -31,6 +31,8 @@ import { renderMarkdown } from "../../lib/formatters/markdown.js";
 import { CommandOutput } from "../../lib/formatters/output.js";
 import {
   buildListCommand,
+  LIST_DEFAULT_LIMIT,
+  LIST_MAX_LIMIT,
   LIST_PERIOD_FLAG,
   PERIOD_ALIASES,
   paginationHint,
@@ -133,17 +135,6 @@ function extractExtraApiFields(
 /** Accepted values for the --sort flag (matches trace list) */
 const VALID_SORT_VALUES: SpanSortValue[] = ["date", "duration"];
 
-/**
- * CLI-side upper bound for --limit.
- *
- * Passed directly as `per_page` to the Sentry Events API (spans dataset).
- * Matches the cap used by `issue list`, `trace list`, and `log list`.
- */
-const MAX_LIMIT = 1000;
-
-/** Default number of spans to show */
-const DEFAULT_LIMIT = 25;
-
 /** Default sort order for span results */
 const DEFAULT_SORT: SpanSortValue = "date";
 
@@ -166,7 +157,7 @@ const TRACE_USAGE_HINT = "sentry span list [<org>/<project>/]<trace-id>";
  * Parse --limit flag, delegating range validation to shared utility.
  */
 function parseLimit(value: string): number {
-  return validateLimit(value, 1, MAX_LIMIT);
+  return validateLimit(value, 1, LIST_MAX_LIMIT);
 }
 
 /**
@@ -570,8 +561,8 @@ export const listCommand = buildListCommand("span", {
       limit: {
         kind: "parsed",
         parse: parseLimit,
-        brief: `Number of spans (<=${MAX_LIMIT})`,
-        default: String(DEFAULT_LIMIT),
+        brief: `Number of spans (<=${LIST_MAX_LIMIT})`,
+        default: String(LIST_DEFAULT_LIMIT),
       },
       query: {
         kind: "parsed",
diff --git a/src/commands/trace/list.ts b/src/commands/trace/list.ts
@@ -18,6 +18,9 @@ import { filterFields } from "../../lib/formatters/json.js";
 import { CommandOutput } from "../../lib/formatters/output.js";
 import {
   buildListCommand,
+  LIST_DEFAULT_LIMIT,
+  LIST_MAX_LIMIT,
+  LIST_MIN_LIMIT,
   LIST_PERIOD_FLAG,
   PERIOD_ALIASES,
   paginationHint,
@@ -67,15 +70,6 @@ type TraceListResult = {
 /** Accepted values for the --sort flag */
 const VALID_SORT_VALUES: SortValue[] = ["date", "duration"];
 
-/** Maximum allowed value for --limit flag */
-const MAX_LIMIT = 1000;
-
-/** Minimum allowed value for --limit flag */
-const MIN_LIMIT = 1;
-
-/** Default number of traces to show */
-const DEFAULT_LIMIT = 20;
-
 /** Command name used in resolver error messages */
 const COMMAND_NAME = "trace list";
 
@@ -125,7 +119,7 @@ function prevPageHint(
  * Parse --limit flag, delegating range validation to shared utility.
  */
 function parseLimit(value: string): number {
-  return validateLimit(value, MIN_LIMIT, MAX_LIMIT);
+  return validateLimit(value, LIST_MIN_LIMIT, LIST_MAX_LIMIT);
 }
 
 /**
@@ -231,8 +225,8 @@ export const listCommand = buildListCommand("trace", {
       limit: {
         kind: "parsed",
         parse: parseLimit,
-        brief: `Number of traces (${MIN_LIMIT}-${MAX_LIMIT})`,
-        default: String(DEFAULT_LIMIT),
+        brief: `Number of traces (${LIST_MIN_LIMIT}-${LIST_MAX_LIMIT})`,
+        default: String(LIST_DEFAULT_LIMIT),
       },
       query: {
         kind: "parsed",
diff --git a/src/commands/trace/logs.ts b/src/commands/trace/logs.ts
@@ -16,6 +16,8 @@ import {
   applyFreshFlag,
   FRESH_ALIASES,
   FRESH_FLAG,
+  LIST_DEFAULT_LIMIT,
+  LIST_MAX_LIMIT,
 } from "../../lib/list-command.js";
 import { withProgress } from "../../lib/polling.js";
 import { buildTraceUrl } from "../../lib/sentry-urls.js";
@@ -65,12 +67,6 @@ function formatTraceLogsHuman(data: TraceLogsData): string {
   return parts.join("").trimEnd();
 }
 
-/** Maximum allowed value for --limit flag */
-const MAX_LIMIT = 1000;
-
-/** Default number of log entries to show */
-const DEFAULT_LIMIT = 100;
-
 /**
  * Default time period for the trace-logs API.
  * The API requires statsPeriod — without it the response may be empty even
@@ -85,7 +81,7 @@ const USAGE_HINT = "sentry trace logs [<org>/]<trace-id>";
  * Parse --limit flag, delegating range validation to shared utility.
  */
 function parseLimit(value: string): number {
-  return validateLimit(value, 1, MAX_LIMIT);
+  return validateLimit(value, 1, LIST_MAX_LIMIT);
 }
 
 export const logsCommand = buildCommand({
@@ -139,8 +135,8 @@ export const logsCommand = buildCommand({
       limit: {
         kind: "parsed",
         parse: parseLimit,
-        brief: `Number of log entries (<=${MAX_LIMIT})`,
-        default: String(DEFAULT_LIMIT),
+        brief: `Number of log entries (<=${LIST_MAX_LIMIT})`,
+        default: String(LIST_DEFAULT_LIMIT),
       },
       query: {
         kind: "parsed",
diff --git a/src/lib/arg-parsing.ts b/src/lib/arg-parsing.ts
@@ -243,13 +243,17 @@ export function detectSwappedTrialArgs(
  * Used by commands that need API-side limiting (trace list, log list) where
  * the value is passed directly to the API as `per_page`.
  *
+ * Defaults match the shared constants {@link LIST_MIN_LIMIT} (1) and
+ * {@link LIST_MAX_LIMIT} (1000) from `list-command.ts`.
+ *
  * @param value - Raw string input from CLI flag
- * @param min - Minimum allowed value (inclusive)
- * @param max - Maximum allowed value (inclusive)
+ * @param min - Minimum allowed value (inclusive, default: 1)
+ * @param max - Maximum allowed value (inclusive, default: 1000)
  * @returns Parsed integer
  * @throws {Error} If value is NaN or outside [min, max]
  *
  * @example
+ * validateLimit("50")           // 50  (uses defaults 1–1000)
  * validateLimit("50", 1, 1000)  // 50
  * validateLimit("0", 1, 1000)   // throws
  * validateLimit("abc", 1, 1000) // throws
diff --git a/src/lib/list-command.ts b/src/lib/list-command.ts
