fix(db): use TABLE_SCHEMAS for transaction_aliases and bump schema to v6

Remove custom DDL handling (CUSTOM_DDL_TABLES, TRANSACTION_ALIASES_DDL,
repairTransactionAliasesTable) since TABLE_SCHEMAS already supports
compositePrimaryKey (used by pagination_cursors). Add
compositePrimaryKey: ["fingerprint", "idx"] to the schema definition.

Bump schema version 5→6 and split the migration so databases already at
v5 (from pagination_cursors) correctly pick up the transaction_aliases
table via the new v5→v6 migration block.

Author: BYK

src/lib/db/schema.ts

@@ -13,7 +13,7 @@
 
 import type { Database } from "bun:sqlite";
 
-export const CURRENT_SCHEMA_VERSION = 5;
+export const CURRENT_SCHEMA_VERSION = 6;
 
 /** Environment variable to disable auto-repair */
 const NO_AUTO_REPAIR_ENV = "SENTRY_CLI_NO_AUTO_REPAIR";
@@ -223,6 +223,7 @@ export const TABLE_SCHEMAS: Record<string, TableSchema> = {
         default: "(unixepoch() * 1000)",
       },
     },
+    compositePrimaryKey: ["fingerprint", "idx"],
   },
 };
 
@@ -397,47 +398,23 @@ export type RepairResult = {
   failed: string[];
 };
 
-/** Tables that require custom DDL (not auto-generated from TABLE_SCHEMAS) */
-const CUSTOM_DDL_TABLES = new Set(["transaction_aliases"]);
-
-function repairTransactionAliasesTable(
-  db: Database,
-  result: RepairResult
-): void {
-  if (tableExists(db, "transaction_aliases")) {
-    return;
-  }
-  try {
-    db.exec(TRANSACTION_ALIASES_DDL);
-    db.exec(TRANSACTION_ALIASES_INDEX);
-    result.fixed.push("Created table transaction_aliases");
-  } catch (e) {
-    const msg = e instanceof Error ? e.message : String(e);
-    result.failed.push(`Failed to create table transaction_aliases: ${msg}`);
-  }
-}
-
 function repairMissingTables(db: Database, result: RepairResult): void {
   for (const [tableName, ddl] of Object.entries(EXPECTED_TABLES)) {
-    // Skip tables that need custom DDL
-    if (CUSTOM_DDL_TABLES.has(tableName)) {
-      continue;
-    }
-
     if (tableExists(db, tableName)) {
       continue;
     }
     try {
       db.exec(ddl);
+      // Create associated indexes for tables that need them
+      if (tableName === "transaction_aliases") {
+        db.exec(TRANSACTION_ALIASES_INDEX);
+      }
       result.fixed.push(`Created table ${tableName}`);
     } catch (e) {
       const msg = e instanceof Error ? e.message : String(e);
       result.failed.push(`Failed to create table ${tableName}: ${msg}`);
     }
   }
-
-  // Handle tables with custom DDL
-  repairTransactionAliasesTable(db, result);
 }
 
 function repairMissingColumns(db: Database, result: RepairResult): void {
@@ -592,38 +569,15 @@ export function tryRepairAndRetry<T>(
   return { attempted: false };
 }
 
-/**
- * Custom DDL for transaction_aliases table with composite primary key.
- * TABLE_SCHEMAS doesn't support composite primary keys, so we handle this specially.
- */
-const TRANSACTION_ALIASES_DDL = `
-  CREATE TABLE IF NOT EXISTS transaction_aliases (
-    idx INTEGER NOT NULL,
-    alias TEXT NOT NULL,
-    transaction_name TEXT NOT NULL,
-    org_slug TEXT NOT NULL,
-    project_slug TEXT NOT NULL,
-    fingerprint TEXT NOT NULL,
-    cached_at INTEGER NOT NULL DEFAULT (unixepoch() * 1000),
-    PRIMARY KEY (fingerprint, idx)
-  )
-`;
-
+/** Index for efficient alias lookups by alias string + fingerprint */
 const TRANSACTION_ALIASES_INDEX = `
   CREATE INDEX IF NOT EXISTS idx_txn_alias_lookup 
   ON transaction_aliases(alias, fingerprint)
 `;
 
 export function initSchema(db: Database): void {
-  // Generate combined DDL from all table schemas (except transaction_aliases which has custom DDL)
-  const ddlStatements = Object.entries(EXPECTED_TABLES)
-    .filter(([name]) => name !== "transaction_aliases")
-    .map(([, ddl]) => ddl)
-    .join(";\n\n");
+  const ddlStatements = Object.values(EXPECTED_TABLES).join(";\n\n");
   db.exec(ddlStatements);
-
-  // Add transaction_aliases with composite primary key
-  db.exec(TRANSACTION_ALIASES_DDL);
   db.exec(TRANSACTION_ALIASES_INDEX);
 
   const versionRow = db
@@ -682,13 +636,17 @@ export function runMigrations(db: Database): void {
     db.exec(EXPECTED_TABLES.project_root_cache as string);
   }
 
-  // Migration 4 -> 5: Add transaction_aliases and pagination_cursors tables
+  // Migration 4 -> 5: Add pagination_cursors table
   if (currentVersion < 5) {
-    db.exec(TRANSACTION_ALIASES_DDL);
-    db.exec(TRANSACTION_ALIASES_INDEX);
     db.exec(EXPECTED_TABLES.pagination_cursors as string);
   }
 
+  // Migration 5 -> 6: Add transaction_aliases table
+  if (currentVersion < 6) {
+    db.exec(EXPECTED_TABLES.transaction_aliases as string);
+    db.exec(TRANSACTION_ALIASES_INDEX);
+  }
+
   if (currentVersion < CURRENT_SCHEMA_VERSION) {
     db.query("UPDATE schema_version SET version = ?").run(
       CURRENT_SCHEMA_VERSION