fix: scope cli subcommand suppression to avoid false positives

Address BugBot review: use positional matching (args[0]==="cli") for
setup/fix instead of bare SUPPRESSED_ARGS membership, so commands like
`sentry issue list --project setup` are not falsely suppressed.

Author: BYK

src/lib/version-check.ts

@@ -24,14 +24,19 @@ const JITTER_FACTOR = 0.2;
 /** Commands/flags that should not show update notifications */
 const SUPPRESSED_ARGS = new Set([
   "upgrade",
-  "setup",
-  "fix",
   "--version",
   "-V",
   "--json",
   "token",
 ]);
 
+/**
+ * CLI management subcommands that should not trigger version checks.
+ * Matched only when preceded by "cli" to avoid false positives
+ * (e.g., `--project setup` should not suppress notifications).
+ */
+const SUPPRESSED_CLI_SUBCOMMANDS = new Set(["setup", "fix"]);
+
 /** AbortController for pending version check fetch */
 let pendingAbortController: AbortController | null = null;
 
@@ -65,7 +70,14 @@ function shouldCheckForUpdate(): boolean {
  * Check if update notifications should be suppressed for these args.
  */
 export function shouldSuppressNotification(args: string[]): boolean {
-  return args.some((arg) => SUPPRESSED_ARGS.has(arg));
+  if (args.some((arg) => SUPPRESSED_ARGS.has(arg))) {
+    return true;
+  }
+  // Suppress for "cli <subcommand>" management commands (setup, fix)
+  if (args[0] === "cli" && SUPPRESSED_CLI_SUBCOMMANDS.has(args[1] ?? "")) {
+    return true;
+  }
+  return false;
 }
 
 /**

test/lib/version-check.test.ts

@@ -39,6 +39,15 @@ describe("shouldSuppressNotification", () => {
     expect(shouldSuppressNotification(["cli", "feedback"])).toBe(false);
   });
 
+  test("does not suppress when setup/fix appear as non-cli args", () => {
+    expect(
+      shouldSuppressNotification(["issue", "list", "--project", "setup"])
+    ).toBe(false);
+    expect(
+      shouldSuppressNotification(["issue", "list", "--query", "fix"])
+    ).toBe(false);
+  });
+
   test("suppresses for --version flag", () => {
     expect(shouldSuppressNotification(["--version"])).toBe(true);
     expect(shouldSuppressNotification(["-V"])).toBe(true);