fix(ci): resolve lint formatting and test failures

Fix 10 lint errors (trailing commas, line length, import ordering,
Response.json) and 2 test failures caused by fetchProjectId requiring
auth/region mocks when CLI flags are passed.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: betegon

src/commands/issue/list.ts

@@ -938,10 +938,12 @@ async function handleResolvedTargets(
   const failures: { target: ResolvedTarget; error: Error }[] = [];
 
   for (let i = 0; i < results.length; i++) {
+    // biome-ignore lint/style/noNonNullAssertion: index within bounds
     const result = results[i]!;
     if (result.success) {
       validResults.push(result.data);
     } else {
+      // biome-ignore lint/style/noNonNullAssertion: index within bounds
       failures.push({ target: activeTargets[i]!, error: result.error });
     }
   }
@@ -957,7 +959,7 @@ async function handleResolvedTargets(
         `${prefix}: ${first.message}`,
         first.status,
         first.detail,
-        first.endpoint,
+        first.endpoint
       );
     }
 
@@ -1007,8 +1009,12 @@ async function handleResolvedTargets(
     if (failures.length > 0) {
       output.errors = failures.map(({ target: t, error: e }) =>
         e instanceof ApiError
-          ? { project: `${t.org}/${t.project}`, status: e.status, message: e.message }
-          : { project: `${t.org}/${t.project}`, message: e.message },
+          ? {
+              project: `${t.org}/${t.project}`,
+              status: e.status,
+              message: e.message,
+            }
+          : { project: `${t.org}/${t.project}`, message: e.message }
       );
     }
     writeJson(stdout, output);
@@ -1021,8 +1027,8 @@ async function handleResolvedTargets(
       .join(", ");
     stderr.write(
       muted(
-        `\nNote: Failed to fetch issues from ${failedNames}. Showing results from ${validResults.length} project(s).\n`,
-      ),
+        `\nNote: Failed to fetch issues from ${failedNames}. Showing results from ${validResults.length} project(s).\n`
+      )
     );
   }
 

src/lib/resolve-target.ts

@@ -49,9 +49,11 @@ import { isAllDigits } from "./utils.js";
 
 /** Convert a string or numeric ID to a number, or `undefined` if falsy/NaN. */
 export function toNumericId(
-  id: string | number | undefined,
+  id: string | number | undefined
 ): number | undefined {
-  if (id == null) return undefined;
+  if (id === null) {
+    return;
+  }
   return Number(id) || undefined;
 }
 
@@ -551,7 +553,7 @@ function resolveFromEnvVars(): {
  */
 export async function fetchProjectId(
   org: string,
-  project: string,
+  project: string
 ): Promise<number | undefined> {
   try {
     const projectInfo = await getProject(org, project);
@@ -567,7 +569,7 @@ export async function fetchProjectId(
         `sentry issue list ${org}/<project>`,
         [
           `Check the project slug at https://sentry.io/organizations/${org}/projects/`,
-        ],
+        ]
       );
     }
     return;

test/commands/issue/list.test.ts

@@ -363,7 +363,9 @@ describe("issue list: partial failure handling", () => {
       "myproj"
     );
 
-    expect(stderr.output).toContain("Failed to fetch issues from org-two/myproj");
+    expect(stderr.output).toContain(
+      "Failed to fetch issues from org-two/myproj"
+    );
     expect(stderr.output).toContain("Showing results from 1 project(s)");
   });
 

test/lib/resolve-target.test.ts

@@ -8,14 +8,17 @@
 
 import { afterEach, beforeEach, describe, expect, test } from "bun:test";
 import { array, constantFrom, assert as fcAssert, property } from "fast-check";
-
+import { DEFAULT_SENTRY_URL } from "../../src/lib/constants.js";
+import { setAuthToken } from "../../src/lib/db/auth.js";
+import { setOrgRegion } from "../../src/lib/db/regions.js";
 import {
   isValidDirNameForInference,
   resolveAllTargets,
   resolveOrg,
   resolveOrgAndProject,
   resolveOrgsForListing,
 } from "../../src/lib/resolve-target.js";
+import { mockFetch, useTestConfigDir } from "../helpers.js";
 
 // ============================================================================
 // Arbitraries for Property-Based Testing
@@ -111,12 +114,18 @@ describe("isValidDirNameForInference edge cases", () => {
 // ============================================================================
 
 describe("Environment variable resolution (SENTRY_ORG / SENTRY_PROJECT)", () => {
+  useTestConfigDir("test-resolve-target-");
+
+  let originalFetch: typeof globalThis.fetch;
+
   beforeEach(() => {
+    originalFetch = globalThis.fetch;
     delete process.env.SENTRY_ORG;
     delete process.env.SENTRY_PROJECT;
   });
 
   afterEach(() => {
+    globalThis.fetch = originalFetch;
     delete process.env.SENTRY_ORG;
     delete process.env.SENTRY_PROJECT;
   });
@@ -171,6 +180,23 @@ describe("Environment variable resolution (SENTRY_ORG / SENTRY_PROJECT)", () =>
   test("resolveOrgAndProject: CLI flags override env vars", async () => {
     process.env.SENTRY_ORG = "env-org";
     process.env.SENTRY_PROJECT = "env-project";
+
+    await setAuthToken("test-token");
+    await setOrgRegion("flag-org", DEFAULT_SENTRY_URL);
+    globalThis.fetch = mockFetch(async (input, init) => {
+      const req = new Request(input, init);
+      if (req.url.includes("/api/0/projects/flag-org/flag-project/")) {
+        return Response.json({
+          id: "123",
+          slug: "flag-project",
+          name: "Flag Project",
+        });
+      }
+      return new Response(JSON.stringify({ detail: "Not found" }), {
+        status: 404,
+      });
+    });
+
     const result = await resolveOrgAndProject({
       org: "flag-org",
       project: "flag-project",
@@ -236,6 +262,23 @@ describe("Environment variable resolution (SENTRY_ORG / SENTRY_PROJECT)", () =>
   test("resolveAllTargets: CLI flags override env vars", async () => {
     process.env.SENTRY_ORG = "env-org";
     process.env.SENTRY_PROJECT = "env-project";
+
+    await setAuthToken("test-token");
+    await setOrgRegion("flag-org", DEFAULT_SENTRY_URL);
+    globalThis.fetch = mockFetch(async (input, init) => {
+      const req = new Request(input, init);
+      if (req.url.includes("/api/0/projects/flag-org/flag-project/")) {
+        return Response.json({
+          id: "123",
+          slug: "flag-project",
+          name: "Flag Project",
+        });
+      }
+      return new Response(JSON.stringify({ detail: "Not found" }), {
+        status: 404,
+      });
+    });
+
     const result = await resolveAllTargets({
       org: "flag-org",
       project: "flag-project",