Commit 0a8e649
authored
fix(telemetry): fix commands importing buildCommand directly from @stricli/core (#275)
## Summary
`trace/list`, `trace/view`, `log/view`, and `api.ts` were importing
`buildCommand` directly from `@stricli/core`, silently bypassing the
telemetry wrapper in `src/lib/command.ts` that captures flag and arg
context as Sentry tags.
## Changes
- Switch all four commands to import from `../../lib/command.js` (or
`../lib/command.js`)
- Add a prominent JSDoc comment in `command.ts` documenting the
requirement and the exception for `help.ts`
## Not changed
`help.ts` is intentionally left on `@stricli/core` — it also imports
`run` from there, and the help command has no meaningful flags to
capture for telemetry.
## Notes
A Biome `noRestrictedImports` lint rule to enforce this statically was
investigated but the rule is not available in the version of Biome used
here. The JSDoc comment in `command.ts` serves as the documented
convention instead.1 parent 24fe62c commit 0a8e649
File tree
5 files changed
+13
-5
lines changed- src
- commands
- log
- trace
- lib
5 files changed
+13
-5
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
9 | 8 | | |
10 | 9 | | |
| 10 | + | |
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
8 | 7 | | |
9 | 8 | | |
10 | 9 | | |
11 | 10 | | |
12 | 11 | | |
13 | 12 | | |
14 | 13 | | |
| 14 | + | |
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
8 | 7 | | |
9 | 8 | | |
10 | 9 | | |
| 10 | + | |
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
8 | 7 | | |
9 | 8 | | |
10 | 9 | | |
| |||
13 | 12 | | |
14 | 13 | | |
15 | 14 | | |
| 15 | + | |
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
6 | 14 | | |
7 | 15 | | |
8 | 16 | | |
| |||
0 commit comments