fix: improve CLI output for auth login and upgrade flows (#454)

Migrate diagnostic output from cluttered stderr `log.info()` calls to
the markdown-rendering pipeline for cleaner, more consistent formatting.

## Auth login (`interactive-login.ts`)
- Show `verification_uri_complete` (with `user_code` embedded) instead
of bare `verification_uri` so the URL works in headless environments
(SSH, CI)
- Use `log.log()` for URL/code detail lines instead of `log.info()` to
avoid repeated ℹ icon prefixes
- Only show copy hint when browser didn't open
- Render user code as inline code span via `renderInlineMarkdown()`

## CLI upgrade (`upgrade.ts` + `human.ts`)
- Demote method/version/channel/latest `log.info()` calls to
`log.debug()`
- Add metadata key-value table (method, channel) to
`formatUpgradeResult` via `mdKvTable()`, rendering through the standard
markdown pipeline
- Keep `log.info()` only for progress indicators that fire before the
result is ready (`Upgrading to...`, nightly migration)

Closes #452

Author: BYK

src/commands/cli/upgrade.ts

@@ -271,10 +271,10 @@ async function resolveTargetVersion(
   const latest = await fetchLatestVersion(method, channel);
   const target = versionArg?.replace(VERSION_PREFIX_REGEX, "") ?? latest;
 
-  log.info(`Channel: ${channel}`);
-  log.info(`Latest version: ${latest}`);
+  log.debug(`Channel: ${channel}`);
+  log.debug(`Latest version: ${latest}`);
   if (versionArg) {
-    log.info(`Target version: ${target}`);
+    log.debug(`Target version: ${target}`);
   }
 
   if (flags.check) {
@@ -639,8 +639,8 @@ export const upgradeCommand = buildCommand({
     const { channel, versionArg, channelChanged, method } =
       await resolveContext(version, flags);
 
-    log.info(`Installation method: ${method}`);
-    log.info(`Current version: ${CLI_VERSION}`);
+    log.debug(`Installation method: ${method}`);
+    log.debug(`Current version: ${CLI_VERSION}`);
 
     const resolved = await resolveTargetWithFallback({
       resolveOpts: { method, channel, versionArg, channelChanged, flags },

src/lib/formatters/human.ts

@@ -2123,6 +2123,16 @@ export function formatUpgradeResult(data: UpgradeResult): string {
     }
   }
 
+  // Metadata table — renders method, channel, and version info below the
+  // action line so diagnostics go to stdout (via the markdown pipeline)
+  // instead of cluttering stderr with repeated log.info() lines.
+  const kvRows: [string, string][] = [
+    ["Method", escapeMarkdownInline(data.method)],
+    ["Channel", escapeMarkdownInline(data.channel)],
+  ];
+  lines.push("");
+  lines.push(mdKvTable(kvRows));
+
   // Append warnings with ⚠ markers
   if (data.warnings && data.warnings.length > 0) {
     lines.push("");

src/lib/interactive-login.ts

@@ -12,7 +12,7 @@ import { setupCopyKeyListener } from "./clipboard.js";
 import { getDbPath } from "./db/index.js";
 import { setUserInfo } from "./db/user.js";
 import { formatError } from "./errors.js";
-import { muted } from "./formatters/colors.js";
+import { renderInlineMarkdown } from "./formatters/markdown.js";
 import { logger } from "./logger.js";
 import { completeOAuthFlow, performDeviceFlow } from "./oauth.js";
 import { generateQRCode } from "./qrcode.js";
@@ -37,6 +37,45 @@ export type InteractiveLoginOptions = {
   timeout?: number;
 };
 
+/**
+ * Build the user-facing display lines for the device flow verification step.
+ *
+ * Shows the complete verification URL (with embedded user code) so it works
+ * in environments where the browser can't auto-open (SSH, CI, etc.).
+ * Uses `renderInlineMarkdown()` for styled output that respects `NO_COLOR`.
+ *
+ * Extracted from the `onUserCode` callback for testability.
+ *
+ * @param userCode - The device flow user code (e.g., "ABCD-EFGH")
+ * @param verificationUriComplete - Full URL with `?user_code=...` embedded
+ * @param browserOpened - Whether the browser was successfully opened
+ * @param isTTY - Whether stdin is a TTY (controls copy-to-clipboard hint)
+ * @returns Array of strings to emit via `log.log()`, one per call
+ */
+export function buildDeviceFlowDisplay(
+  userCode: string,
+  verificationUriComplete: string,
+  browserOpened: boolean,
+  isTTY: boolean
+): string[] {
+  const lines: string[] = [];
+
+  lines.push("");
+  // URL is emitted as plain text (no markdown rendering) so it stays
+  // intact for copy-paste in all output modes including plain/CI.
+  lines.push(`  URL:  ${verificationUriComplete}`);
+  lines.push(renderInlineMarkdown(`  Code: \`${userCode}\``));
+  lines.push("");
+
+  if (!browserOpened) {
+    const copyHint = isTTY ? renderInlineMarkdown(" *(`c` to copy URL)*") : "";
+    lines.push(`  Copy the URL above to sign in.${copyHint}`);
+    lines.push("");
+  }
+
+  return lines;
+}
+
 /**
  * Run the interactive OAuth device flow login.
  *
@@ -69,7 +108,7 @@ export async function runInteractiveLogin(
       {
         onUserCode: async (
           userCode,
-          verificationUri,
+          _verificationUri,
           verificationUriComplete
         ) => {
           urlToCopy = verificationUriComplete;
@@ -86,21 +125,24 @@ export async function runInteractiveLogin(
             log.log(qr);
           }
 
-          log.info(`URL: ${verificationUri}`);
-          log.info(`Code: ${userCode}`);
-          const stdin = process.stdin;
-          const copyHint = stdin.isTTY ? ` ${muted("(c to copy)")}` : "";
-          log.info(
-            `Browser didn't open? Use the url above to sign in${copyHint}`
+          // Show the complete URL (with user_code embedded) and optional copy hint
+          const displayLines = buildDeviceFlowDisplay(
+            userCode,
+            verificationUriComplete,
+            browserOpened,
+            process.stdin.isTTY ?? false
           );
+          for (const line of displayLines) {
+            log.log(line);
+          }
 
           // Use a spinner for the "waiting" state instead of raw polling dots
           log.start("Waiting for authorization...");
 
           // Setup keyboard listener for 'c' to copy URL
-          if (stdin.isTTY) {
+          if (process.stdin.isTTY) {
             keyListener.cleanup = setupCopyKeyListener(
-              stdin as NodeJS.ReadStream & { fd: 0 },
+              process.stdin as NodeJS.ReadStream & { fd: 0 },
               () => urlToCopy
             );
           }

test/commands/cli/upgrade.test.ts

@@ -63,6 +63,11 @@ function createMockContext(
     ...overrides.env,
   };
 
+  // Force plain output so formatUpgradeResult renders raw markdown tables
+  // (ASCII pipes) instead of Unicode box-drawing characters in TTY mode.
+  const origPlain = process.env.SENTRY_PLAIN_OUTPUT;
+  process.env.SENTRY_PLAIN_OUTPUT = "1";
+
   // Capture consola output (routed to process.stderr)
   const origWrite = process.stderr.write.bind(process.stderr);
   process.stderr.write = ((chunk: string | Uint8Array) => {
@@ -123,6 +128,11 @@ function createMockContext(
     errors,
     restore: () => {
       process.stderr.write = origWrite;
+      if (origPlain === undefined) {
+        delete process.env.SENTRY_PLAIN_OUTPUT;
+      } else {
+        process.env.SENTRY_PLAIN_OUTPUT = origPlain;
+      }
     },
   };
 }
@@ -268,9 +278,8 @@ describe("sentry cli upgrade", () => {
       );
 
       const combined = getOutput();
-      expect(combined).toContain("Installation method: curl");
-      expect(combined).toContain(`Current version: ${CLI_VERSION}`);
-      expect(combined).toContain(`Latest version: ${CLI_VERSION}`);
+      expect(combined).toContain("| curl |");
+      expect(combined).toContain(CLI_VERSION);
       expect(combined).toContain("You are already on the target version");
     });
 
@@ -289,7 +298,7 @@ describe("sentry cli upgrade", () => {
       );
 
       const combined = getOutput();
-      expect(combined).toContain("Latest version: 99.99.99");
+      expect(combined).toContain("99.99.99");
       expect(combined).toContain("Run 'sentry cli upgrade' to update.");
     });
 
@@ -308,7 +317,7 @@ describe("sentry cli upgrade", () => {
       );
 
       const combined = getOutput();
-      expect(combined).toContain("Target version: 88.88.88");
+      expect(combined).toContain("88.88.88");
       expect(combined).toContain(
         "Run 'sentry cli upgrade 88.88.88' to update."
       );
@@ -363,8 +372,8 @@ describe("sentry cli upgrade", () => {
       );
 
       const combined = getOutput();
-      expect(combined).toContain("Installation method: brew");
-      expect(combined).toContain("Latest version: 99.99.99");
+      expect(combined).toContain("| brew |");
+      expect(combined).toContain("99.99.99");
       expect(combined).toContain("Run 'sentry cli upgrade' to update.");
     });
   });
@@ -500,7 +509,7 @@ describe("sentry cli upgrade — nightly channel", () => {
       );
 
       const combined = getOutput();
-      expect(combined).toContain("Channel: nightly");
+      expect(combined).toContain("| nightly |");
     });
 
     test("'stable' positional sets channel to stable", async () => {
@@ -519,7 +528,7 @@ describe("sentry cli upgrade — nightly channel", () => {
       );
 
       const combined = getOutput();
-      expect(combined).toContain("Channel: stable");
+      expect(combined).toContain("| stable |");
     });
 
     test("without positional, uses persisted channel", async () => {
@@ -538,7 +547,7 @@ describe("sentry cli upgrade — nightly channel", () => {
       );
 
       const combined = getOutput();
-      expect(combined).toContain("Channel: nightly");
+      expect(combined).toContain("| nightly |");
     });
   });
 
@@ -593,8 +602,8 @@ describe("sentry cli upgrade — nightly channel", () => {
       );
 
       const combined = getOutput();
-      expect(combined).toContain("Channel: nightly");
-      expect(combined).toContain(`Latest version: ${CLI_VERSION}`);
+      expect(combined).toContain("| nightly |");
+      expect(combined).toContain(CLI_VERSION);
       expect(combined).toContain("You are already on the target version");
     });
 
@@ -613,8 +622,8 @@ describe("sentry cli upgrade — nightly channel", () => {
       );
 
       const combined = getOutput();
-      expect(combined).toContain("Channel: nightly");
-      expect(combined).toContain("Latest version: 0.99.0-dev.9999999999");
+      expect(combined).toContain("| nightly |");
+      expect(combined).toContain("0.99.0-dev.9999999999");
       expect(combined).toContain("Run 'sentry cli upgrade' to update.");
     });
   });

test/lib/formatters/human.test.ts

@@ -14,6 +14,7 @@ import {
   formatIssueSubtitle,
   formatProjectCreated,
   formatShortId,
+  formatUpgradeResult,
   formatUserIdentity,
   type IssueTableRow,
   type ProjectCreatedResult,
@@ -738,3 +739,66 @@ describe("formatDashboardView", () => {
     expect(result).toContain("No widgets.");
   });
 });
+
+describe("formatUpgradeResult", () => {
+  // Force plain output so we get raw markdown (no ANSI codes)
+  const origPlain = process.env.SENTRY_PLAIN_OUTPUT;
+  function withPlain(fn: () => void) {
+    process.env.SENTRY_PLAIN_OUTPUT = "1";
+    try {
+      fn();
+    } finally {
+      if (origPlain === undefined) {
+        delete process.env.SENTRY_PLAIN_OUTPUT;
+      } else {
+        process.env.SENTRY_PLAIN_OUTPUT = origPlain;
+      }
+    }
+  }
+
+  test("renders metadata table with method and channel", () => {
+    withPlain(() => {
+      const result = formatUpgradeResult({
+        action: "upgraded",
+        currentVersion: "0.5.0",
+        targetVersion: "0.6.0",
+        channel: "stable",
+        method: "curl",
+        forced: false,
+      });
+      expect(result).toContain("| **Method** | curl |");
+      expect(result).toContain("| **Channel** | stable |");
+    });
+  });
+
+  test("renders nightly channel in metadata table", () => {
+    withPlain(() => {
+      const result = formatUpgradeResult({
+        action: "checked",
+        currentVersion: "0.5.0",
+        targetVersion: "0.6.0-dev.123",
+        channel: "nightly",
+        method: "npm",
+        forced: false,
+      });
+      expect(result).toContain("| **Method** | npm |");
+      expect(result).toContain("| **Channel** | nightly |");
+    });
+  });
+
+  test("up-to-date action includes metadata table", () => {
+    withPlain(() => {
+      const result = formatUpgradeResult({
+        action: "up-to-date",
+        currentVersion: "0.5.0",
+        targetVersion: "0.5.0",
+        channel: "stable",
+        method: "brew",
+        forced: false,
+      });
+      expect(result).toContain("Already up to date");
+      expect(result).toContain("| **Method** | brew |");
+      expect(result).toContain("| **Channel** | stable |");
+    });
+  });
+});