LUA Error after 1.15.8 release #94
Description
This happens because function CSC_GetTalentInfo(tabIndex, talentIndex) returns nil when trying to calculate spell rank from talents. Happens during loading screen as the talent tree hasn't been loaded yet. Once loaded an the talent tree has been opened it updates with no problems. For me I added safety check every time CSC_GetTalentInfo is called and even listen to PLAYER_TALENT_UPDATE event to update it automatically. This error pops up when i enter with my Priest, Mage and Warlock, and the class function errors:
==============================Warlock==========================================
1x ...cterStatsClassic/CharacterStatsClassicClassUtils.lua:97: attempt to perform arithmetic on local 'spellRank' (a nil value)
[CharacterStatsClassic/CharacterStatsClassicClassUtils.lua]:97: in function 'CSC_GetWarlockSpellHitFromTalents'
[CharacterStatsClassic/CharacterStatsClassicUtils.lua]:847: in function 'CSC_PaperDollFrame_SetSpellHitChance'
[CharacterStatsClassic/CharacterStatsClassicUI.lua]:119: in function 'SetCharacterStats'
[CharacterStatsClassic/CharacterStatsClassicUI.lua]:141: in function 'UpdateStats'
[CharacterStatsClassic/CharacterStatsClassicUI.lua]:136: in function 'CreateMenu'
[CharacterStatsClassic/CharacterStatsClassicUI.lua]:324: in function <...ns/CharacterStatsClassic/CharacterStatsClassicUI.lua:320>
Locals:
afflictionHit = 0
spellRank = nil
(*temporary) = 5
(*temporary) = nil
(*temporary) = 1
(*temporary) = 1
(*temporary) = "attempt to perform arithmetic on local 'spellRank' (a nil value)"
==============================Warlock==========================================
==============================Mage==========================================
1x ...cterStatsClassic/CharacterStatsClassicClassUtils.lua:82: attempt to perform arithmetic on local 'spellRank' (a nil value)
[CharacterStatsClassic/CharacterStatsClassicClassUtils.lua]:82: in function 'CSC_GetMageSpellHitFromTalents'
[CharacterStatsClassic/CharacterStatsClassicUtils.lua]:842: in function 'CSC_PaperDollFrame_SetSpellHitChance'
[CharacterStatsClassic/CharacterStatsClassicUI.lua]:119: in function 'SetCharacterStats'
[CharacterStatsClassic/CharacterStatsClassicUI.lua]:141: in function 'UpdateStats'
[CharacterStatsClassic/CharacterStatsClassicUI.lua]:136: in function 'CreateMenu'
[CharacterStatsClassic/CharacterStatsClassicUI.lua]:324: in function <...ns/CharacterStatsClassic/CharacterStatsClassicUI.lua:320>
Locals:
arcaneHit = 0
frostFireHit = 0
spellRank = nil
(*temporary) = 5
(*temporary) = nil
(*temporary) = 1
(*temporary) = 2
(*temporary) = nil
(*temporary) = "attempt to perform arithmetic on local 'spellRank' (a nil value)"
==============================Mage==========================================
==============================Priest==========================================
4x ...cterStatsClassic/CharacterStatsClassicClassUtils.lua:119: attempt to compare number with nil
[CharacterStatsClassic/CharacterStatsClassicClassUtils.lua]:119: in function 'CSC_GetPriestCritStatsFromTalents'
[CharacterStatsClassic/CharacterStatsClassicUtils.lua]:713: in function 'CSC_PaperDollFrame_SetSpellCritChance'
[CharacterStatsClassic/CharacterStatsClassicUI.lua]:118: in function 'SetCharacterStats'
[CharacterStatsClassic/CharacterStatsClassicUI.lua]:141: in function 'UpdateStats'
[CharacterStatsClassic/CharacterStatsClassicUI.lua]:136: in function 'CreateMenu'
[CharacterStatsClassic/CharacterStatsClassicUI.lua]:324: in function <...ns/CharacterStatsClassic/CharacterStatsClassicUI.lua:320>
Locals:
holySpecializationCrit = 0
forceOfWillCrit = 0
critTable =
1 = 1
2 = 2
3 = 3
4 = 4
5 = 5
}
spellRank = nil
(*temporary) = 5
(*temporary) = nil
(*temporary) = 2
(*temporary) = 3
(*temporary) = nil
(*temporary) = "attempt to compare number with nil"
4x ...cterStatsClassic/CharacterStatsClassicClassUtils.lua:119: attempt to compare number with nil
[CharacterStatsClassic/CharacterStatsClassicClassUtils.lua]:119: in function 'CSC_GetPriestCritStatsFromTalents'
[CharacterStatsClassic/CharacterStatsClassicUtils.lua]:713: in function 'CSC_PaperDollFrame_SetSpellCritChance'
[CharacterStatsClassic/CharacterStatsClassicUI.lua]:118: in function 'SetCharacterStats'
[CharacterStatsClassic/CharacterStatsClassicUI.lua]:141: in function 'UpdateStats'
[CharacterStatsClassic/CharacterStatsClassicUI.lua]:136: in function 'CreateMenu'
[CharacterStatsClassic/CharacterStatsClassicUI.lua]:324: in function <...ns/CharacterStatsClassic/CharacterStatsClassicUI.lua:320>
Locals:
holySpecializationCrit = 0
forceOfWillCrit = 0
critTable =
1 = 1
2 = 2
3 = 3
4 = 4
5 = 5
}
spellRank = nil
(*temporary) = 5
(*temporary) = nil
(*temporary) = 2
(*temporary) = 3
(*temporary) = nil
(*temporary) = "attempt to compare number with nil"
==============================Priest==========================================
==============================Hit, MP5 etc...==========================================
2x ...CharacterStatsClassic/CharacterStatsClassicUtils.lua:723: attempt to compare number with nil
[CharacterStatsClassic/CharacterStatsClassicUtils.lua]:723: in function 'CSC_PaperDollFrame_SetSpellCritChance'
[CharacterStatsClassic/CharacterStatsClassicUI.lua]:118: in function 'SetCharacterStats'
[CharacterStatsClassic/CharacterStatsClassicUI.lua]:141: in function 'UpdateStats'
[CharacterStatsClassic/CharacterStatsClassicUI.lua]:136: in function 'CreateMenu'
[CharacterStatsClassic/CharacterStatsClassicUI.lua]:324: in function <...ns/CharacterStatsClassic/CharacterStatsClassicUI.lua:320>
Locals:
statFrame = Frame {
arcaneCrit = 0
Label = FontString {
}
frostCrit = 0
holyCrit = 0
fireCrit = 0
Value = FontString {
}
Background = Texture {
}
shadowCrit = 0
natureCrit = 0
}
unit = "player"
MAX_SPELL_SCHOOLS = 7
holySchool = 2
maxSpellCrit = 0
unitClassId = 9
destructionCrit = nil
(*temporary) = nil
(*temporary) = 5
(*temporary) = nil
(*temporary) = 3
(*temporary) = 7
(*temporary) = nil
(*temporary) = "attempt to compare number with nil"
1x ...cterStatsClassic/CharacterStatsClassicClassUtils.lua:268: attempt to perform arithmetic on local 'spellRank' (a nil value)
[CharacterStatsClassic/CharacterStatsClassicClassUtils.lua]:268: in function 'CSC_GetMP5ModifierFromTalents'
[CharacterStatsClassic/CharacterStatsClassicUtils.lua]:1106: in function 'CSC_PaperDollFrame_SetManaRegen'
[CharacterStatsClassic/CharacterStatsClassicUI.lua]:117: in function 'SetCharacterStats'
[CharacterStatsClassic/CharacterStatsClassicUI.lua]:141: in function 'UpdateStats'
[CharacterStatsClassic/CharacterStatsClassicUI.lua]:136: in function 'CreateMenu'
[CharacterStatsClassic/CharacterStatsClassicUI.lua]:324: in function <...ns/CharacterStatsClassic/CharacterStatsClassicUI.lua:320>
Locals:
unit = "player"
unitClassId = 11
spellRank = nil
(*temporary) = nil
(*temporary) = 5
(*temporary) = nil
(*temporary) = 3
(*temporary) = 6
(*temporary) = "attempt to perform arithmetic on local 'spellRank' (a nil value)"
==============================Hit, MP5 etc...==========================================