Hunter Critical Strike

[DustinChecketts]

I believe something is amiss with your calculations of Hunter Critical Strike in the Ranged pane. I a modestly geared Hunter, and everything has seemed to be fine with your addon with my Hunter and several other of my characters. However, I recently picked up Mandokir's Sting from ZG, as a considered replacement for Blastershot Launcher on my Hunter.

Skipping to the details, when naked (NOTHING else equipped, no buffs, no quiver or ammo pouch) I equip my Blastershot launcher and my Critical Strike is calculated at 8.46%. I have 5% from talents (Lethal Shots, that isn't added in until a ranged weapon isn't equipped), but the weapon only provides 1% critical strike chance, not 3.46%. So I would expect this to be 6%.

Meanwhile, Mandokir's Sting has +11 Agility, which I would expect to translate to some small amount of Critical Strike chance (roughly 0.4% (rounded up to the nearest tenth of a percent) if 29 Agility is equal to 1% Critical Strike chance). Again, with NOTHING else equipped, your addon shows only 5% Critical Strike in the Ranged pane. I would expect this to read approximately 5.4%.

Unless there are some hidden attributes of each weapon that affects things, I'm very confused since removing your addon still shows some oddities with these weapons in particular. I'll have to find some other ranged weapons to further test.

[getov]

Thanks for the report. I am only showing what Blizzard functions return. But if I have time I can dig more into that. Sadly I don't have a hunter to test that particular case.

[DustinChecketts]

I'm going to do some more testing today. But to follow up with more information, I found that my Bow Weapon Skill was only at 225 vs 300 on my Guns and Crossbows, so I'm thinking that has something to do with it. I had a BWL raid last night, so I couldn't play with it much, but I'll look at it more closely today after reaching 300 Weapon Skill in bows and see if it still looks wrong.

Good to know that you're just returning what Blizzard functions show. Might shed some light on how I can better optimize my gear and not just trust anything I see that someone says is BiS. Appreciate Addon developers such as yourself! Keep it up!

[getov]

Yeah, usually weapon skill also increases crit as far as I know. Might have something to do with it.

[DustinChecketts]

So I think the Weapon Skill was the issue. Things now appear to add up. The one additional comment I'll make is the deceptiveness of the Damage: stat displayed. This simply displays the damage capable of the weapon and doesn't take into consideration the weapon speed, or DPS. You must hover over this stat to get the DPS. I strongly feel that the weapon DPS should be displayed initially, without a hover, in order to compare weapons more quickly and generally.

Personally, I think you could replace the Damage: stat with DPS. Alternatively, you could make it customizable with a click on the stat itself, rotating through the various Damage: details found when hovering.

Just some feedback to consider. Again, I appreciate addon developers and how they continue to make valuable data more readily available to players.

[Gogo1951]

I don't know the code super well, but just looking at this... https://github.com/getov/CharacterStatsClassic/blob/master/CharacterStatsClassicClassUtils.lua

I don't see any code that is specific to hunters. Every other class, but not hunters. I suspect that's a problem.

Suggest adding some sort of section headers to this code to make it really dummy proof. (=

---------------------------------------------------
-- TALENT INDEX MAPPING / CORE HELPERS
---------------------------------------------------

g_TalentsIndexMap = nil

CSC_GenerateTalentsIndexMap = function()
    if g_TalentsIndexMap then
        return
    end

    local talentsIndexMap = {}
    for tab = 1, 3 do
        local tierColumn = {}
        local maxTier = 0
        local numTalents = GetNumTalents(tab)
        if not numTalents or numTalents <= 0 then
            return
        end

        -- Build tier/column -> wowIdx mapping
        for idx = numTalents, 1, -1 do
            local _, _, tier, column = GetTalentInfo(tab, idx)
            tierColumn[tier] = tierColumn[tier] or {}
            tierColumn[tier][column] = idx
            maxTier = tier > maxTier and tier or maxTier
        end

        if maxTier == 0 then
            return
        end

        local oldIdx = 1
        talentsIndexMap[tab] = {}

        -- Flatten tier/column layout into a stable linear index
        for tier = 1, maxTier do
            for column = 1, 4 do
                local wowIdx = tierColumn[tier][column]
                if wowIdx then
                    talentsIndexMap[tab][oldIdx] = wowIdx
                    oldIdx = oldIdx + 1
                end
            end
        end
    end

    g_TalentsIndexMap = talentsIndexMap
    -- print("Generated Talents Index Map...")
end

-- Wrapper over GetTalentInfo that understands our synthetic
-- linear talent indices generated above.
function CSC_GetTalentInfo(tabIndex, talentIndex)
    if not g_TalentsIndexMap then
        return GetTalentInfo(tabIndex, talentIndex)
    end

    local newTalentIndex = g_TalentsIndexMap[tabIndex] and g_TalentsIndexMap[tabIndex][talentIndex]

    if not newTalentIndex then
        return GetTalentInfo(tabIndex, talentIndex)
    end

    return GetTalentInfo(tabIndex, newTalentIndex)
end

---------------------------------------------------
-- SAFE TALENT RANK HELPERS
---------------------------------------------------

local function CSC_SafeTalentRank(tabIndex, talentIndex, maxRank)
    local _, _, _, _, rank = CSC_GetTalentInfo(tabIndex, talentIndex)

    if type(rank) ~= "number" then
        rank = 0
    end

    if rank < 0 then
        rank = 0
    end

    if maxRank and rank > maxRank then
        rank = maxRank
    end

    return rank
end

local function CSC_GetTalentRankByName(tabIndex, talentName)
    if not talentName then
        return 0
    end

    local numTalents = GetNumTalents(tabIndex)
    if not numTalents or numTalents <= 0 then
        return 0
    end

    for wowIdx = 1, numTalents do
        local name, _, _, _, rank = GetTalentInfo(tabIndex, wowIdx)
        if name == talentName then
            if type(rank) ~= "number" then
                return 0
            end
            if rank < 0 then
                rank = 0
            end
            return rank
        end
    end

    return 0
end

---------------------------------------------------
-- DRUID
---------------------------------------------------

function CSC_GetShapeshiftForm()
    local shapeIndex = 0

    for possibleForm = 1, GetNumShapeshiftForms() do
        if select(2, GetShapeshiftFormInfo(possibleForm)) then
            shapeIndex = possibleForm
        end
    end

    return shapeIndex
end

---------------------------------------------------
-- HUNTER
---------------------------------------------------

-- TODO

---------------------------------------------------
-- MAGE
---------------------------------------------------

-- returns additional spell crit % from Arcane Instability and Critical Mass
function CSC_GetMageCritStatsFromTalents()
    local arcaneInstabilityCrit = 0
    local criticalMassCrit = 0

    -- Arcane Instability (1, 2, 3)%
    local arcaneInstabilityTable = {1, 2, 3}
    local arcaneInstabilityRank = CSC_SafeTalentRank(1, 15, 3)

    if arcaneInstabilityRank > 0 then
        arcaneInstabilityCrit = arcaneInstabilityTable[arcaneInstabilityRank]
    end

    -- Critical Mass (2, 4, 6)%
    local criticalMassTable = {2, 4, 6}
    local criticalMassRank = CSC_SafeTalentRank(2, 13, 3)

    if criticalMassRank > 0 then
        criticalMassCrit = criticalMassTable[criticalMassRank]
    end

    return arcaneInstabilityCrit, criticalMassCrit
end

-- returns spell hit from Arcane Focus and Elemental Precision talents
function CSC_GetMageSpellHitFromTalents()
    local arcaneHit = 0
    local frostFireHit = 0

    -- Arcane Focus: 2% hit per point
    local arcaneFocusRank = CSC_SafeTalentRank(1, 2)
    arcaneHit = arcaneFocusRank * 2

    -- Elemental Precision: 2% hit per point
    local elementalPrecisionRank = CSC_SafeTalentRank(3, 3)
    frostFireHit = elementalPrecisionRank * 2

    return arcaneHit, frostFireHit
end

---------------------------------------------------
-- PALADIN
---------------------------------------------------

-- returns the crit bonus from Holy Power
function CSC_GetPaladinCritStatsFromTalents()
    -- Holy Power (1, 2, 3, 4, 5)% – rank == crit%
    local spellRank = CSC_SafeTalentRank(1, 13, 5)
    return spellRank
end

-- returns the defense bonus from the Anticipation Prot talent
local function CSC_GetPaladinDefenseFromTalents()
    local defense = 0
    local defenseTable = {2, 4, 6, 8, 10}

    -- Anticipation (2, 4, 6, 8, 10) defense
    local spellRank = CSC_SafeTalentRank(2, 9, 5)
    if spellRank > 0 then
        defense = defenseTable[spellRank]
    end

    return defense
end

-- returns the modifier from Improved Blessing of Wisdom Holy talent
function CSC_GetPaladinImprovedBoWModifier()
    -- Improved Blessing of Wisdom: +10% per point
    local spellRank = CSC_SafeTalentRank(1, 10, 2)
    return spellRank * 0.1
end

-- Checks if spellId is Blessing of Wisdom (regular or greater)
function CSC_IsBoWSpellId(spellId)
    if
        (spellId == 19742 or spellId == 19850 or spellId == 19852 or spellId == 19853 or spellId == 19854 or
            spellId == 25290 or
            spellId == 25894 or
            spellId == 25918)
     then
        return true
    end

    return false
end

---------------------------------------------------
-- PRIEST
---------------------------------------------------

-- returns the combined crit stats from Holy Specialization and Force of Will
function CSC_GetPriestCritStatsFromTalents()
    local holySpecializationCrit = 0
    local forceOfWillCrit = 0

    local critTable = {1, 2, 3, 4, 5}

    -- Holy Specialization (1, 2, 3, 4, 5)% – Holy tree
    local holySpecRank = CSC_SafeTalentRank(2, 3, 5)
    if holySpecRank > 0 then
        holySpecializationCrit = critTable[holySpecRank]
    end

    -- Force of Will (1, 2, 3, 4, 5)% – Discipline tree
    local forceOfWillRank = CSC_SafeTalentRank(1, 14, 5)
    if forceOfWillRank > 0 then
        forceOfWillCrit = critTable[forceOfWillRank]
    end

    local critCombined = holySpecializationCrit + forceOfWillCrit
    return critCombined
end

-- returns the healing modifier from Spiritual Healing talent for Priests
function CSC_GetPriestBonusHealingModifierFromTalents()
    -- Spiritual Healing: +2% per point
    local spellRank = CSC_SafeTalentRank(2, 15, 5)
    return spellRank * 0.02
end

---------------------------------------------------
-- SHAMAN
---------------------------------------------------

-- returns the bonus hit from Nature's Guidance talent (counts as melee and spell hit)
function CSC_GetShamanHitFromTalents()
    -- Nature's Guidance – Restoration tree
    local spellRank = CSC_SafeTalentRank(3, 6, 3)
    return spellRank
end

-- returns the bonus crit from the Call of Thunder talent for Shamans
function CSC_GetShamanCallOfThunderCrit()
    local bonusCrit = 0
    local talentTable = {1, 2, 3, 4, 6}

    -- Call of Thunder (Lightning)
    local spellRank = CSC_SafeTalentRank(1, 8, 5)
    if spellRank > 0 then
        bonusCrit = talentTable[spellRank]
    end

    return bonusCrit
end

-- returns the bonus crit from the Tidal Mastery talent for Shamans
function CSC_GetShamanTidalMasteryCrit()
    -- Tidal Mastery (Nature/Lightning): +1% crit per rank
    local spellRank = CSC_SafeTalentRank(3, 11, 5)
    return spellRank
end

---------------------------------------------------
-- WARLOCK
---------------------------------------------------

-- returns the spell hit from Suppression talent
function CSC_GetWarlockSpellHitFromTalents()
    local afflictionHit = 0

    -- Suppression – +2% hit per point
    local spellRank = CSC_SafeTalentRank(1, 1, 5)
    afflictionHit = spellRank * 2

    return afflictionHit
end

-- returns the spell crit from Devastation talent
function CSC_GetWarlockCritStatsFromTalents()
    -- Devastation – rank equals crit%
    local devastationCrit = CSC_SafeTalentRank(3, 7, 5)
    return devastationCrit
end

---------------------------------------------------
-- WARRIOR
---------------------------------------------------

-- returns the defense bonus from the Anticipation Prot talent
local function CSC_GetWarriorDefenseFromTalents()
    local defense = 0
    local defenseTable = {2, 4, 6, 8, 10}

    -- Anticipation (2, 4, 6, 8, 10) defense
    local spellRank = CSC_SafeTalentRank(3, 2, 5)
    if spellRank > 0 then
        defense = defenseTable[spellRank]
    end

    return defense
end

---------------------------------------------------
-- CROSS-CLASS TALENT HELPERS
---------------------------------------------------

function CSC_GetDefenseFromTalents(unit)
    local defense = 0
    local unitClassId = select(3, UnitClass(unit))

    if (unitClassId == CSC_PALADIN_CLASS_ID) then
        defense = CSC_GetPaladinDefenseFromTalents()
    elseif (unitClassId == CSC_WARRIOR_CLASS_ID) then
        defense = CSC_GetWarriorDefenseFromTalents()
    end

    return defense
end

-- ITEMS AND ENCHANTS RELATED
function CSC_GetMP5ModifierFromTalents(unit)
    local unitClassId = select(3, UnitClass(unit))
    local spellRank = 0

    if unitClassId == CSC_PRIEST_CLASS_ID then
        -- Meditation (Priest)
        spellRank = CSC_SafeTalentRank(1, 8, 3)
    elseif unitClassId == CSC_MAGE_CLASS_ID then
        -- Arcane Meditation (Mage)
        spellRank = CSC_SafeTalentRank(1, 12, 3)
    elseif unitClassId == CSC_DRUID_CLASS_ID then
        -- Reflection (Druid)
        spellRank = CSC_SafeTalentRank(3, 6, 3)
    end

    local modifier = spellRank * 0.05
    return modifier
end

function CSC_GetMP5ModifierFromSetBonus(unit)
    local unitClassId = select(3, UnitClass(unit))
    local modifier = 0

    -- Only Druid or Priest get this particular set bonus
    if unitClassId ~= CSC_DRUID_CLASS_ID and unitClassId ~= CSC_PRIEST_CLASS_ID then
        return modifier
    end

    local firstItemslotIndex = 1
    local lastItemslotIndex = 18

    local equippedSetItems = 0
    for itemSlot = firstItemslotIndex, lastItemslotIndex do
        local itemId = GetInventoryItemID(unit, itemSlot)

        if (itemId) then
            if (itemId == g_VestmentsOfTranscendenceIds[itemId] or itemId == g_StormrageRaimentIds[itemId]) then
                equippedSetItems = equippedSetItems + 1
            end
        end
    end

    if equippedSetItems >= 3 then
        modifier = 0.15
    end

    return modifier
end

function CSC_GetShamanT2SpellCrit(unit)
    local spellCritFromSet = 0
    local firstItemslotIndex = 1
    local lastItemslotIndex = 18

    local equippedSetItems = 0
    for itemSlot = firstItemslotIndex, lastItemslotIndex do
        local itemId = GetInventoryItemID(unit, itemSlot)

        if (itemId) then
            if (itemId == g_TheTenStormsIds[itemId]) then
                equippedSetItems = equippedSetItems + 1
            end
        end
    end

    if equippedSetItems >= 5 then
        spellCritFromSet = 3
    end

    return spellCritFromSet
end

function CSC_GetHolyCritFromBenediction(unit)
    local benedictionCrit = 0
    local itemId = GetInventoryItemID(unit, INVSLOT_MAINHAND)

    if itemId == 18608 then
        benedictionCrit = 2
    end

    return benedictionCrit
end

function CSC_GetBlockValueFromWarriorZGEnchants(unit)
    local blockValue = 0

    if CSC_HasEnchant(unit, INVSLOT_HEAD, 2583) then
        blockValue = blockValue + 15
    end

    if CSC_HasEnchant(unit, INVSLOT_LEGS, 2583) then
        blockValue = blockValue + 15
    end

    return blockValue
end

function CSC_GetMp5FromPriestZGEnchants(unit)
    local mp5 = 0

    if CSC_HasEnchant(unit, INVSLOT_HEAD, 2590) then
        mp5 = mp5 + 4
    end

    if CSC_HasEnchant(unit, INVSLOT_LEGS, 2590) then
        mp5 = mp5 + 4
    end

    return mp5
end