[frontend] if users/current returns 500, user is logged out

[alxndrsn]

Expected

500 response implies a problem in the server, not with the information submitted by the client. A 500 response to /v1/sessions/current should not log the user out.

Code

Maybe some more nuanced handling at https://github.com/getodk/central-frontend/blob/06ce7fdae3360fe0cb8b96f236a887442f56c34f/src/util/session.js#L263-L274 would help.

Related

• [frontend] if sessions/restore returns 500, user sent to login screen #1544
• Show alert if request to restore session results in 500 error #1092

[matthew-white]

There are two times that Frontend sends a request to /v1/users/current, i.e., there are two opportunities for the request to fail:

1. During the initial navigation of the router (after a successful response for /v1/sessions/restore, but before anything is shown on screen)
2. After a successful response to POST /v1/sessions, on the login page
   • You managed to create a session, but then we couldn't get other essential information in order to proceed. E.g., without /v1/users/current, we don't know what verbs you have.

Given that getodk/central-backend#1602 is on the way, I think case (1) will soon be the same as #1544 (because /v1/sessions/restore and /v1/users/current will be combined). That is, whatever we decide for #1544 should apply to case (1).

Case (2) I'm less certain about. Hopefully it's pretty uncommon! Right now, I think you stay on the login page, where you should see an error message in a toast. You should be able to try again to log in.

[alxndrsn]

1. During the initial navigation of the router

Does this mean: on page-load for an authenticated user?

E.g. open a new browser tab at https://staging.getodk.cloud/ for a logged-in user, and the following API calls are made: