Skip to content

Programmatically skipped steps which generate a skip are not highlighted as skipped in the report #320

@chadlwilson

Description

@chadlwilson

Expected behavior

As noted in getgauge/gauge-python#397, when programmatically skipping scenarios ( getgauge/gauge#2502 ) from a step or a hook, ideally it should be clear from the report which step generated the skip instruction.

Actual behavior

Currently the step shows as passed.

Steps to reproduce

  1. Use a gauge-dotnet or gauge-python project which has a step which throws/raises a SkipScenarioException
  2. View the html-report for that scenario
  3. Note that the step that generated the skip is passed, even though the scenario is shown as skipped.

It might be sufficient to change the code below

func getStepStatus(res *gm.ProtoStepExecutionResult) status {
if res.GetSkipped() {
return skip
}
if res.GetExecutionResult() == nil {
return notExecuted
}
if res.GetExecutionResult().GetFailed() {
return fail
}
return pass
}

and add the below after checking the executionResult however needs to be validated as to what it looks like and whether it displays in a way that is clear as to the reason the step is skipped since skips can be done for multiple reasons.

	if res.GetExecutionResult().GetSkipScenario() {
		return skip
	}

Gauge version

$ gauge -v
Gauge version: 1.6.9
Commit Hash: aff43ef

Plugins
-------
dotnet (0.7.2)
html-report (4.3.1)
python (0.4.7)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions