-
Notifications
You must be signed in to change notification settings - Fork 41
Open
Description
Expected behavior
As noted in getgauge/gauge-python#397, when programmatically skipping scenarios ( getgauge/gauge#2502 ) from a step or a hook, ideally it should be clear from the report which step generated the skip instruction.
Actual behavior
Currently the step shows as passed.
Steps to reproduce
- Use a gauge-dotnet or gauge-python project which has a step which throws/raises a
SkipScenarioException - View the html-report for that scenario
- Note that the step that generated the skip is passed, even though the scenario is shown as skipped.
It might be sufficient to change the code below
html-report/generator/transform.go
Lines 619 to 630 in 19ee5a6
| func getStepStatus(res *gm.ProtoStepExecutionResult) status { | |
| if res.GetSkipped() { | |
| return skip | |
| } | |
| if res.GetExecutionResult() == nil { | |
| return notExecuted | |
| } | |
| if res.GetExecutionResult().GetFailed() { | |
| return fail | |
| } | |
| return pass | |
| } |
and add the below after checking the executionResult however needs to be validated as to what it looks like and whether it displays in a way that is clear as to the reason the step is skipped since skips can be done for multiple reasons.
if res.GetExecutionResult().GetSkipScenario() {
return skip
}Gauge version
$ gauge -v
Gauge version: 1.6.9
Commit Hash: aff43ef
Plugins
-------
dotnet (0.7.2)
html-report (4.3.1)
python (0.4.7)
sschulz92
Metadata
Metadata
Assignees
Labels
No labels