Skip to content

[Enhancement] Get rid of all unwrap, expect and panic outside test code #463

@Davidson-Souza

Description

@Davidson-Souza

Describe the enhancement

Since we are a lib, we shouldn't panic on behalf of our users. They should be notified that something wrong happened, and decide whether to panic or not. For that reason, I suggest we remove all call to unwrap, expect and panic that are not test code. Then add CI checks to deny them being reintroduced.

Use case

This makes the life of the api consumers easier, since panics arriving inside our code are hard to debug by them. This creates some difficulty on our side (panic'in and calling it a day is way easier than making sure you propagate errors in a sane way), but makes lives of upstream coders way better.

Metadata

Metadata

Assignees

No one assigned

    Labels

    good first issueGood for newcomersreliabilityRelated to runtime reliability, stability and production readiness

    Type

    Projects

    Status

    Backlog

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions