From fdc2b292f2d6ec236ea39c1d49ac6b9613c2e91b Mon Sep 17 00:00:00 2001 From: LarytheLord Date: Wed, 25 Feb 2026 21:57:12 +0530 Subject: [PATCH] printer: include finding location in GitHub Actions messages --- pkg/printer/githubactions.go | 7 ++++++- pkg/printer/githubactions_test.go | 4 ++-- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/pkg/printer/githubactions.go b/pkg/printer/githubactions.go index c16b82e2..0c54538e 100644 --- a/pkg/printer/githubactions.go +++ b/pkg/printer/githubactions.go @@ -38,12 +38,17 @@ func (p *GitHubActions) End() { } func formatResultForGitHubAction(r result.Result) string { + location := fmt.Sprintf("%s:%d:%d: ", + r.GetStartPosition().Filename, + r.GetStartPosition().Line, + r.GetStartPosition().Column) + return fmt.Sprintf("::%s file=%s,line=%d,col=%d::%s", translateSeverityForAction(r.GetSeverity()), r.GetStartPosition().Filename, r.GetStartPosition().Line, r.GetStartPosition().Column, - r.Reason()) + location+r.Reason()) } func translateSeverityForAction(s rule.Severity) string { diff --git a/pkg/printer/githubactions_test.go b/pkg/printer/githubactions_test.go index 8e2e55da..597d11a9 100644 --- a/pkg/printer/githubactions_test.go +++ b/pkg/printer/githubactions_test.go @@ -30,7 +30,7 @@ func TestFormatResultForGitHubAction(t *testing.T) { }, } got := formatResultForGitHubAction(&testResult) - assert.Equal(t, "::warning file=my/file,line=5,col=3::"+testResult.Rule.Reason(testResult.Finding), got) + assert.Equal(t, "::warning file=my/file,line=5,col=3::my/file:5:3: "+testResult.Rule.Reason(testResult.Finding), got) } func TestTranslateSeverityForAction(t *testing.T) { @@ -51,7 +51,7 @@ func TestGitHubActions_Print(t *testing.T) { res := generateFileResult() assert.NoError(t, p.Print(res)) got := buf.String() - expected := fmt.Sprintf("::warning file=foo.txt,line=1,col=6::%s\n", res.Results[0].Reason()) + expected := fmt.Sprintf("::warning file=foo.txt,line=1,col=6::foo.txt:1:6: %s\n", res.Results[0].Reason()) assert.Equal(t, expected, got) }