Psuedo mods are not being handled properly

[gerwaric]

Right now acquisition is not creating psuedo mods, e.g. by adding chaos resistance from two different mods.

[wallacrs]

Not sure if this is the right place to comment, but I'm very very keen for the pseudo mods to be re-implemented please!
The old Acquisition v10 had the mods hardcoded in modlist.cpp and it made it easy for me in a custom compiled version to add extra psuedo mods like "+# Total Elemental Resistance", which was something I used all the time when checking my SSF stash for items that would cover resistance or stat requirememts.
In general I think the new mod list is too long and has too many niche entries, but adding pseudo mods back would be incredibly useful.
Thanks!

[gerwaric]

This is the perfect place to comment, and pseudo-mod support has been bugging me as well.

I'm not even sure when pseudo-mods stopped working. It might be something I broke myself when I started working on acquisition (before I knew what I was doing), which would have been around v0.9, but it might have been broken for longer.

The mod processing is also part of the oldest and most complicated part of the code base that I still haven't wrapped my head around completely. I've been reluctant to address it because the whole core of acquisition could use a rewrite, but I'll take another look. It's such a basic feature.

I also do want to support the full list, because it will include things like cluster jewel notables and other random modifiers that might suddenly become important for certain leagues/expansions/meta shifts. But I think this means improving the modifier search dropdown, because right now it's slow and doesn't support partial matches like "~" does on the trade site.

[gerwaric]

@wallacrs I dug into the code history. It looks like the old pseudo-mod code was removed in v0.9.0, which is before my time.

I'm going to see if I can find a way to bring it back.

I also have an idea of how to improve the search mod text entry matching, but that will be a little trickier.

[wallacrs]

Thanks very much for looking into this, and for generally keeping Acquisition up and running! I use it all the time for self-stash searching, don't know what I would do without it!
My hack for pseudo mods in my self-compiled version of 10.2 was to add rows to the "simple_sum" vector in modlist.cpp and just add all the mods in the comma-separated list e.g. put every (common) mod that adds a resistance in a row, like:
{ "+#% to Total Elemental Resistance", "+#% to Cold Resistance", "+#% to Lightning Resistance", "+#% to Cold and Lightning Resistances", "+#% to Fire and Lightning Resistances", "+#% to all Elemental Resistances", ... }
What I really wanted was to have a text-based file that could be read and turned into the modlist simple_sum vector so I could edit the list without recompiling each time, but my coding skills aren't good enough!

[gerwaric]

I checked with novynn, and he confirmed that acquisition will have to do it's own pseudo-mod calculations, because there's no public information about how they are calculated, and they are sometimes derived from non-publicly exposed data.

So far I've found 3 different kinds of pseudo-mods:

1. Simple sum like "+#% to total Fire Resistance" and the others hard-coded in modlist.cpp
2. Pseudo-mods that count things, like "# total Resistances" and "# Prefix Modifiers"
3. More complicated calculations like "+# total to all Attributes", which is the minimum of "+# total to Strength", "+# total to Dexterity", and "+# total to Intelligence" but only if that all three of those pseudo-mods exists.

There are likely others, e.g. for timeless jewels, but I want to get the simple summing pseudo mods implemented first, since they are the most common and acquisition used to support them.

This also relates to the tricky problem of what list of modifiers to use. There are at least three sources that I know of:

1. The trade stat modifiers listed in https://www.pathofexile.com/api/trade/data/stats
2. Stat translations from the poe data files, e.g. https://repoe-fork.github.io/stat_translations.min.json
3. The actual text of the modifiers in the item json.

Unfortunately, they aren't all identical, so I'm tempted to fall back on the actual modifiers in the item json, with additional hard-coded pseudo mods, but this means that searching in acquisition won't be quite the same as searching on the trade site.

[wallacrs]

Just installed the new 15.0 release, thanks so much for adding the pseduo-mod stuff so quickly! Awesome!

[gerwaric]

Thank you.

I can already see that it will take a couple of passes to get the mod searching to where I think it should be, but I'm happy I was able to some of the most useful basics working.