From 84b4e4f32177dd9ebde173e87d96f6e64f7909db Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Thu, 5 Jan 2023 22:46:14 +0000 Subject: [PATCH] Adding tarfile member sanitization to extractall() --- resolwe_runtime_utils.py | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/resolwe_runtime_utils.py b/resolwe_runtime_utils.py index 8af77a5..67f812c 100644 --- a/resolwe_runtime_utils.py +++ b/resolwe_runtime_utils.py @@ -726,7 +726,26 @@ def import7z(): if extracted_name.endswith('.tar'): with tarfile.open(extracted_name) as tar: - tar.extractall() + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner) + + + safe_extract(tar) os.remove(extracted_name) destination_name, _ = os.path.splitext(extracted_name)