Skip to content

Mitigate tmp/ disk leakage #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MarcFraile wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Mitigate tmp/ disk leakage #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/main/java/cloudgene/mapred/jobs/JobParameterParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,8 @@ public static Map<String, String> parse(List<FormUtil.Parameter> form, WdlApp ap
if (input.getWriteFile() != null && !input.getWriteFile().trim().isEmpty()) {

File file = Files.createTempFile("upload_", input.getWriteFile()).toFile();
file.deleteOnExit();

try {
FileUtil.writeStringBufferToFile(file.getAbsolutePath(), new StringBuffer(cleanedValue));
String target = workspace.uploadInput(key, file);
Expand Down
2 changes: 2 additions & 0 deletions src/main/java/cloudgene/mapred/server/controller/JobController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,9 @@ public Publisher<HttpResponse<Object>> submit(Authentication authentication, Htt
String userAgent = request.getHeaders().get(HttpHeaders.USER_AGENT);

long start = System.currentTimeMillis();

File folder = application.getSettings().getTempFolder("upload_");
folder.deleteOnExit();

log.debug("Start submit process and parse multipart body. Folder for request: " + folder.getAbsolutePath());

Expand Down