Skip to content

Add 404 non-retryable test coverage for Reddit adapter #11

@gdiab

Description

@gdiab

Context

Claude re-review on PR #8 called out a small test coverage gap in the Reddit adapter tests.

Reference: #8 (comment)

Problem

src/adapters/reddit-adapter.test.ts currently covers:

  • successful fetch/parse
  • retryable 5xx failure

It does not cover a 404 response, which should be non-retryable under the current retryability rule (status >= 500 || status === 429).

Proposed change

  • Add a test case for HTTP 404 in reddit-adapter.test.ts.
  • Assert that the adapter returns an ingest failure with retryable: false for 404.

Acceptance criteria

  • A 404 test exists and passes.
  • Test clearly verifies non-retryable behavior for 404.
  • Existing adapter tests remain green.

Priority

Minor / non-blocking follow-up from PR #8.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions