From 08b95a1cb2602ca77fcb566651657e99541bd08b Mon Sep 17 00:00:00 2001
From: stertooy <5571903+stertooy@users.noreply.github.com>
Date: Sun, 16 Nov 2025 21:48:13 +0100
Subject: [PATCH 1/3] Check for absolute paths

---
 .github/workflows/CI.yml | 16 ++++++++++++++++
 action.yml               |  8 ++++++++
 check_absolute_paths.sh  |  9 +++++++++
 3 files changed, 33 insertions(+)
 create mode 100755 check_absolute_paths.sh

diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml
index 9704935..d8fe39c 100644
--- a/.github/workflows/CI.yml
+++ b/.github/workflows/CI.yml
@@ -86,3 +86,19 @@ jobs:
             Name ends with space or period: period.
             Name ends with space or period: space 
           EOF
+
+      - name: "Test check_absolute_paths.sh"
+        shell: bash
+        run: |
+          mkdir -p paths-dir
+          cd paths-dir
+          mkdir -p doc
+          echo "<a href=\"/home/runner/gap/pkg/awesomepackage/doc/chap66_mj.html#ABC123\">Link</a>" > doc/chap1_mj.html
+          echo "<a href=\"file:///home/runner/gap/pkg/awesomepackage/doc/chap66_mj.html#ABC123\">Link</a>" > doc/chap2_mj.html
+          echo "<a href=\"../../../pkg/awesomepackage/doc/chap66_mj.html#ABC123\">Link</a>" > doc/chap3_mj.html
+          ../check_absolute_paths.sh > $RUNNER_TEMP/absolute_paths_run.txt || true # suppress expected error here
+          diff $RUNNER_TEMP/absolute_paths_run.txt - <<EOF
+          ./doc/chap1_mj.html
+          ./doc/chap2_mj.html
+          EOF
+          
diff --git a/action.yml b/action.yml
index f4103ae..86a48c1 100644
--- a/action.yml
+++ b/action.yml
@@ -23,6 +23,14 @@ runs:
       shell: bash
       run: |
         gap -A -q -c 'QuitGap(ValidatePackageInfo("PackageInfo.g"));'
+        
+    - name: "Check documentation for absolute paths"
+      shell: bash
+      run: |
+        $GITHUB_ACTION_PATH/check_absolute_paths.sh || {
+          echo "::error::Found absolute paths in HTML file(s)"
+          exit 1
+        }
 
     - name: "Create assets folder"
       shell: bash
diff --git a/check_absolute_paths.sh b/check_absolute_paths.sh
new file mode 100755
index 0000000..0718acc
--- /dev/null
+++ b/check_absolute_paths.sh
@@ -0,0 +1,9 @@
+#!/usr/bin/env bash
+set -e
+set -o pipefail
+
+shopt -s globstar
+
+if grep -rlE '<a href="(file:/)?/' ./**/*.htm* ; then
+  exit 1
+fi

From b69c0b72a58411f174e392ab7bbf50bab7e3e7b1 Mon Sep 17 00:00:00 2001
From: stertooy <5571903+stertooy@users.noreply.github.com>
Date: Sun, 16 Nov 2025 22:19:37 +0100
Subject: [PATCH 2/3] Don't error if grep didn't match any files

---
 .github/workflows/CI.yml | 4 ++--
 check_absolute_paths.sh  | 4 +---
 2 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml
index d8fe39c..e9fff2a 100644
--- a/.github/workflows/CI.yml
+++ b/.github/workflows/CI.yml
@@ -93,12 +93,12 @@ jobs:
           mkdir -p paths-dir
           cd paths-dir
           mkdir -p doc
+          ../check_absolute_paths.sh > $RUNNER_TEMP/absolute_paths_run.txt # empty folder, so should not give error
           echo "<a href=\"/home/runner/gap/pkg/awesomepackage/doc/chap66_mj.html#ABC123\">Link</a>" > doc/chap1_mj.html
           echo "<a href=\"file:///home/runner/gap/pkg/awesomepackage/doc/chap66_mj.html#ABC123\">Link</a>" > doc/chap2_mj.html
           echo "<a href=\"../../../pkg/awesomepackage/doc/chap66_mj.html#ABC123\">Link</a>" > doc/chap3_mj.html
           ../check_absolute_paths.sh > $RUNNER_TEMP/absolute_paths_run.txt || true # suppress expected error here
-          diff $RUNNER_TEMP/absolute_paths_run.txt - <<EOF
+          diff <(sort $RUNNER_TEMP/absolute_paths_run.txt) - <<EOF
           ./doc/chap1_mj.html
           ./doc/chap2_mj.html
           EOF
-          
diff --git a/check_absolute_paths.sh b/check_absolute_paths.sh
index 0718acc..dfbcb20 100755
--- a/check_absolute_paths.sh
+++ b/check_absolute_paths.sh
@@ -2,8 +2,6 @@
 set -e
 set -o pipefail
 
-shopt -s globstar
-
-if grep -rlE '<a href="(file:/)?/' ./**/*.htm* ; then
+if grep -rlE '<a href="(file:/)?/' . --include='*.htm*' ; then
   exit 1
 fi

From 2d87ae2d75b93dc83cd475b5944ae0eead1246a1 Mon Sep 17 00:00:00 2001
From: stertooy <5571903+stertooy@users.noreply.github.com>
Date: Mon, 17 Nov 2025 17:41:40 +0100
Subject: [PATCH 3/3] Update .github/workflows/CI.yml

Co-authored-by: Max Horn <max@quendi.de>
---
 .github/workflows/CI.yml | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml
index e9fff2a..3523fc1 100644
--- a/.github/workflows/CI.yml
+++ b/.github/workflows/CI.yml
@@ -90,9 +90,8 @@ jobs:
       - name: "Test check_absolute_paths.sh"
         shell: bash
         run: |
-          mkdir -p paths-dir
+          mkdir -p paths-dir/doc
           cd paths-dir
-          mkdir -p doc
           ../check_absolute_paths.sh > $RUNNER_TEMP/absolute_paths_run.txt # empty folder, so should not give error
           echo "<a href=\"/home/runner/gap/pkg/awesomepackage/doc/chap66_mj.html#ABC123\">Link</a>" > doc/chap1_mj.html
           echo "<a href=\"file:///home/runner/gap/pkg/awesomepackage/doc/chap66_mj.html#ABC123\">Link</a>" > doc/chap2_mj.html