-
Notifications
You must be signed in to change notification settings - Fork 254
MAINT: Code review of command-line tool wrappers #479
Copy link
Copy link
Open
Labels
c++Items which involve writing in C++Items which involve writing in C++
Milestone
Description
Gambit's command-line tool wrappers (in src/tools) can use a thorough review, as they haven't separately been looked at in some time.
A non-exhaustive set of tasks:
- Command-line argument parsing is done by
getoptand probably has a number of bugs where what is being done and what the documentation say do not line up perfectly. - Conversion of arguments to numbers is done by old C-style functions without checking for valid values
- In places where data are read in from CSV-like files (e.g. starting points), there is no real error checking and invalid files will lead to unpredictable results.
- There is other duplicated code across the driver programs, which is less than ideal for consistency.
The output of working on this ideally should rationalise the command-line drivers and make it straightforward to expose new algorithms or features consistently. So this is definitely one for someone who understands a bit about the various equilibrium computation methods, and willing to take a bit of a deeper dive on thinking about how to organise this code (and not just a superficial set of changes).
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
c++Items which involve writing in C++Items which involve writing in C++