debugging sanity checks

Author: tturocy

src/games/game.h

@@ -209,6 +209,7 @@ class GameInfosetRep : public std::enable_shared_from_this<GameInfosetRep> {
   }
 
 public:
+  void DebugSanityCheck() const;
   using Actions = ElementCollection<GameInfoset, GameActionRep>;
   using Members = ElementCollection<GameInfoset, GameNodeRep>;
 
@@ -382,6 +383,15 @@ class GamePlayerRep : public std::enable_shared_from_this<GamePlayerRep> {
   std::vector<std::shared_ptr<GameStrategyRep>> m_strategies;
 
 public:
+  void DebugSanityCheck() const
+  {
+    if (!m_game) {
+      throw std::runtime_error("PlayerRep: m_game is null");
+    }
+    if (!m_valid) {
+      throw std::runtime_error("PlayerRep: IsValid() is false");
+    }
+  }
   using Infosets = ElementCollection<GamePlayer, GameInfosetRep>;
   using Strategies = ElementCollection<GamePlayer, GameStrategyRep>;
 
@@ -970,6 +980,24 @@ class GameRep : public std::enable_shared_from_this<GameRep> {
 #undef NDEBUG
 #include <cassert>
 
+inline void GameInfosetRep::DebugSanityCheck() const
+{
+  if (!m_game) {
+    throw std::runtime_error("InfosetRep: m_game is null");
+  }
+  if (!m_player) {
+    throw std::runtime_error("InfosetRep: m_player is null");
+  }
+  if (!m_valid) {
+    throw std::runtime_error("InfosetRep: IsValid() is false");
+  }
+
+  // Optional deeper checks:
+  if (m_player->m_game != m_game) {
+    throw std::runtime_error("InfosetRep: player->m_game mismatch");
+  }
+}
+
 class GameRep::Infosets {
 public:
   class iterator {
@@ -996,25 +1024,17 @@ class GameRep::Infosets {
 
     value_type operator*() const
     {
-      assert(inner_ != inner_end_);
-      assert(*inner_);
-      assert((*inner_)->IsValid());
-      assert((*inner_)->m_game != nullptr);
-      assert((*inner_)->m_player != nullptr);
-
+      (*inner_)->DebugSanityCheck();
+      (*inner_)->GetPlayer()->DebugSanityCheck();
       auto g = (*inner_)->GetGame();
       assert(g);                   // i.e. g != nullptr
       return GameInfoset(*inner_); // GameObjectPtr constructor
     }
 
     value_type operator->() const
     {
-      assert(inner_ != inner_end_);
-      assert(*inner_);
-      assert((*inner_)->IsValid());
-      assert((*inner_)->m_game != nullptr);
-      assert((*inner_)->m_player != nullptr);
-
+      (*inner_)->DebugSanityCheck();
+      (*inner_)->GetPlayer()->DebugSanityCheck();
       auto g = (*inner_)->GetGame();
       assert(g); // i.e. g != nullptrreturn
       return GameInfoset(*inner_);