More sign comparisons.

Author: tturocy

src/games/behavmixed.cc

@@ -94,7 +94,7 @@ void MixedBehaviorProfile<T>::RealizationProbs(const MixedStrategyProfile<T> &mp
 {
   T prob;
 
-  for (int i = 1; i <= node->m_children.size(); i++) {
+  for (size_t i = 1; i <= node->m_children.size(); i++) {
     if (node->GetPlayer() && !node->GetPlayer()->IsChance()) {
       if (node->GetPlayer() == player) {
         if (actions[node->GetInfoset()->GetNumber()] == i) {

src/games/gametree.cc

@@ -600,9 +600,9 @@ GameInfoset GameTreeNodeRep::AppendMove(GameInfoset p_infoset)
   m_efg->IncrementVersion();
   m_infoset = dynamic_cast<GameTreeInfosetRep *>(p_infoset.operator->());
   m_infoset->AddMember(this);
-  for (const auto &_ : m_infoset->m_actions) {
-    m_children.push_back(new GameTreeNodeRep(m_efg, this));
-  }
+  std::for_each(
+      m_infoset->m_actions.begin(), m_infoset->m_actions.end(),
+      [this](const GameActionRep *) { m_children.push_back(new GameTreeNodeRep(m_efg, this)); });
   m_efg->ClearComputedValues();
   m_efg->Canonicalize();
   return m_infoset;

src/solvers/linalg/lpsolve.imp

@@ -94,7 +94,7 @@ LPSolve<T>::LPSolve(const Matrix<T> &A, const Vector<T> &b, const Vector<T> &c,
   tab.SetCost(cost);
 
   // set xx to be initial feasible solution to phase II
-  for (int i = 1; i <= xx.size(); i++) {
+  for (size_t i = 1; i <= xx.size(); i++) {
     if (LB[i]) {
       xx[i] = lb[i];
     }
@@ -106,7 +106,7 @@ LPSolve<T>::LPSolve(const Matrix<T> &A, const Vector<T> &b, const Vector<T> &c,
     }
   }
   tab.BasisVector(x);
-  for (int i = 1; i <= x.size(); i++) {
+  for (size_t i = 1; i <= x.size(); i++) {
     xlab = tab.Label(i);
     if (xlab < 0) {
       xlab = nvars - xlab;
@@ -179,7 +179,7 @@ template <class T> void LPSolve<T>::Solve(int phase)
           outlab = tab.Label(out);
         }
         // update xx
-        for (int i = 1; i <= x.size(); i++) {
+        for (size_t i = 1; i <= x.size(); i++) {
           xlab = tab.Label(i);
           if (xlab < 0) {
             xlab = nvars - xlab;

src/solvers/linalg/lptab.imp

@@ -78,7 +78,7 @@ template <> void LPTableau<double>::SetCost(const Vector<double> &c)
   if (c.first_index() != cost.first_index()) {
     throw DimensionException();
   }
-  if (c.last_index() != (cost.last_index() + unitcost.size())) {
+  if (c.last_index() != static_cast<int>(cost.last_index() + unitcost.size())) {
     throw DimensionException();
   }
   for (int i = c.first_index(); i <= cost.last_index(); i++) {