removed create_el_farol_bar_game_efg and create_centipede_game_with_chance_efg from games.py

Author: rahulsavani

tests/games.py

@@ -401,26 +401,6 @@ def create_one_shot_trust_efg(unique_NE_variant: bool = False) -> gbt.Game:
     return g
 
 
-def create_centipede_game_with_chance_efg() -> gbt.Game:
-    """
-    Returns
-    -------
-    Game
-        2-player Centipede Game with 3 innings and a probability of altruism
-    """
-    return read_from_file("cent3.efg")
-
-
-def create_el_farol_bar_game_efg() -> gbt.Game:
-    """
-    Returns
-    -------
-    Game
-        5-player El Farol Bar Game
-    """
-    return read_from_file("el_farol_bar.efg")
-
-
 def create_EFG_for_nxn_bimatrix_coordination_game(n: int) -> gbt.Game:
     A = np.eye(n, dtype=int)
     B = A

tests/test_behav.py

@@ -2039,11 +2039,11 @@ def test_specific_profile(game: gbt.Game, rational_flag: bool, data: list):
             [[["1/5", "4/5"], ["3/5", "2/5"]], [["1/4", "3/4"], ["1/4", "3/4"]]],
         ),
         (
-            games.create_el_farol_bar_game_efg(),
+            games.read_from_file("el_farol_bar.efg"),
             True,
             [[4 / 9, 5 / 9], [0], [1 / 2, 1 / 2], [11 / 12, 1 / 12], [1 / 2, 1 / 2]],
         ),
-        (games.create_el_farol_bar_game_efg(), True, [[1 / 2, 1 / 2]]),
+        (games.read_from_file("el_farol_bar.efg"), True, [[1 / 2, 1 / 2]]),
         (
             games.read_from_file("mixed_behavior_game.efg"),
             False,
@@ -2060,11 +2060,11 @@ def test_specific_profile(game: gbt.Game, rational_flag: bool, data: list):
             [[[1 / 5, 4 / 5], [3 / 5, 2 / 5]], [[1 / 4, 3 / 4], [1 / 4, 3 / 4]]],
         ),
         (
-            games.create_el_farol_bar_game_efg(),
+            games.read_from_file("el_farol_bar.efg"),
             False,
             [[4 / 9, 5 / 9], [0], [1 / 2, 1 / 2], [11 / 12, 1 / 12], [1 / 2, 1 / 2]],
         ),
-        (games.create_el_farol_bar_game_efg(), False, [[1 / 2, 1 / 2]]),
+        (games.read_from_file("el_farol_bar.efg"), False, [[1 / 2, 1 / 2]]),
     ],
 )
 def test_profile_data_error(game: gbt.Game, rational_flag: bool, data: list):

tests/test_mixed.py

@@ -46,10 +46,10 @@ def _set_action_probs(profile: gbt.MixedStrategyProfile, probs: list, rational_f
         ),
         ###############################################################################
         # centipede with chance efg
-        (games.create_centipede_game_with_chance_efg(), [[0, 0, 0, 0], [1, 0, 0, 0]], True),
-        (games.create_centipede_game_with_chance_efg(), [[1, 0, 0, 0], [0, 0, 0, 0]], True),
-        (games.create_centipede_game_with_chance_efg(), [[0, 0, 0, 0], [1, 0, 0, 0]], False),
-        (games.create_centipede_game_with_chance_efg(), [[1, 0, 0, 0], [0, 0, 0, 0]], False),
+        (games.read_from_file("cent3.efg"), [[0, 0, 0, 0], [1, 0, 0, 0]], True),
+        (games.read_from_file("cent3.efg"), [[1, 0, 0, 0], [0, 0, 0, 0]], True),
+        (games.read_from_file("cent3.efg"), [[0, 0, 0, 0], [1, 0, 0, 0]], False),
+        (games.read_from_file("cent3.efg"), [[1, 0, 0, 0], [0, 0, 0, 0]], False),
     ],
 )
 def test_normalize_zero_value_error(game, profile_data, rational_flag):
@@ -83,10 +83,10 @@ def test_normalize_zero_value_error(game, profile_data, rational_flag):
         ),
         ###############################################################################
         # centipede with chance efg
-        (games.create_centipede_game_with_chance_efg(), [[-1, 0, 0, 0], [1, 0, 0, 0]], True),
-        (games.create_centipede_game_with_chance_efg(), [[1, 0, 0, 0], [-1, 0, 0, 0]], True),
-        (games.create_centipede_game_with_chance_efg(), [[-1, 0, 0, 0], [1, 0, 0, 0]], False),
-        (games.create_centipede_game_with_chance_efg(), [[1, 0, 0, 0], [-1, 0, 0, 0]], False),
+        (games.read_from_file("cent3.efg"), [[-1, 0, 0, 0], [1, 0, 0, 0]], True),
+        (games.read_from_file("cent3.efg"), [[1, 0, 0, 0], [-1, 0, 0, 0]], True),
+        (games.read_from_file("cent3.efg"), [[-1, 0, 0, 0], [1, 0, 0, 0]], False),
+        (games.read_from_file("cent3.efg"), [[1, 0, 0, 0], [-1, 0, 0, 0]], False),
     ],
 )
 def test_normalize_neg_entry_value_error(game, profile_data, rational_flag):
@@ -115,13 +115,13 @@ def test_normalize_neg_entry_value_error(game, profile_data, rational_flag):
         ###############################################################################
         # centipede with chance efg
         (
-            games.create_centipede_game_with_chance_efg(),
+            games.read_from_file("cent3.efg"),
             [[1, 2, 3, 14], [1, 1, 1, 1]],
             [["1/20", "2/20", "3/20", "14/20"], ["1/4", "1/4", "1/4", "1/4"]],
             True,
         ),
         (
-            games.create_centipede_game_with_chance_efg(),
+            games.read_from_file("cent3.efg"),
             [[1.0, 2.0, 3.0, 14.0], [1, 1, 1, 1]],
             [[1 / 20, 2 / 20, 3 / 20, 14 / 20], [0.25, 0.25, 0.25, 0.25]],
             False,
@@ -544,8 +544,8 @@ def test_strategy_value_by_label_reference(
     [
         (games.read_from_file("mixed_behavior_game.efg"), False),
         (games.read_from_file("mixed_behavior_game.efg"), True),
-        (games.create_centipede_game_with_chance_efg(), False),
-        (games.create_centipede_game_with_chance_efg(), True),
+        (games.read_from_file("cent3.efg"), False),
+        (games.read_from_file("cent3.efg"), True),
     ],
 )
 def test_as_behavior_roundtrip(game: gbt.Game, rational_flag: bool):
@@ -774,14 +774,14 @@ def test_strategy_value_reference(
         ##############################################################################
         # El Farol bar game efg
         (
-            games.create_el_farol_bar_game_efg(),
+            games.read_from_file("el_farol_bar.efg"),
             [["1/2", "1/2"], ["1/2", "1/2"], ["1/2", "1/2"], ["1/2", "1/2"], ["1/2", "1/2"]],
             0,
             ZERO,
             True,
         ),
         (
-            games.create_el_farol_bar_game_efg(),
+            games.read_from_file("el_farol_bar.efg"),
             [[1, 0], [1, 0], [0, 1], [0, 1], [0, 1]],
             0,
             ZERO,
@@ -972,14 +972,14 @@ def test_liap_value_reference(
         ##############################################################################
         # El Farol bar game efg
         (
-            games.create_el_farol_bar_game_efg(),
+            games.read_from_file("el_farol_bar.efg"),
             [["1/2", "1/2"], ["1/2", "1/2"], ["1/2", "1/2"], ["1/2", "1/2"], ["1/2", "1/2"]],
             [0] * 5,
             ZERO,
             True,
         ),
         (
-            games.create_el_farol_bar_game_efg(),
+            games.read_from_file("el_farol_bar.efg"),
             [[1, 0], [1, 0], [0, 1], [0, 1], [0, 1]],
             [0] * 5,
             ZERO,
@@ -1104,12 +1104,12 @@ def test_player_regret_max_regret_reference(
         (games.read_from_file("2x2_bimatrix_all_zero_payoffs.nfg"), True),
         #################################################################################
         # El Farol bar game efg
-        (games.create_el_farol_bar_game_efg(), False),
-        (games.create_el_farol_bar_game_efg(), True),
+        (games.read_from_file("el_farol_bar.efg"), False),
+        (games.read_from_file("el_farol_bar.efg"), True),
         #################################################################################
         # Centipede with chance efg
-        (games.create_centipede_game_with_chance_efg(), False),
-        (games.create_centipede_game_with_chance_efg(), True),
+        (games.read_from_file("cent3.efg"), False),
+        (games.read_from_file("cent3.efg"), True),
         #################################################################################
         # 2x2x2 nfg
         (games.read_from_file("2x2x2_nfg_from_local_max_cut_2_pure_1_mixed_eq.nfg"), False),
@@ -1146,27 +1146,27 @@ def test_strategy_regret_consistency(game: gbt.Game, rational_flag: bool):
         #################################################################################
         # Centipede with chance efg
         (
-            games.create_centipede_game_with_chance_efg(),
+            games.read_from_file("cent3.efg"),
             [["1/3", "1/3", "1/3", "0/1"], ["1/10", "3/5", "3/10", 0]],
             ZERO,
             True,
         ),
         (
-            games.create_centipede_game_with_chance_efg(),
+            games.read_from_file("cent3.efg"),
             [[1 / 3, 1 / 3, 1 / 3, 0], [0.10, 3 / 5, 0.3, 0]],
             TOL,
             False,
         ),
         #################################################################################
         # El Farol bar game efg
         (
-            games.create_el_farol_bar_game_efg(),
+            games.read_from_file("el_farol_bar.efg"),
             [[1, 0], ["1/2", "1/2"], ["1/3", "2/3"], ["1/5", "4/5"], ["1/8", "7/8"]],
             ZERO,
             True,
         ),
         (
-            games.create_el_farol_bar_game_efg(),
+            games.read_from_file("el_farol_bar.efg"),
             [[1, 0], [1 / 2, 1 / 2], [1 / 3, 2 / 3], [1 / 5, 4 / 5], [1 / 8, 7 / 8]],
             TOL,
             False,
@@ -1239,27 +1239,27 @@ def test_liap_value_consistency(
         #################################################################################
         # Centipede with chance efg
         (
-            games.create_centipede_game_with_chance_efg(),
+            games.read_from_file("cent3.efg"),
             [["1/3", "1/3", "1/3", "0/1"], ["1/10", "3/5", "3/10", 0]],
             ZERO,
             True,
         ),
         (
-            games.create_centipede_game_with_chance_efg(),
+            games.read_from_file("cent3.efg"),
             [[1 / 3, 1 / 3, 1 / 3, 0], [0.10, 3 / 5, 0.3, 0]],
             TOL,
             False,
         ),
         #################################################################################
         # El Farol bar game efg
         (
-            games.create_el_farol_bar_game_efg(),
+            games.read_from_file("el_farol_bar.efg"),
             [[1, 0], ["1/2", "1/2"], ["1/3", "2/3"], ["1/5", "4/5"], ["1/8", "7/8"]],
             ZERO,
             True,
         ),
         (
-            games.create_el_farol_bar_game_efg(),
+            games.read_from_file("el_farol_bar.efg"),
             [[1, 0], [1 / 2, 1 / 2], [1 / 3, 2 / 3], [1 / 5, 4 / 5], [1 / 8, 7 / 8]],
             TOL,
             False,
@@ -1343,15 +1343,15 @@ def test_player_regret_max_regret_consistency(
         #################################################################################
         # Centipede game with chance
         (
-            games.create_centipede_game_with_chance_efg(),
+            games.read_from_file("cent3.efg"),
             [["1/3", "1/3", "1/3", "0/1"], ["1/10", "3/5", "3/10", "0/1"]],
             [["1/3", "1/3", "1/3", "0/1"], ["1/5", "2/5", "1/5", "1/5"]],
             gbt.Rational("1/12"),
             ZERO,
             True,
         ),
         (
-            games.create_centipede_game_with_chance_efg(),
+            games.read_from_file("cent3.efg"),
             [[1 / 3, 1 / 3, 1 / 3, 0 / 1], [1 / 10, 3 / 5, 3 / 10, 0 / 1]],
             [[1 / 3, 1 / 3, 1 / 3, 0 / 1], [1 / 5, 2 / 5, 1 / 5, 1 / 5]],
             1 / 12,
@@ -1371,7 +1371,7 @@ def test_player_regret_max_regret_consistency(
         #################################################################################
         # El Farol bar game
         (
-            games.create_el_farol_bar_game_efg(),
+            games.read_from_file("el_farol_bar.efg"),
             [["4/9", "5/9"], ["1/3", "2/3"], ["1/2", "1/2"], ["11/12", "1/12"], ["1/2", "1/2"]],
             [["4/9", "5/9"], ["1/3", "2/3"], ["1/2", "1/2"], ["1/12", "11/12"], ["1/2", "1/2"]],
             gbt.Rational("1/2"),
@@ -1445,13 +1445,13 @@ def test_linearity_payoff_property(
         #################################################################################
         # Centipede game with chance
         (
-            games.create_centipede_game_with_chance_efg(),
+            games.read_from_file("cent3.efg"),
             [["1/5", "2/5", "1/5", "1/5"], ["1/10", "3/5", "3/10", "0/1"]],
             ZERO,
             True,
         ),
         (
-            games.create_centipede_game_with_chance_efg(),
+            games.read_from_file("cent3.efg"),
             [[1 / 3, 1 / 3, 1 / 3, 0 / 1], [1 / 10, 3 / 5, 3 / 10, 0 / 1]],
             TOL,
             False,
@@ -1473,7 +1473,7 @@ def test_linearity_payoff_property(
         #################################################################################
         # El Farol bar game
         (
-            games.create_el_farol_bar_game_efg(),
+            games.read_from_file("el_farol_bar.efg"),
             [["4/9", "5/9"], ["1/3", "2/3"], ["0/1", "1/1"], ["11/12", "1/12"], ["1/3", "2/3"]],
             ZERO,
             True,
@@ -1523,15 +1523,15 @@ def test_payoff_and_strategy_value_consistency(
         #################################################################################
         # centipede game with chance
         (
-            games.create_centipede_game_with_chance_efg(),
+            games.read_from_file("cent3.efg"),
             [["1/3", "1/3", "1/3", "0"], ["1/10", "3/5", "3/10", "0"]],
             [["1/3", "1/3", "1/3", "0"], ["1/10", "3/5", "3/10", "0"]],
             "82943/62500",
             True,
             ZERO,
         ),
         (
-            games.create_centipede_game_with_chance_efg(),
+            games.read_from_file("cent3.efg"),
             [[1 / 3, 1 / 3, 1 / 3, 0], [1 / 10, 3 / 5, 3 / 10, 0]],
             [[1 / 3, 1 / 3, 1 / 3, 0], [1 / 10, 3 / 5, 3 / 10, 0]],
             82943 / 62500,