Raise UndefinedOperationError for game.player.{actions,infosets,nodes} on non-trees (#701)

Author: rahulsavani

src/pygambit/game.pxi

@@ -745,7 +745,16 @@ class Game:
         .. versionchanged:: 16.4
            Changed from a method ``nodes()`` to a property.
 
+        Raises
+        ------
+        UndefinedOperationError
+            If the game does not have a tree representation.
         """
+        if not self.is_tree:
+            raise UndefinedOperationError(
+                "Operation only defined for games with a tree representation"
+            )
+
         return GameNodes.wrap(self.game)
 
     @property
@@ -1888,11 +1897,20 @@ class Game:
 
         .. versionadded:: 16.4.0
 
+        Raises
+        ------
+        UndefinedOperationError
+            If the game does not have a tree representation.
+
         See also
         --------
         Player.infosets
         Infoset.members
         """
+        if not self.is_tree:
+            raise UndefinedOperationError(
+                "Operation only defined for games with a tree representation"
+            )
         self.game.deref().SortInfosets()
 
     def add_player(self, label: str = "") -> Player:

src/pygambit/player.pxi

@@ -228,15 +228,34 @@ class Player:
            previously, information sets were (expensively) re-sorted after every change
            to the game tree.
 
+        Raises
+        ------
+        UndefinedOperationError
+            If the game does not have a tree representation.
+
         See also
         --------
         Game.sort_infosets
         """
+        if not self.game.is_tree:
+            raise UndefinedOperationError(
+                "Operation only defined for games with a tree representation"
+            )
         return PlayerInfosets.wrap(self.player)
 
     @property
     def actions(self) -> PlayerActions:
-        """Returns the set of actions available to the player at some information set."""
+        """Returns the set of actions available to the player at some information set.
+
+        Raises
+        ------
+        UndefinedOperationError
+            If the game does not have a tree representation.
+        """
+        if not self.game.is_tree:
+            raise UndefinedOperationError(
+                "Operation only defined for games with a tree representation"
+            )
         return PlayerActions.wrap(self)
 
     @property

tests/test_strategic.py

@@ -11,12 +11,24 @@ def test_strategic_game_actions():
         _ = game.actions
 
 
+def test_strategic_game_player_actions():
+    game = gbt.Game.new_table([2, 2])
+    with pytest.raises(gbt.UndefinedOperationError):
+        _ = game.players[0].actions
+
+
 def test_strategic_game_infosets():
     game = gbt.Game.new_table([2, 2])
     with pytest.raises(gbt.UndefinedOperationError):
         _ = game.infosets
 
 
+def test_strategic_game_player_infosets():
+    game = gbt.Game.new_table([2, 2])
+    with pytest.raises(gbt.UndefinedOperationError):
+        _ = game.players[0].infosets
+
+
 def test_strategic_game_root():
     game = gbt.Game.new_table([2, 2])
     with pytest.raises(gbt.UndefinedOperationError):
@@ -25,7 +37,14 @@ def test_strategic_game_root():
 
 def test_strategic_game_nodes():
     game = gbt.Game.new_table([2, 2])
-    assert list(game.nodes) == []
+    with pytest.raises(gbt.UndefinedOperationError):
+        _ = game.nodes
+
+
+def test_strategic_game_sort_infosets():
+    game = gbt.Game.new_table([2, 2])
+    with pytest.raises(gbt.UndefinedOperationError):
+        _ = game.sort_infosets()
 
 
 def test_game_behav_profile_error():